[Lldb-commits] [PATCH] D96370: Pass enviroment variables to python scripts.

2021-02-10 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Yep, I agree with what Jim said. In addition it seems that lldb already honors the PYTHONPATH variable (as passed to the lldb process), so that would be another way to control the script location. PYTHONPATH=/tmp/foobar lldb -o "script print(sys.path)" -b (lldb)

[Lldb-commits] [PATCH] D96370: Pass enviroment variables to python scripts.

2021-02-09 Thread Jim Ingham via Phabricator via lldb-commits
jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. Modifying the target environment in order to add something to the host lldb's PYTHONPATH seems very counterintuitive to me. It is misusing the purpose of the target environment

[Lldb-commits] [PATCH] D96370: Pass enviroment variables to python scripts.

2021-02-09 Thread Rumeet Dhindsa via Phabricator via lldb-commits
rdhindsa updated this revision to Diff 322510. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96370/new/ https://reviews.llvm.org/D96370 Files: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp

[Lldb-commits] [PATCH] D96370: Pass enviroment variables to python scripts.

2021-02-09 Thread Rumeet Dhindsa via Phabricator via lldb-commits
rdhindsa created this revision. rdhindsa added a reviewer: labath. rdhindsa requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. It enables environment variables set for lldb targets to be passed to python scripts. This allows the user to put