[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

mgorny added a comment. Herald added a subscriber: JDevlieghere. This changed the API of `RegisterInfoPOSIX_arm64` and broke the FreeBSD plugin. I'm going to try to fix it but next time it'd be nice if you checked that the class isn't used by something before making changes to its API.

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd6d3d21cd1cb: [LLDB] Add support for Arm64/Linux dynamic register sets (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I very happy with how this has turned out. Thanks for your patience. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96458/new/ https://reviews.llvm.org/D96458

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid updated this revision to Diff 331834. omjavaid added a comment. This update further cleans up and removes static functions that calculated m_register_info_p GetRegisterInfoPtr and m_register_info_count GetRegisterInfoCount CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid updated this revision to Diff 331830. omjavaid added a comment. This update address review comments from @labath CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96458/new/ https://reviews.llvm.org/D96458 Files:

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

labath added a comment. Right, I see. The contained lists are going to make this trickier than I expected, and might even make the code more complicated. (Though this tradeoff will change if we ever end up with two optional regsets that need to mess with contained lists.) Could we at least

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid added a comment. In D96458#2625554 , @omjavaid wrote: > In D96458#2624962 , @labath wrote: > >> Thanks. This looks much better, but there is still one thing which bugs me >> about the register info

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid added a comment. In D96458#2624962 , @labath wrote: > Thanks. This looks much better, but there is still one thing which bugs me > about the register info constructor. Currently, there are three paths through > that constructor: > > 1. when we

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

labath added a comment. Thanks. This looks much better, but there is still one thing which bugs me about the register info constructor. Currently, there are three paths through that constructor: 1. when we don't have any fancy registers (this is the original one) 2. when we have just SVE

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid updated this revision to Diff 330187. omjavaid added a comment. This update incorporates changes written by @labath CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96458/new/ https://reviews.llvm.org/D96458 Files:

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

labath added a comment. Yes, definitely. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96458/new/ https://reviews.llvm.org/D96458 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid added a comment. In D96458#2618846 , @labath wrote: > Would something like F15819833: reginfo.diff > do the trick? It needs a bit of cleanup > (I haven't actually removed `ConfigureRegisterInfos` function

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

labath added a comment. Would something like F15819833: reginfo.diff do the trick? It needs a bit of cleanup (I haven't actually removed `ConfigureRegisterInfos` function yet -- I just moved it right next to the reginfo creation), but I think should make it

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid added a comment. In D96458#2614101 , @labath wrote: > In D96458#2614076 , @omjavaid wrote: > >> In D96458#2613948 , @labath wrote: >> >>> In D96458#2613894

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

labath added a comment. In D96458#2614076 , @omjavaid wrote: > In D96458#2613948 , @labath wrote: > >> In D96458#2613894 , @omjavaid wrote: >> >>> ConfigureRegisterContext

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid added a comment. In D96458#2613948 , @labath wrote: > In D96458#2613894 , @omjavaid wrote: > >> ConfigureRegisterContext is called only once in the lifetime of a core from >>

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

labath added a comment. In D96458#2613894 , @omjavaid wrote: > ConfigureRegisterContext is called only once in the lifetime of a core from > RegisterContextCorePOSIX_arm64 constructor. A process registers cannot change > during execution which is what

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid added a comment. In D96458#2613244 , @labath wrote: > In D96458#2578760 , @omjavaid wrote: > >> In D96458#2566347 , @labath wrote: >> >>> I'm sorry, my response

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid added a comment. @labath @rovka any further comments on this one? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96458/new/ https://reviews.llvm.org/D96458 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

labath added a comment. In D96458#2578760 , @omjavaid wrote: > In D96458#2566347 , @labath wrote: > >> I'm sorry, my response times are pretty slow these days. >> >> I'm thinking about this `ConfigureRegisterInfos`

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid updated this revision to Diff 329232. omjavaid added a comment. This update fixes review comments highlighted by @rovka CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96458/new/ https://reviews.llvm.org/D96458 Files:

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:81 + Status error = ReadSVEHeader(); + uint32_t opt_regset = RegisterInfoPOSIX_arm64::eRegsetEnableDefault; + if (error.Success()) { rovka

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

rovka added a comment. Hi Omair, I had a look and I think the commit message is slightly misleading because it says "Arm64 has dynamic features like SVE, Pointer Authentication and MTE", but then you don't set m_reg_infos_is_dynamic to true for SVE. This got me a bit confused at first. Maybe

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid updated this revision to Diff 325433. omjavaid added a comment. This moves ConfigureRegisterInfos into constructor. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96458/new/ https://reviews.llvm.org/D96458 Files:

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid added a comment. In D96458#2566347 , @labath wrote: > I'm sorry, my response times are pretty slow these days. > > I'm thinking about this `ConfigureRegisterInfos` business. I get that the > vector length is variable, and so we need to refresh

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

labath added a comment. I'm sorry, my response times are pretty slow these days. I'm thinking about this `ConfigureRegisterInfos` business. I get that the vector length is variable, and so we need to refresh it after every stop. However, the set of enabled extensions seems more static. Is it

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid updated this revision to Diff 323928. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96458/new/ https://reviews.llvm.org/D96458 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_arm64.cpp

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid added a comment. thanks @DavidSpickett for the review. I have updated diff incorporating you suggestions. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:454 bool NativeRegisterContextLinux_arm64::IsSVE(unsigned reg) const { - if

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:454 bool NativeRegisterContextLinux_arm64::IsSVE(unsigned reg) const { - if (GetRegisterInfo().GetRegisterSetFromRegisterIndex(reg) == -

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid created this revision. omjavaid added a reviewer: labath. Herald added a subscriber: kristof.beyls. omjavaid requested review of this revision. This is the first patch in series for supporting Arm64 dynamic features in LLDB. Arm64 has dynamic features like SVE, Pointer Authentication