[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. @omjavaid I get some new warnings when compiling this on x86: [732/1117] Building CXX object too.../RegisterContextDarwin_arm64.cpp.o In file included from

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1164b4e29572: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers (authored by omjavaid). Herald added a project: LLDB. Changed prior

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good (and sorry for the delay). Just rebase to main to avoid the cast. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:77 +

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

omjavaid updated this revision to Diff 332617. omjavaid added a comment. Herald added a subscriber: emaste. Pulling GetAuxValue from NativeProcessELF. @labath what do you think. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96460/new/ https://reviews.llvm.org/D96460 Files:

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. This still suffers from the duplication of the auxv reading code from NativeProcessELF. Other than that, it's ok-ish. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

omjavaid updated this revision to Diff 331835. omjavaid added a comment. Rebased after changes to parent D96458 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96460/new/ https://reviews.llvm.org/D96460 Files:

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

omjavaid updated this revision to Diff 330189. omjavaid added a comment. Updated after changes in parent. Also removed D96459 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96460/new/ https://reviews.llvm.org/D96460 Files:

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

omjavaid updated this revision to Diff 329239. omjavaid added a comment. Rebased after changes to parent. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96460/new/ https://reviews.llvm.org/D96460 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterInfoPOSIX_arm64.cpp:276 +if (opt_regsets & eRegsetEnableMTE) + m_mte_regset_enabled = true; } omjavaid wrote: > DavidSpickett wrote: > > (like earlier) would

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

omjavaid updated this revision to Diff 325493. omjavaid added a comment. Ran clang format and fixed typos. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96460/new/ https://reviews.llvm.org/D96460 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:1128 + if (error.Success()) m_sve_header_is_valid = true; DavidSpickett wrote: > Indent here > > Actually, for these you could just do

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:1128 + if (error.Success()) m_sve_header_is_valid = true; Indent here Actually, for these you could just do `m_sve_header_is_valid =

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

omjavaid updated this revision to Diff 325435. omjavaid added a comment. Rebased after updates to parent. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96460/new/ https://reviews.llvm.org/D96460 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:1198 + + if (m_mte_ctrl_is_valid) +return error; omjavaid wrote: > DavidSpickett wrote: > > Just to confirm I understand this logic. > >

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

omjavaid updated this revision to Diff 324018. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96460/new/ https://reviews.llvm.org/D96460 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.h

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

omjavaid updated this revision to Diff 324017. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96460/new/ https://reviews.llvm.org/D96460 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.h

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

omjavaid added a comment. Subsequent update will resolve review comments. @DavidSpickett thanks for review. much appreciated Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:79 + m_mte_ctrl_reg = 0; + DavidSpickett

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:79 + m_mte_ctrl_reg = 0; + Should m_pac_mask also be initialised or is it already? Comment at:

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

omjavaid created this revision. omjavaid added a reviewer: labath. Herald added a subscriber: kristof.beyls. omjavaid requested review of this revision. This patch adds two new register sets for MTE and Pointer Authentication feature registers. These register sets are dynamic and will only be