felipepiovezan wrote:
> > This seems akin to running clang-format on the entire project, which last
> > time we talked about still faced opposition
>
> My impression (I admit I haven't reviewed the whole thread lately) is that
> the opposition has mostly to do with how clang-format mangles
pogo59 wrote:
> This seems akin to running clang-format on the entire project, which last
> time we talked about still faced opposition
My impression (I admit I haven't reviewed the whole thread lately) is that the
opposition has mostly to do with how clang-format mangles some constructs, not
dwblaikie wrote:
The dev policy says "Avoid committing formatting- or whitespace-only changes
outside of code you plan to make subsequent changes to." - I think it's
reasonable to consider changing this, but probably under the "clang-format
everything" or a similar discussion (broad
jrtc27 wrote:
Also this is the kind of commit that should really be done by a core trusted
member of the community. It's way too easy to hide something nefarious (not
that I'm accusing you of that, just that we always need to be vigilant) in an
8k+ diff, and it's not much fun to review that
arichardson wrote:
This will cause huge merge conflicts for all downstreams. While they are easy
to resolve it can be quite annoying. I think we should just do this as part of
the global clang-format.
https://github.com/llvm/llvm-project/pull/82838
felipepiovezan wrote:
Juuust to make sure, was this discussed before? This seems akin to running
clang-format on the entire project, which last time we talked about still faced
opposition:
https://discourse.llvm.org/t/rfc-clang-format-all-the-things/76614/11
joker-eph wrote:
Fine with me if we want to land this as is, but per-top-level subproject may be
a better granularity.
https://github.com/llvm/llvm-project/pull/82838
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
github-actions[bot] wrote:
⚠️ We detected that you are using a GitHub private e-mail address to contribute
to the repo.
Please turn off [Keep my email addresses
private](https://github.com/settings/emails) setting in your account.
See [LLVM
AtariDreams wrote:
I'm just gonna split this up. Sorry.
https://github.com/llvm/llvm-project/pull/82838
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/AtariDreams closed
https://github.com/llvm/llvm-project/pull/82838
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-backend-arm
@llvm/pr-subscribers-clang
Author: AtariDreams (AtariDreams)
Changes
Every once in a while, some formatting scanner will cause the CI to stop
because of whitespace issues, so it is is best to just remove them in one go,
especially since it
11 matches
Mail list logo
