[Lldb-commits] [lldb] [lldb/crashlog] Enforce image loading policy (PR #91109)

https://github.com/medismailben closed https://github.com/llvm/llvm-project/pull/91109 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/crashlog] Enforce image loading policy (PR #91109)

https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/91109 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/crashlog] Enforce image loading policy (PR #91109)

https://github.com/medismailben updated https://github.com/llvm/llvm-project/pull/91109 >From 625245737c31ac4e2cf04417bc8457caa461ef31 Mon Sep 17 00:00:00 2001 From: Med Ismail Bennani Date: Thu, 9 May 2024 10:02:50 -0700 Subject: [PATCH] [lldb/crashlog] Enforce image loading policy In `27f27d

[Lldb-commits] [lldb] [lldb/crashlog] Enforce image loading policy (PR #91109)

@@ -526,6 +526,47 @@ def create_target(self): def get_target(self): return self.target +def load_images(self, options, loaded_images=[]): medismailben wrote: Good point https://github.com/llvm/llvm-project/pull/91109 _

[Lldb-commits] [lldb] [lldb/crashlog] Enforce image loading policy (PR #91109)

@@ -526,6 +526,47 @@ def create_target(self): def get_target(self): return self.target +def load_images(self, options, loaded_images=[]): bulbazord wrote: Suggestion: Default `loaded_images` to `None`. You probably don't want `loaded_images`

[Lldb-commits] [lldb] [lldb/crashlog] Enforce image loading policy (PR #91109)

https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/91109 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/crashlog] Enforce image loading policy (PR #91109)

https://github.com/medismailben updated https://github.com/llvm/llvm-project/pull/91109 >From 7b85cc474b55db9394fd9353e5cb0c7b32cd821c Mon Sep 17 00:00:00 2001 From: Med Ismail Bennani Date: Sun, 5 May 2024 22:14:42 -0700 Subject: [PATCH] [lldb/crashlog] Enforce image loading policy In `27f27d

[Lldb-commits] [lldb] [lldb/crashlog] Enforce image loading policy (PR #91109)

https://github.com/medismailben edited https://github.com/llvm/llvm-project/pull/91109 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/crashlog] Enforce image loading policy (PR #91109)

https://github.com/medismailben updated https://github.com/llvm/llvm-project/pull/91109 >From d732da2c059657e2f0acca402e24788bc40a57ef Mon Sep 17 00:00:00 2001 From: Med Ismail Bennani Date: Sun, 5 May 2024 20:18:22 -0700 Subject: [PATCH] [lldb/crashlog] Enforce image loading policy In `27f27d

[Lldb-commits] [lldb] [lldb/crashlog] Enforce image loading policy (PR #91109)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Med Ismail Bennani (medismailben) Changes Starting `27f27d1`, we changed the image loading logic to conform to the various options (`-a|--load-all` & `-c|--crashed-only`) and set the `resolve` attribute of the matching images. Then, we wo

[Lldb-commits] [lldb] [lldb/crashlog] Enforce image loading policy (PR #91109)

https://github.com/medismailben created https://github.com/llvm/llvm-project/pull/91109 Starting `27f27d1`, we changed the image loading logic to conform to the various options (`-a|--load-all` & `-c|--crashed-only`) and set the `resolve` attribute of the matching images. Then, we would try t