[Lldb-commits] [lldb] [lldb][Test] Add C++ tests for DumpValueObjectOptions and enums (PR #93158)

https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/93158 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Test] Add C++ tests for DumpValueObjectOptions and enums (PR #93158)

DavidSpickett wrote: I only intend to use the (soon to be) proposed new options from C++, so I'm going to land this as is, but we certainly could pursue the API route later. https://github.com/llvm/llvm-project/pull/93158 ___ lldb-commits mailing

[Lldb-commits] [lldb] [lldb][Test] Add C++ tests for DumpValueObjectOptions and enums (PR #93158)

jimingham wrote: LGTM. We do offer SBValue::GetDescription, which uses a default DumpValueObjectOptions. So it would be entirely reasonable to make an SBValueObjectDescriptionOptions (or maybe a shorter name?) and add SBValue::GetDescription(SBValueObjectDescriptionOptions) API. But

[Lldb-commits] [lldb] [lldb][Test] Add C++ tests for DumpValueObjectOptions and enums (PR #93158)

https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/93158 >From 0c6fe37563d7e7ee338a308b32cbea01d1f3808c Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 1 May 2024 13:08:54 + Subject: [PATCH 1/2] [lldb][Test] Add C++ tests for DumpValueObjectOptions

[Lldb-commits] [lldb] [lldb][Test] Add C++ tests for DumpValueObjectOptions and enums (PR #93158)

@@ -0,0 +1,136 @@ +//===-- DumpValueObjectOptionsTests.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb][Test] Add C++ tests for DumpValueObjectOptions and enums (PR #93158)

https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/93158 >From aff2acafd911b9eb07405beb5500a487f5d4fc4e Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 1 May 2024 13:08:54 + Subject: [PATCH 1/2] [lldb][Test] Add C++ tests for DumpValueObjectOptions

[Lldb-commits] [lldb] [lldb][Test] Add C++ tests for DumpValueObjectOptions and enums (PR #93158)

@@ -0,0 +1,136 @@ +//===-- DumpValueObjectOptionsTests.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb][Test] Add C++ tests for DumpValueObjectOptions and enums (PR #93158)

@@ -0,0 +1,136 @@ +//===-- DumpValueObjectOptionsTests.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb][Test] Add C++ tests for DumpValueObjectOptions and enums (PR #93158)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes DumpValueObjectOptions can only be created and modified from C++. This means it's currently only testable from Python by calling some command that happens to use one, and even so, you can't pick

[Lldb-commits] [lldb] [lldb][Test] Add C++ tests for DumpValueObjectOptions and enums (PR #93158)

https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/93158 DumpValueObjectOptions can only be created and modified from C++. This means it's currently only testable from Python by calling some command that happens to use one, and even so, you can't pick which