walter-erquinigo wrote:
@semensanyok, I've just merged this PR because it's very straightforward. If it
breaks the buildbots, I'll just revert it and let the original author fix it.
https://github.com/llvm/llvm-project/pull/73393
___
lldb-commits
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/73393
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
semensanyok wrote:
Bug confirmed. Its causing exception for nvim-dap plugin which expects column
required in specification, but not sent by server.
pr contains log message, showing missing column case. closed by maintainer:
> Thanks for the PR, but I'm not going to merge this. column is a
https://github.com/walter-erquinigo approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/73393
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
Lgtm thanks!
https://github.com/llvm/llvm-project/pull/73393
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -817,8 +817,7 @@ llvm::json::Value CreateStackFrame(lldb::SBFrame ) {
if (line && line != LLDB_INVALID_LINE_NUMBER)
object.try_emplace("line", line);
xujuntwt95329 wrote:
Thanks! Updated
https://github.com/llvm/llvm-project/pull/73393
https://github.com/xujuntwt95329 updated
https://github.com/llvm/llvm-project/pull/73393
>From 4621be9af9a8003c52850ed57ae7a24f26769b2c Mon Sep 17 00:00:00 2001
From: Xu Jun <693788...@qq.com>
Date: Sat, 25 Nov 2023 22:52:53 +0800
Subject: [PATCH 1/2] [lldb][dap] always add column field in
@@ -817,8 +817,7 @@ llvm::json::Value CreateStackFrame(lldb::SBFrame ) {
if (line && line != LLDB_INVALID_LINE_NUMBER)
object.try_emplace("line", line);
bulbazord wrote:
>From the [DAP
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Xu Jun (xujuntwt95329)
Changes
The `column` field is mandatory in StackTraceResponse, otherwise the debugger
client may raise error (e.g. VSCode can't correctly open an editor without the
column field)
---
Full diff:
https://github.com/xujuntwt95329 created
https://github.com/llvm/llvm-project/pull/73393
The `column` field is mandatory in StackTraceResponse, otherwise the debugger
client may raise error (e.g. VSCode can't correctly open an editor without the
column field)
>From
10 matches
Mail list logo
