https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/84998
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/84998
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jasonmolenda wrote:
Thanks for all the helpful comments as always, David. I updated the test case
to fix the issues you identified and added comments that I think make it
clearer that it is testing both a live process and a corefile.
https://github.com/llvm/llvm-project/pull/84998
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/84998
>From 4278537c262b01b1d6432391bd9d8017eb96c60a Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Tue, 12 Mar 2024 17:09:30 -0700
Subject: [PATCH 1/2] [lldb] [Mach-O] ProcessMachCore needs to strip TBI data
@@ -0,0 +1,13 @@
+#include
+#include
+union ptrbytes {
+ int *p;
+ uint8_t bytes[8];
+};
DavidSpickett wrote:
I like this way of avoiding shifts.
https://github.com/llvm/llvm-project/pull/84998
___
lldb-commits
@@ -0,0 +1,49 @@
+"""Test that lldb on Darwin ignores metadata in the top byte of addresses."""
+
+import os
+import re
+import subprocess
+
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
@@ -0,0 +1,49 @@
+"""Test that lldb on Darwin ignores metadata in the top byte of addresses."""
DavidSpickett wrote:
Oh I get it, you're running a process first then making a core file and
expecting to get the same output.
This needs to be made clear at the
@@ -0,0 +1,49 @@
+"""Test that lldb on Darwin ignores metadata in the top byte of addresses."""
+
+import os
+import re
+import subprocess
+
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
@@ -0,0 +1,49 @@
+"""Test that lldb on Darwin ignores metadata in the top byte of addresses."""
+
+import os
+import re
+import subprocess
+
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
@@ -0,0 +1,49 @@
+"""Test that lldb on Darwin ignores metadata in the top byte of addresses."""
DavidSpickett wrote:
addresses in core files.
Also the filename should have core somewhere in it.
https://github.com/llvm/llvm-project/pull/84998
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jason Molenda (jasonmolenda)
Changes
Darwin AArch64 application processors are run with Top Byte Ignore mode enabled
so metadata may be stored in the top byte, it needs to be ignored when
reading/writing memory. David Spickett handled
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/84998
Darwin AArch64 application processors are run with Top Byte Ignore mode enabled
so metadata may be stored in the top byte, it needs to be ignored when
reading/writing memory. David Spickett handled this
12 matches
Mail list logo
