DavidSpickett wrote:
Rebased to include
https://github.com/llvm/llvm-project/commit/799316ff26cc82d60f276dc62c4a69b5bba1aef3
and have addressed the open comments.
https://github.com/llvm/llvm-project/pull/90063
___
lldb-commits mailing list
@@ -13,11 +13,42 @@
#include
#include
+#include "llvm/ADT/StringSet.h"
+
namespace lldb_private {
class StreamString;
class Log;
+class FieldEnum {
+public:
+ struct Enumerator {
+uint64_t m_value;
+// Short name for the value. Shown in tables and when
@@ -13,11 +13,42 @@
#include
#include
+#include "llvm/ADT/StringSet.h"
+
namespace lldb_private {
class StreamString;
class Log;
+class FieldEnum {
+public:
+ struct Enumerator {
+uint64_t m_value;
+// Short name for the value. Shown in tables and when
@@ -13,11 +13,42 @@
#include
#include
+#include "llvm/ADT/StringSet.h"
+
namespace lldb_private {
class StreamString;
class Log;
+class FieldEnum {
+public:
+ struct Enumerator {
+uint64_t m_value;
+// Short name for the value. Shown in tables and when
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/90063
>From 722704c323a68d426e127308f8e247fb7f94e414 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Mon, 11 Mar 2024 10:51:22 +
Subject: [PATCH] [lldb] Add register field enum class
This represents the
DavidSpickett wrote:
Thanks for the reviews.
The next PR has some test output that depends on the format added in
https://github.com/llvm/llvm-project/pull/90059, which itself has some
complexity I didn't expect. So I'm going to work on that PR first before
updating this.
@@ -13,11 +13,42 @@
#include
#include
+#include "llvm/ADT/StringSet.h"
+
namespace lldb_private {
class StreamString;
class Log;
+class FieldEnum {
+public:
+ struct Enumerator {
+uint64_t m_value;
+// Short name for the value. Shown in tables and when
@@ -13,11 +13,42 @@
#include
#include
+#include "llvm/ADT/StringSet.h"
+
namespace lldb_private {
class StreamString;
class Log;
+class FieldEnum {
+public:
+ struct Enumerator {
+uint64_t m_value;
+// Short name for the value. Shown in tables and when
@@ -13,11 +13,42 @@
#include
#include
+#include "llvm/ADT/StringSet.h"
+
namespace lldb_private {
class StreamString;
class Log;
+class FieldEnum {
+public:
+ struct Enumerator {
+uint64_t m_value;
+// Short name for the value. Shown in tables and when
@@ -13,11 +13,42 @@
#include
#include
+#include "llvm/ADT/StringSet.h"
+
namespace lldb_private {
class StreamString;
class Log;
+class FieldEnum {
+public:
+ struct Enumerator {
+uint64_t m_value;
+// Short name for the value. Shown in tables and when
@@ -13,11 +13,42 @@
#include
#include
+#include "llvm/ADT/StringSet.h"
+
namespace lldb_private {
class StreamString;
class Log;
+class FieldEnum {
+public:
+ struct Enumerator {
+uint64_t m_value;
+// Short name for the value. Shown in tables and when
DavidSpickett wrote:
The tests for the next PR depend on the format decided by
https://github.com/llvm/llvm-project/pull/90059, which needs more work. So I
will land this once that's sorted out.
https://github.com/llvm/llvm-project/pull/90063
___
https://github.com/medismailben approved this pull request.
Pretty cool! LGTM!
https://github.com/llvm/llvm-project/pull/90063
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
This represents the enum type that can be assigned to a field using the
`enum` element in the target XML.
https://sourceware.org/gdb/current/onlinedocs/gdb.html/Enum-Target-Types.html
Each
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/90063
This represents the enum type that can be assigned to a field using the
`` element in the target XML.
https://sourceware.org/gdb/current/onlinedocs/gdb.html/Enum-Target-Types.html
Each enumerator has:
*
15 matches
Mail list logo