https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/92273
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/92273
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
slydiman wrote:
> Could this use `os.devnull`
Sure. It is much better. I have updated the patch. Thanks.
https://github.com/llvm/llvm-project/pull/92273
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/92273
>From 6341c038d41ac3b533314568187b8d5d390dc861 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Wed, 15 May 2024 18:38:16 +0400
Subject: [PATCH 1/2] [lldb] Fixed the TestFdLeak test
Use `NUL` instead of
https://github.com/JDevlieghere commented:
Could this use `os.devnull` to pick the right one based on the platform this is
running on?
```
self.do_test(["log enable -f '{}}' lldb commands".format(os.devnull)])
```
https://github.com/llvm/llvm-project/pull/92273
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
Use `NUL` instead of `/dev/null` in case of the Windows host.
---
Full diff: https://github.com/llvm/llvm-project/pull/92273.diff
1 Files Affected:
- (modified)
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/92273
Use `NUL` instead of `/dev/null` in case of the Windows host.
>From 6341c038d41ac3b533314568187b8d5d390dc861 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Wed, 15 May 2024 18:38:16 +0400
Subject:
