https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/84071
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jimingham approved this pull request.
Yes, this looks fine to me for adding the mangled name.
https://github.com/llvm/llvm-project/pull/84071
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/clayborg approved this pull request.
Looks good for just including the mangled name.
https://github.com/llvm/llvm-project/pull/84071
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
@@ -524,6 +524,9 @@ void BreakpointLocation::GetDescription(Stream *s,
s->EOL();
s->Indent("function = ");
s->PutCString(sc.function->GetName().AsCString(""));
+ s->EOL();
+ s->Indent("mangled function = ");
+
@@ -524,6 +524,9 @@ void BreakpointLocation::GetDescription(Stream *s,
s->EOL();
s->Indent("function = ");
s->PutCString(sc.function->GetName().AsCString(""));
+ s->EOL();
+ s->Indent("mangled function = ");
+
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/84071
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -524,6 +524,9 @@ void BreakpointLocation::GetDescription(Stream *s,
s->EOL();
s->Indent("function = ");
s->PutCString(sc.function->GetName().AsCString(""));
+ s->EOL();
+ s->Indent("mangled function = ");
+
@@ -90,6 +90,15 @@ def breakpoint_options_language_test(self):
num_expected_locations=1,
)
felipepiovezan wrote:
Nice! this works really well
https://github.com/llvm/llvm-project/pull/84071
___
@@ -524,6 +524,9 @@ void BreakpointLocation::GetDescription(Stream *s,
s->EOL();
s->Indent("function = ");
s->PutCString(sc.function->GetName().AsCString(""));
+ s->EOL();
+ s->Indent("mangled function = ");
+
@@ -524,6 +524,9 @@ void BreakpointLocation::GetDescription(Stream *s,
s->EOL();
s->Indent("function = ");
s->PutCString(sc.function->GetName().AsCString(""));
+ s->EOL();
+ s->Indent("mangled function = ");
+
@@ -524,6 +524,9 @@ void BreakpointLocation::GetDescription(Stream *s,
s->EOL();
s->Indent("function = ");
s->PutCString(sc.function->GetName().AsCString(""));
+ s->EOL();
+ s->Indent("mangled function = ");
+
https://github.com/jimingham edited
https://github.com/llvm/llvm-project/pull/84071
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -524,6 +524,9 @@ void BreakpointLocation::GetDescription(Stream *s,
s->EOL();
s->Indent("function = ");
s->PutCString(sc.function->GetName().AsCString(""));
+ s->EOL();
+ s->Indent("mangled function = ");
@@ -524,6 +524,9 @@ void BreakpointLocation::GetDescription(Stream *s,
s->EOL();
s->Indent("function = ");
s->PutCString(sc.function->GetName().AsCString(""));
+ s->EOL();
+ s->Indent("mangled function = ");
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/84071
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg commented:
Might be nice to print the mangled name of the symbol as well? We are doing it
for the function...
https://github.com/llvm/llvm-project/pull/84071
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
@@ -524,6 +524,9 @@ void BreakpointLocation::GetDescription(Stream *s,
s->EOL();
s->Indent("function = ");
s->PutCString(sc.function->GetName().AsCString(""));
+ s->EOL();
+ s->Indent("mangled function = ");
+
@@ -524,6 +524,9 @@ void BreakpointLocation::GetDescription(Stream *s,
s->EOL();
s->Indent("function = ");
s->PutCString(sc.function->GetName().AsCString(""));
+ s->EOL();
+ s->Indent("mangled function = ");
https://github.com/jimingham edited
https://github.com/llvm/llvm-project/pull/84071
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -90,6 +90,15 @@ def breakpoint_options_language_test(self):
num_expected_locations=1,
)
jimingham wrote:
run_break_set_by_symbol returns the break ID of the new breakpoint. You could
look it up, get its location, get the function from
@@ -524,6 +524,9 @@ void BreakpointLocation::GetDescription(Stream *s,
s->EOL();
s->Indent("function = ");
s->PutCString(sc.function->GetName().AsCString(""));
+ s->EOL();
+ s->Indent("mangled function = ");
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 05390df497535b26879a7a96e03a76af26c8bcd3
0252a23a8a63acca1a51a9f838b6ace3f3b13cc1 --
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
05390df497535b26879a7a96e03a76af26c8bcd3...0252a23a8a63acca1a51a9f838b6ace3f3b13cc1
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Felipe de Azevedo Piovezan (felipepiovezan)
Changes
When debugging LLDB itself, it can often be useful to know the mangled name of
the function where a breakpoint is set. Since the `--verbose` setting of `break
--list` is aimed at
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/84071
When debugging LLDB itself, it can often be useful to know the mangled name of
the function where a breakpoint is set. Since the `--verbose` setting of `break
--list` is aimed at debugging LLDB, this
25 matches
Mail list logo
