[Lldb-commits] [lldb] [lldb] Provide a better error message for missing symbols (PR #89433)

https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/89433 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Provide a better error message for missing symbols (PR #89433)

https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/89433 >From 162907c6527464f828756b7152e2364ae3be88b5 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Fri, 19 Apr 2024 11:08:16 -0700 Subject: [PATCH] [lldb] Provide a better error message for missing symbols

[Lldb-commits] [lldb] [lldb] Provide a better error message for missing symbols (PR #89433)

https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/89433 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Provide a better error message for missing symbols (PR #89433)

https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/89433 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Provide a better error message for missing symbols (PR #89433)

@@ -431,7 +431,9 @@ void IRExecutionUnit::GetRunnableInfo(Status , lldb::addr_t _addr, } m_failed_lookups.clear(); - +ss.PutCString( +"\nHint: The expression tried to call a function missing from the " +"target, perhaps because it was optimized

[Lldb-commits] [lldb] [lldb] Provide a better error message for missing symbols (PR #89433)

https://github.com/JDevlieghere approved this pull request. LGMT with the formatting fixed. https://github.com/llvm/llvm-project/pull/89433 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb] Provide a better error message for missing symbols (PR #89433)

https://github.com/felipepiovezan approved this pull request. This LGTM! I like the wording in the sense that it uses a slightly less "systemy" language, and so it becomes less cryptic to a wider audience. https://github.com/llvm/llvm-project/pull/89433

[Lldb-commits] [lldb] [lldb] Provide a better error message for missing symbols (PR #89433)

github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 4841d70a4b7d7cd8c492c16a9da339ec75bca135...d57f2adff84dc5148c417135aa4733e05476876c

[Lldb-commits] [lldb] [lldb] Provide a better error message for missing symbols (PR #89433)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Prantl (adrian-prantl) Changes This adds a hint to the missing symbols error message to make it easier to understand what this means to users. --- Full diff: https://github.com/llvm/llvm-project/pull/89433.diff 2 Files Affected:

[Lldb-commits] [lldb] [lldb] Provide a better error message for missing symbols (PR #89433)

https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/89433 This adds a hint to the missing symbols error message to make it easier to understand what this means to users. >From d57f2adff84dc5148c417135aa4733e05476876c Mon Sep 17 00:00:00 2001 From: Adrian Prantl