[Lldb-commits] [lldb] [lldb] Show module name in progress update for downloading symbols (PR #85342)

https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/85342 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Show module name in progress update for downloading symbols (PR #85342)

https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/85342 >From b50eb7442ab8f37659596efad19f8b30b145 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 14 Mar 2024 17:43:02 -0700 Subject: [PATCH 1/3] [lldb] Show module name in progress update for

[Lldb-commits] [lldb] [lldb] Show module name in progress update for downloading symbols (PR #85342)

@@ -1066,11 +1066,21 @@ bool SymbolLocatorDebugSymbols::DownloadObjectAndSymbolFile( command << lookup_arg; // Log and report progress. + std::string lookup_desc; + if (uuid_ptr && file_spec_ptr) +lookup_desc = +llvm::formatv("{0} ({1})",

[Lldb-commits] [lldb] [lldb] Show module name in progress update for downloading symbols (PR #85342)

https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/85342 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Show module name in progress update for downloading symbols (PR #85342)

https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/85342 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Show module name in progress update for downloading symbols (PR #85342)

https://github.com/bulbazord approved this pull request. +1 to Adrian's suggestion. LGTM since you've addressed that now https://github.com/llvm/llvm-project/pull/85342 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb] Show module name in progress update for downloading symbols (PR #85342)

https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/85342 >From b50eb7442ab8f37659596efad19f8b30b145 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 14 Mar 2024 17:43:02 -0700 Subject: [PATCH 1/2] [lldb] Show module name in progress update for

[Lldb-commits] [lldb] [lldb] Show module name in progress update for downloading symbols (PR #85342)

@@ -1066,11 +1066,21 @@ bool SymbolLocatorDebugSymbols::DownloadObjectAndSymbolFile( command << lookup_arg; // Log and report progress. + std::string lookup_desc; + if (uuid_ptr && file_spec_ptr) +lookup_desc = +llvm::formatv("{0} ({1})",

[Lldb-commits] [lldb] [lldb] Show module name in progress update for downloading symbols (PR #85342)

@@ -1066,11 +1066,21 @@ bool SymbolLocatorDebugSymbols::DownloadObjectAndSymbolFile( command << lookup_arg; // Log and report progress. + std::string lookup_desc; + if (uuid_ptr && file_spec_ptr) +lookup_desc = +llvm::formatv("{0} ({1})",

[Lldb-commits] [lldb] [lldb] Show module name in progress update for downloading symbols (PR #85342)

@@ -1066,11 +1066,21 @@ bool SymbolLocatorDebugSymbols::DownloadObjectAndSymbolFile( command << lookup_arg; // Log and report progress. + std::string lookup_desc; + if (uuid_ptr && file_spec_ptr) +lookup_desc = +llvm::formatv("{0} ({1})",

[Lldb-commits] [lldb] [lldb] Show module name in progress update for downloading symbols (PR #85342)

@@ -1066,11 +1066,21 @@ bool SymbolLocatorDebugSymbols::DownloadObjectAndSymbolFile( command << lookup_arg; // Log and report progress. + std::string lookup_desc; + if (uuid_ptr && file_spec_ptr) +lookup_desc = +llvm::formatv("{0} ({1})",

[Lldb-commits] [lldb] [lldb] Show module name in progress update for downloading symbols (PR #85342)

https://github.com/adrian-prantl requested changes to this pull request. https://github.com/llvm/llvm-project/pull/85342 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Show module name in progress update for downloading symbols (PR #85342)

https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/85342 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Show module name in progress update for downloading symbols (PR #85342)

medismailben wrote: LGTM! https://github.com/llvm/llvm-project/pull/85342 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Show module name in progress update for downloading symbols (PR #85342)

https://github.com/chelcassanova approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/85342 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Show module name in progress update for downloading symbols (PR #85342)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Currently, we always show the argument passed to dsymForUUID in the corresponding progress update. Most of the time this is a UUID, but it can also be an absolute path. The former is pretty

[Lldb-commits] [lldb] [lldb] Show module name in progress update for downloading symbols (PR #85342)

https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/85342 Currently, we always show the argument passed to dsymForUUID in the corresponding progress update. Most of the time this is a UUID, but it can also be an absolute path. The former is pretty uninformative