https://github.com/ZequanWu closed
https://github.com/llvm/llvm-project/pull/81680
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -2757,13 +2769,18 @@ void request_dataBreakpointInfo(const
llvm::json::Object ) {
body.try_emplace("description", error_cstr && error_cstr[0]
? std::string(error_cstr)
: "evaluation
https://github.com/ZequanWu edited
https://github.com/llvm/llvm-project/pull/81680
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ZequanWu commented:
In terms of interpreting `name` as `${number of bytes}@${expression}`, it's
made-up. And I just noticed that someone already filed an issue about this:
https://github.com/microsoft/debug-adapter-protocol/issues/455. Should we
revert the change inside the
https://github.com/ZequanWu updated
https://github.com/llvm/llvm-project/pull/81680
>From f9c509c519c9937d2e2de5098c4241e936187527 Mon Sep 17 00:00:00 2001
From: Zequan Wu
Date: Tue, 13 Feb 2024 17:41:26 -0500
Subject: [PATCH 1/2] [lldb-dap] Followup fixs for data breakpoints
---
@@ -2757,13 +2769,18 @@ void request_dataBreakpointInfo(const
llvm::json::Object ) {
body.try_emplace("description", error_cstr && error_cstr[0]
? std::string(error_cstr)
: "evaluation
@@ -2757,13 +2769,18 @@ void request_dataBreakpointInfo(const
llvm::json::Object ) {
body.try_emplace("description", error_cstr && error_cstr[0]
? std::string(error_cstr)
: "evaluation
@@ -2757,13 +2769,18 @@ void request_dataBreakpointInfo(const
llvm::json::Object ) {
body.try_emplace("description", error_cstr && error_cstr[0]
? std::string(error_cstr)
: "evaluation
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Zequan Wu (ZequanWu)
Changes
Followup fixes to resolve comments in
https://github.com/llvm/llvm-project/pull/81541
---
Full diff: https://github.com/llvm/llvm-project/pull/81680.diff
1 Files Affected:
- (modified)
https://github.com/ZequanWu created
https://github.com/llvm/llvm-project/pull/81680
Followup fixes to resolve comments in
https://github.com/llvm/llvm-project/pull/81541
>From f9c509c519c9937d2e2de5098c4241e936187527 Mon Sep 17 00:00:00 2001
From: Zequan Wu
Date: Tue, 13 Feb 2024 17:41:26
10 matches
Mail list logo
