Author: Muhammad Omair Javaid Date: 2022-06-29T12:47:02+04:00 New Revision: 695c22c84a36daf0ed12b212c2ac9772f45c61f3
URL: https://github.com/llvm/llvm-project/commit/695c22c84a36daf0ed12b212c2ac9772f45c61f3 DIFF: https://github.com/llvm/llvm-project/commit/695c22c84a36daf0ed12b212c2ac9772f45c61f3.diff LOG: [LLDB] Fix PDB/pointers.test for 32bit Arm/Windows PDB/pointers.test was orignally written for 32bit x86 keeping in mind __cdecl and __stdcall calling conventions which does name mangling for example like adding "_" underscore before function name. This is only x86 specific but purpose of pointers.test is NOT to test calling convention. I am have made a few minor changes to this test which will make it pass when run on Windows/Arm platform. Reviewed By: mstorsjo Differential Revision: https://reviews.llvm.org/D128668 Added: Modified: lldb/test/Shell/SymbolFile/PDB/pointers.test Removed: ################################################################################ diff --git a/lldb/test/Shell/SymbolFile/PDB/pointers.test b/lldb/test/Shell/SymbolFile/PDB/pointers.test index a8f84f14783de..841fe8804b44c 100644 --- a/lldb/test/Shell/SymbolFile/PDB/pointers.test +++ b/lldb/test/Shell/SymbolFile/PDB/pointers.test @@ -19,7 +19,7 @@ MAIN-ST-NEXT: int a; MAIN-ST-NEXT: int {{.*}}f(int); MAIN-ST-NEXT:} -MAIN: Function{[[FID1:.*]]}, mangled = _main +MAIN: Function{[[FID1:.*]]}, mangled = {{_?}}main MAIN-NEXT: Block{[[FID1]]} MAIN: Variable{{.*}}, name = "array_pointer" MAIN-SAME: (int (*)[2][4]), scope = local @@ -28,11 +28,11 @@ MAIN-SAME: (int *), scope = local MAIN: Variable{{.*}}, name = "p_member_field" MAIN-SAME: (int ST::*), scope = local MAIN: Variable{{.*}}, name = "p_member_method" -MAIN-SAME: (int (ST::*)(int) __attribute__((thiscall))), scope = local +MAIN-SAME: (int (ST::*)(int){{( __attribute__\(\(thiscall\)\))?}}), scope = local F: Function{[[FID2:.*]]}, demangled = {{.*}}f(int) F-NEXT: Block{[[FID2]]} F: Variable{{.*}}, name = "this" -F-SAME: (ST *), scope = parameter, location = {{.*}}, artificial +F-SAME: (ST *), scope = parameter,{{( location = DW_OP.*,)?}} artificial F: Variable{{.*}}, name = "x" F-SAME: (int), scope = parameter, decl = PointerTypeTest.cpp:8 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits