Author: Muhammad Omair Javaid Date: 2023-05-03T04:45:55+05:00 New Revision: 6ea1a0d4fc3823de143a288df2059b48dc01cf72
URL: https://github.com/llvm/llvm-project/commit/6ea1a0d4fc3823de143a288df2059b48dc01cf72 DIFF: https://github.com/llvm/llvm-project/commit/6ea1a0d4fc3823de143a288df2059b48dc01cf72.diff LOG: [LLDB] Add/Remove xfail for some API tests on Windows This patch add or removes XFAIL decorator from various tests which were marked xfail for windows. since 44363f2 various tests have started passing but introduced a couple of new failures. Weight is in favor of new XPasses and I have removed XFail decorator from them. Also some new tests have started failing for which we need to file separate bugs. I have marked them xfail for now and will add the bug id after investigating the issue. Differential Revision: https://reviews.llvm.org/D149235 Added: Modified: lldb/test/API/commands/expression/deleting-implicit-copy-constructor/TestDeletingImplicitCopyConstructor.py lldb/test/API/commands/expression/save_jit_objects/TestSaveJITObjects.py lldb/test/API/functionalities/breakpoint/scripted_bkpt/TestScriptedResolver.py lldb/test/API/functionalities/data-formatter/data-formatter-categories/TestDataFormatterCategories.py lldb/test/API/functionalities/inline-stepping/TestInlineStepping.py lldb/test/API/functionalities/step-avoids-no-debug/TestStepNoDebug.py lldb/test/API/lang/c/step-target/TestStepTarget.py lldb/test/API/lang/cpp/constructors/TestCppConstructors.py lldb/test/API/lang/cpp/global_variables/TestCPPGlobalVariables.py lldb/test/API/lang/cpp/namespace/TestNamespace.py lldb/test/API/lang/cpp/static_members/TestCPPStaticMembers.py lldb/test/API/lang/cpp/this_class_type_mixing/TestThisClassTypeMixing.py lldb/test/API/python_api/function_symbol/TestDisasmAPI.py lldb/test/API/python_api/function_symbol/TestSymbolAPI.py lldb/test/API/python_api/symbol-context/TestSymbolContext.py lldb/test/API/python_api/target/TestTargetAPI.py lldb/test/API/python_api/value/TestValueAPI.py Removed: ################################################################################ diff --git a/lldb/test/API/commands/expression/deleting-implicit-copy-constructor/TestDeletingImplicitCopyConstructor.py b/lldb/test/API/commands/expression/deleting-implicit-copy-constructor/TestDeletingImplicitCopyConstructor.py index e14f160f1e576..2ee90181d9327 100644 --- a/lldb/test/API/commands/expression/deleting-implicit-copy-constructor/TestDeletingImplicitCopyConstructor.py +++ b/lldb/test/API/commands/expression/deleting-implicit-copy-constructor/TestDeletingImplicitCopyConstructor.py @@ -2,4 +2,4 @@ from lldbsuite.test import decorators lldbinline.MakeInlineTest(__file__, globals(), - [decorators.expectedFailureAll(bugnumber="llvm.org/pr50814", compiler="gcc")]) + [decorators.expectedFailureAll(bugnumber="llvm.org/pr50814", compiler="gcc"), decorators.expectedFailureAll(oslist=["windows"])]) diff --git a/lldb/test/API/commands/expression/save_jit_objects/TestSaveJITObjects.py b/lldb/test/API/commands/expression/save_jit_objects/TestSaveJITObjects.py index 157bed4880a3d..e3e20ad94707d 100644 --- a/lldb/test/API/commands/expression/save_jit_objects/TestSaveJITObjects.py +++ b/lldb/test/API/commands/expression/save_jit_objects/TestSaveJITObjects.py @@ -22,7 +22,6 @@ def cleanJITFiles(self): os.remove(j) return - @expectedFailureAll(oslist=["windows"]) def test_save_jit_objects(self): self.build() os.chdir(self.getBuildDir()) diff --git a/lldb/test/API/functionalities/breakpoint/scripted_bkpt/TestScriptedResolver.py b/lldb/test/API/functionalities/breakpoint/scripted_bkpt/TestScriptedResolver.py index 8a143bdf3817a..edac8b1981fdf 100644 --- a/lldb/test/API/functionalities/breakpoint/scripted_bkpt/TestScriptedResolver.py +++ b/lldb/test/API/functionalities/breakpoint/scripted_bkpt/TestScriptedResolver.py @@ -13,20 +13,17 @@ class TestScriptedResolver(TestBase): NO_DEBUG_INFO_TESTCASE = True - @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24528") def test_scripted_resolver(self): """Use a scripted resolver to set a by symbol name breakpoint""" self.build() self.do_test() - @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24528") def test_search_depths(self): """ Make sure we are called at the right depths depending on what we return from __get_depth__""" self.build() self.do_test_depths() - @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24528") def test_command_line(self): """ Test setting a resolver breakpoint from the command line """ self.build() diff --git a/lldb/test/API/functionalities/data-formatter/data-formatter-categories/TestDataFormatterCategories.py b/lldb/test/API/functionalities/data-formatter/data-formatter-categories/TestDataFormatterCategories.py index 08375c699a5b0..9025de207e6dc 100644 --- a/lldb/test/API/functionalities/data-formatter/data-formatter-categories/TestDataFormatterCategories.py +++ b/lldb/test/API/functionalities/data-formatter/data-formatter-categories/TestDataFormatterCategories.py @@ -17,6 +17,7 @@ def setUp(self): self.line = line_number('main.cpp', '// Set break point at this line.') @expectedFlakeyNetBSD + @expectedFailureAll(oslist=["windows"]) def test_with_run_command(self): """Test that that file and class static variables display correctly.""" self.build() diff --git a/lldb/test/API/functionalities/inline-stepping/TestInlineStepping.py b/lldb/test/API/functionalities/inline-stepping/TestInlineStepping.py index 7c5ae442cc5b9..62ff7a5047d2d 100644 --- a/lldb/test/API/functionalities/inline-stepping/TestInlineStepping.py +++ b/lldb/test/API/functionalities/inline-stepping/TestInlineStepping.py @@ -27,7 +27,6 @@ def test_step_over_with_python_api(self): self.inline_stepping_step_over() @add_test_categories(['pyapi']) - @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr32343") def test_step_in_template_with_python_api(self): """Test stepping in to templated functions.""" self.build() diff --git a/lldb/test/API/functionalities/step-avoids-no-debug/TestStepNoDebug.py b/lldb/test/API/functionalities/step-avoids-no-debug/TestStepNoDebug.py index 17ac2e067e299..fbaf0dd7ad108 100644 --- a/lldb/test/API/functionalities/step-avoids-no-debug/TestStepNoDebug.py +++ b/lldb/test/API/functionalities/step-avoids-no-debug/TestStepNoDebug.py @@ -14,7 +14,6 @@ class StepAvoidsNoDebugTestCase(TestBase): @add_test_categories(['pyapi']) - @expectedFailureAll(archs=["aarch64"], oslist=["windows"], bugnumber="llvm.org/pr56292") def test_step_out_with_python(self): """Test stepping out using avoid-no-debug with dsyms.""" self.build() @@ -32,7 +31,6 @@ def test_step_out_with_python(self): archs=["i386"], oslist=no_match(["freebsd"]), bugnumber="llvm.org/pr28549") - @expectedFailureAll(archs=["aarch64"], oslist=["windows"], bugnumber="llvm.org/pr56292") def test_step_over_with_python(self): """Test stepping over using avoid-no-debug with dwarf.""" self.build() @@ -50,7 +48,6 @@ def test_step_over_with_python(self): archs=["i386"], oslist=no_match(["freebsd"]), bugnumber="llvm.org/pr28549") - @expectedFailureAll(archs=["aarch64"], oslist=["windows"], bugnumber="llvm.org/pr56292") def test_step_in_with_python(self): """Test stepping in using avoid-no-debug with dwarf.""" self.build() diff --git a/lldb/test/API/lang/c/step-target/TestStepTarget.py b/lldb/test/API/lang/c/step-target/TestStepTarget.py index 3521870ddbdca..98f2ac0989d1a 100644 --- a/lldb/test/API/lang/c/step-target/TestStepTarget.py +++ b/lldb/test/API/lang/c/step-target/TestStepTarget.py @@ -47,7 +47,6 @@ def get_to_start(self): thread = threads[0] return thread - @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr32343") def test_with_end_line(self): """Test stepping over vrs. hitting breakpoints & subsequent stepping in various forms.""" @@ -59,7 +58,6 @@ def test_with_end_line(self): self.assertEqual(frame.name, "lotsOfArgs", "Stepped to lotsOfArgs.") - @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr32343") def test_with_end_line_bad_name(self): """Test stepping over vrs. hitting breakpoints & subsequent stepping in various forms.""" @@ -81,7 +79,6 @@ def test_with_end_line_deeper(self): frame = thread.frames[0] self.assertEqual(frame.name, "modifyInt", "Stepped to modifyInt.") - @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr32343") def test_with_command_and_block(self): """Test stepping over vrs. hitting breakpoints & subsequent stepping in various forms.""" @@ -97,7 +94,6 @@ def test_with_command_and_block(self): frame = thread.frames[0] self.assertEqual(frame.name, "lotsOfArgs", "Stepped to lotsOfArgs.") - @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr32343") def test_with_command_and_block_and_bad_name(self): """Test stepping over vrs. hitting breakpoints & subsequent stepping in various forms.""" diff --git a/lldb/test/API/lang/cpp/constructors/TestCppConstructors.py b/lldb/test/API/lang/cpp/constructors/TestCppConstructors.py index d726108ab7411..9815705b330b4 100644 --- a/lldb/test/API/lang/cpp/constructors/TestCppConstructors.py +++ b/lldb/test/API/lang/cpp/constructors/TestCppConstructors.py @@ -6,6 +6,7 @@ class TestCase(TestBase): @expectedFailureAll(bugnumber="llvm.org/pr50814", compiler="gcc") + @expectedFailureAll(oslist=["windows"]) def test_constructors(self): self.build() lldbutil.run_to_source_breakpoint(self,"// break here", lldb.SBFileSpec("main.cpp")) diff --git a/lldb/test/API/lang/cpp/global_variables/TestCPPGlobalVariables.py b/lldb/test/API/lang/cpp/global_variables/TestCPPGlobalVariables.py index 28e53a0da2842..6df030086d38b 100644 --- a/lldb/test/API/lang/cpp/global_variables/TestCPPGlobalVariables.py +++ b/lldb/test/API/lang/cpp/global_variables/TestCPPGlobalVariables.py @@ -44,7 +44,6 @@ def test(self): self.assertEqual(var.GetName(), "abc::(anonymous namespace)::g_anon_namespace_const_int") self.assertEqual(var.GetValue(), "100") - @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24764") def test_access_by_mangled_name(self): self.build() diff --git a/lldb/test/API/lang/cpp/namespace/TestNamespace.py b/lldb/test/API/lang/cpp/namespace/TestNamespace.py index ad534cd58ac08..9914ee347bbc6 100644 --- a/lldb/test/API/lang/cpp/namespace/TestNamespace.py +++ b/lldb/test/API/lang/cpp/namespace/TestNamespace.py @@ -43,6 +43,7 @@ def test_breakpoints_func_auto(self): "make sure breakpoint locations are correct for 'func' with eFunctionNameTypeAuto") @expectedFailureAll(bugnumber="llvm.org/pr28548", compiler="gcc") + @expectedFailureAll(oslist=["windows"]) def test_breakpoints_func_full(self): """Test that we can set breakpoints correctly by fullname to find all functions whose fully qualified name is "func" (no namespaces).""" diff --git a/lldb/test/API/lang/cpp/static_members/TestCPPStaticMembers.py b/lldb/test/API/lang/cpp/static_members/TestCPPStaticMembers.py index ce5f76e5fe744..98f44ba4b992f 100644 --- a/lldb/test/API/lang/cpp/static_members/TestCPPStaticMembers.py +++ b/lldb/test/API/lang/cpp/static_members/TestCPPStaticMembers.py @@ -39,8 +39,6 @@ def test_access_without_scope(self): self.expect("expression s_c", error=True, startstr="error: use of undeclared identifier 's_d'") - # We fail to lookup static members on Windows. - @expectedFailureAll(oslist=["windows"]) def test_no_crash_in_IR_arithmetic(self): """ Test that LLDB doesn't crash on evaluating specific expression involving diff --git a/lldb/test/API/lang/cpp/this_class_type_mixing/TestThisClassTypeMixing.py b/lldb/test/API/lang/cpp/this_class_type_mixing/TestThisClassTypeMixing.py index 29c3c5d9fdd17..15ce278a5eea6 100644 --- a/lldb/test/API/lang/cpp/this_class_type_mixing/TestThisClassTypeMixing.py +++ b/lldb/test/API/lang/cpp/this_class_type_mixing/TestThisClassTypeMixing.py @@ -16,6 +16,7 @@ class by injecting a "$__lldb_expr" member function into the class. This class TestCase(TestBase): @no_debug_info_test + @expectedFailureAll(oslist=["windows"]) def test(self): self.build() lldbutil.run_to_source_breakpoint(self, "// break in member function", diff --git a/lldb/test/API/python_api/function_symbol/TestDisasmAPI.py b/lldb/test/API/python_api/function_symbol/TestDisasmAPI.py index dbdbe751ec745..1f1e4b1867c1e 100644 --- a/lldb/test/API/python_api/function_symbol/TestDisasmAPI.py +++ b/lldb/test/API/python_api/function_symbol/TestDisasmAPI.py @@ -19,7 +19,6 @@ def setUp(self): self.line2 = line_number( 'main.c', '// Find the line number for breakpoint 2 here.') - @expectedFailureAll(oslist=["windows"], bugnumber='llvm.org/pr21765') def test(self): """Exercise getting SBAddress objects, disassembly, and SBAddress APIs.""" self.build() diff --git a/lldb/test/API/python_api/function_symbol/TestSymbolAPI.py b/lldb/test/API/python_api/function_symbol/TestSymbolAPI.py index 14cc3ebe870f4..2517f9b8e2960 100644 --- a/lldb/test/API/python_api/function_symbol/TestSymbolAPI.py +++ b/lldb/test/API/python_api/function_symbol/TestSymbolAPI.py @@ -19,7 +19,6 @@ def setUp(self): self.line2 = line_number( 'main.c', '// Find the line number for breakpoint 2 here.') - @expectedFailureAll(oslist=["windows"], bugnumber='llvm.org/pr21765') def test(self): """Exercise some SBSymbol and SBAddress APIs.""" self.build() diff --git a/lldb/test/API/python_api/symbol-context/TestSymbolContext.py b/lldb/test/API/python_api/symbol-context/TestSymbolContext.py index 8094845936f89..3521bc36b142a 100644 --- a/lldb/test/API/python_api/symbol-context/TestSymbolContext.py +++ b/lldb/test/API/python_api/symbol-context/TestSymbolContext.py @@ -17,7 +17,6 @@ def setUp(self): self.line = line_number( 'main.c', '// Find the line number of function "c" here.') - @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24778") def test(self): """Exercise SBSymbolContext API extensively.""" self.build() diff --git a/lldb/test/API/python_api/target/TestTargetAPI.py b/lldb/test/API/python_api/target/TestTargetAPI.py index 15ac04cfa74c4..501a7cdbb1813 100644 --- a/lldb/test/API/python_api/target/TestTargetAPI.py +++ b/lldb/test/API/python_api/target/TestTargetAPI.py @@ -42,7 +42,6 @@ def test_find_compile_units(self): self.setTearDownCleanup(dictionary=d) self.find_compile_units(self.getBuildArtifact('b.out')) - @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24778") def test_find_functions(self): """Exercise SBTarget.FindFunctions() API.""" d = {'EXE': 'b.out'} @@ -55,7 +54,6 @@ def test_get_description(self): self.build() self.get_description() - @expectedFailureAll(oslist=["windows"], bugnumber='llvm.org/pr21765') def test_resolve_symbol_context_with_address(self): """Exercise SBTarget.ResolveSymbolContextForAddress() API.""" self.build() diff --git a/lldb/test/API/python_api/value/TestValueAPI.py b/lldb/test/API/python_api/value/TestValueAPI.py index 85d8b494e3d3d..00d171f2bebb1 100644 --- a/lldb/test/API/python_api/value/TestValueAPI.py +++ b/lldb/test/API/python_api/value/TestValueAPI.py @@ -18,7 +18,6 @@ def setUp(self): # Find the line number to of function 'c'. self.line = line_number('main.c', '// Break at this line') - @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24772") def test(self): """Exercise some SBValue APIs.""" d = {'EXE': self.exe_name} _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
