Author: David Spickett Date: 2020-08-26T11:52:30+01:00 New Revision: 9ad5d37fd917a5b8b3ffe5c12145c85021ee2578
URL: https://github.com/llvm/llvm-project/commit/9ad5d37fd917a5b8b3ffe5c12145c85021ee2578 DIFF: https://github.com/llvm/llvm-project/commit/9ad5d37fd917a5b8b3ffe5c12145c85021ee2578.diff LOG: [lldb] Correct wording of EXP_MSG EXP_MSG generates a message to show on assert failure. Currently it looks like: AssertionError: False is not True : '<cmd>' returns expected result, got '<actual output>' Which seems to say that the test failed but also got the expected result. It should say: AssertionError: False is not True : '<cmd>' returned unexpected result, got '<actual output>' Reviewed By: teemperor, #lldb Differential Revision: https://reviews.llvm.org/D86603 Added: Modified: lldb/packages/Python/lldbsuite/test/lldbtest.py Removed: ################################################################################ diff --git a/lldb/packages/Python/lldbsuite/test/lldbtest.py b/lldb/packages/Python/lldbsuite/test/lldbtest.py index de9a9a2c7002..4180ba271613 100644 --- a/lldb/packages/Python/lldbsuite/test/lldbtest.py +++ b/lldb/packages/Python/lldbsuite/test/lldbtest.py @@ -190,11 +190,11 @@ def COMPLETION_MSG(str_before, str_after, completions): def EXP_MSG(str, actual, exe): - '''A generic "'%s' returns expected result" message generator if exe. - Otherwise, it generates "'%s' matches expected result" message.''' + '''A generic "'%s' returned unexpected result" message generator if exe. + Otherwise, it generates "'%s' does not match expected result" message.''' - return "'%s' %s expected result, got '%s'" % ( - str, 'returns' if exe else 'matches', actual.strip()) + return "'%s' %s result, got '%s'" % ( + str, 'returned unexpected' if exe else 'does not match expected', actual.strip()) def SETTING_MSG(setting): _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
