JDevlieghere wrote:
https://github.com/llvm/llvm-project/pull/90753
https://github.com/llvm/llvm-project/pull/89981
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
> Thanks for the explanation! What kind of tool reads this file?
One such tool is SWIG, which happens to support macro expansion, but we have
other tools downstream that don't.
> It's still weird to use tblgen to process non-td files imho. We have a bunch
> of places
bulbazord wrote:
This doesn't actually copy `SBLanguages.h` into the framework, so this breaks
the framework.
These tests now fail:
```
Unresolved Tests (5):
lldb-api :: api/check_public_api_headers/TestPublicAPIHeaders.py
lldb-api ::
nico wrote:
Thanks for the explanation! What kind of tool reads this file?
It's still weird to use tblgen to process non-td files imho. We have a bunch of
places that run python scripts as part of the build
(clang/utils/bundle_resources.py,
adrian-prantl wrote:
Btw. github doesn't let you see older revisions, but the code snippet you
posted that includes a .def file was exactly my first version of this patch.
You can still find @JDevlieghere's comment asking me to change it though :-)
Another thing worth noting is that the
adrian-prantl wrote:
That's also why it's a `.h` file and not a `.inc`.
https://github.com/llvm/llvm-project/pull/89981
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
> Why does this use tablegen to parse a .def file?
>
> Can't you get the same behavior without tablegen, using normal xmacro
> techniques, something like
>
> ```c++
> enum SBSourceLanguageName : uint16_t {
>
> #define HANDLE_DW_LNAME(ID, NAME, DESC, LOWER_BOUND) \
>
nico wrote:
I left another comment on the commit that doesn't show up here
(https://github.com/llvm/llvm-project/commit/975eca0e6a3459e59e96b0df33ea0cfbd157c597).
If you do want to keep the generated file: All other tablegen invocations use
".inc" for tablegen output. Maybe this could match
nico wrote:
Why does this use tablegen to parse a .def file?
Can't you get the same behavior without tablegen, using normal xmacro
techniques, something like
```c++
enum SBSourceLanguageName : uint16_t {
#define HANDLE_DW_LNAME(ID, NAME, DESC, LOWER_BOUND) \
eLanguageName ## NAME = ID,
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/89981
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/89981
>From 34eda7b484e3fa9eaaf97c66af3e81bf337e6edd Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 24 Apr 2024 12:50:43 -0700
Subject: [PATCH] Add a new SBExpressionOptions::SetLanguage() API (NFCI)
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/89981
>From c4b1ff6c92126ebf721b6044088b05112ec98477 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 24 Apr 2024 12:50:43 -0700
Subject: [PATCH] Add a new SBExpressionOptions::SetLanguage() API (NFCI)
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/89981
>From 00fdda9a57660533c5a97223bd52619b36f8999c Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 24 Apr 2024 12:50:43 -0700
Subject: [PATCH] Add a new SBExpressionOptions::SetLanguage() API (NFCI)
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/89981
>From ea06aa4664b9b47b3cb11ec27774b9a0d109f92f Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 24 Apr 2024 12:50:43 -0700
Subject: [PATCH] Add a new SBExpressionOptions::SetLanguage() API (NFCI)
https://github.com/JDevlieghere approved this pull request.
Thanks for bearing with me! LGTM.
https://github.com/llvm/llvm-project/pull/89981
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/89981
>From 6d91ad848b73183268617fecf14255b0ba0b9dd8 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 24 Apr 2024 12:50:43 -0700
Subject: [PATCH] Add a new SBExpressionOptions::SetLanguage() API (NFCI)
@@ -10,6 +10,7 @@ config.llvm_build_mode =
lit_config.substitute("@LLVM_BUILD_MODE@")
config.lit_tools_dir = "@LLVM_LIT_TOOLS_DIR@"
config.lldb_obj_root = "@LLDB_BINARY_DIR@"
config.lldb_src_root = "@LLDB_SOURCE_DIR@"
+config.lldb_built_include_dir =
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/89981
>From 19cfcf3230d02a93a907fe93ca95dbecd48bcaf9 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 24 Apr 2024 12:50:43 -0700
Subject: [PATCH] Add a new SBExpressionOptions::SetLanguage() API (NFCI)
@@ -239,6 +239,9 @@ def delete_module_cache(path):
if is_configured("server"):
dotest_cmd += ["--server", config.server]
+if is_configured("lldb_built_include_dir"):
+dotest_cmd += ["--lldb-built-include-dir", config.lldb_built_include_dir]
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/89981
>From e9b2e98cfe0383b53d2d875f070a63c2ccffe3d3 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 24 Apr 2024 12:50:43 -0700
Subject: [PATCH] Add a new SBExpressionOptions::SetLanguage() API (NFCI)
@@ -0,0 +1,45 @@
+//===- LLDBPropertyDefEmitter.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/89981
>From e561968f8290b0fbe679950e5743f1f60144d716 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 24 Apr 2024 12:50:43 -0700
Subject: [PATCH] Add a new SBExpressionOptions::SetLanguage() API (NFCI)
@@ -0,0 +1,45 @@
+//===- LLDBPropertyDefEmitter.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -10,6 +10,7 @@ config.llvm_build_mode =
lit_config.substitute("@LLVM_BUILD_MODE@")
config.lit_tools_dir = "@LLVM_LIT_TOOLS_DIR@"
config.lldb_obj_root = "@LLDB_BINARY_DIR@"
config.lldb_src_root = "@LLDB_SOURCE_DIR@"
+config.lldb_built_include_dir =
@@ -0,0 +1,45 @@
+//===- LLDBPropertyDefEmitter.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -67,6 +67,10 @@ class LLDB_API SBExpressionOptions {
void SetTrapExceptions(bool trap_exceptions = true);
void SetLanguage(lldb::LanguageType language);
+ /// Set the language using a pair of language code and version as
+ /// defined by the DWARF 6 specification.
+
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/89981
>From 280caa3e26227338071409213646625d05f6eba5 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 24 Apr 2024 12:50:43 -0700
Subject: [PATCH] Add a new SBExpressionOptions::SetLanguage() API (NFCI)
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/89981
>From 762029753f7c21352f653e1719cb6c75107f6a50 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 24 Apr 2024 12:50:43 -0700
Subject: [PATCH] Add a new SBExpressionOptions::SetLanguage() API (NFCI)
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
300340f656d762afa8bde5fc398757d2951560bf...aba61b23b402f350161139adfffc3799a3135c8a
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/89981
>From aba61b23b402f350161139adfffc3799a3135c8a Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 24 Apr 2024 12:50:43 -0700
Subject: [PATCH] Add a new SBExpressionOptions::SetLanguage() API (NFCI)
@@ -67,6 +67,10 @@ class LLDB_API SBExpressionOptions {
void SetTrapExceptions(bool trap_exceptions = true);
void SetLanguage(lldb::LanguageType language);
+ /// Set the language using a pair of language code and version as
+ /// defined by the DWARF 6 specification.
+
@@ -1203,26 +1203,23 @@ bool StackFrame::IsArtificial() const {
return m_stack_frame_kind == StackFrame::Kind::Artificial;
}
-lldb::LanguageType StackFrame::GetLanguage() {
+SourceLanguage StackFrame::GetLanguage() {
CompileUnit *cu =
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/89981
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/89981
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1203,26 +1203,23 @@ bool StackFrame::IsArtificial() const {
return m_stack_frame_kind == StackFrame::Kind::Artificial;
}
-lldb::LanguageType StackFrame::GetLanguage() {
+SourceLanguage StackFrame::GetLanguage() {
CompileUnit *cu =
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/89981
>From 5bd7d3da1cd1c9ec508e0fbd96c8d9f2509ee900 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 24 Apr 2024 12:50:43 -0700
Subject: [PATCH] Add a new SBExpressionOptions::SetLanguage() API (NFCI)
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 9e9595183001991a7d31d8880c4a2b33594ca30f
7e63653359ee0cfe251091017a4265aaea3770e3 --
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Adrian Prantl (adrian-prantl)
Changes
that separates out language and version. To avoid reinventing the wheel and
introducing subtle incompatibilities, this API uses the table of languages and
versiond defined by the upcoming DWARF 6
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/89981
that separates out language and version. To avoid reinventing the wheel and
introducing subtle incompatibilities, this API uses the table of languages and
versiond defined by the upcoming DWARF 6 standard
39 matches
Mail list logo
