adrian-prantl wrote:
Or rather, I didn't build with all LLVM targets.
https://github.com/llvm/llvm-project/pull/84219
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
Apologies, I made a last-minute rebase without rebuilding. Thanks for reverting!
https://github.com/llvm/llvm-project/pull/84219
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
fmayer wrote:
I think this broke the build completely?
```
/usr/local/google/home/fmayer/large/llvm-project/lldb/source/Plugins/ABI/PowerPC/ABISysV_ppc64.cpp:771:14:
error: no viable conversion from 'llvm::Expected' (aka
'Expected') to 'uint32_t' (aka 'unsigned int')
uint32_t n =
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/84219
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/84219
>From 0504cd6b50df6fafe36bade310fe1b729a3d9cea Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Thu, 7 Mar 2024 13:03:14 -0800
Subject: [PATCH] Change GetNumChildren()/CalculateNumChildren() to return
https://github.com/jimingham approved this pull request.
LGTM. The "IgnoringErrors" makes this construct easier to spot, and also
should give anyone a bad feeling if they are tempted to use it...
https://github.com/llvm/llvm-project/pull/84219
___
adrian-prantl wrote:
@walter-erquinigo @jimingham I updated the patch to implement Jim's suggestion
of adding an explicit `GetNumChilrdrenIgnoringErrors()` API that also ticks off
the "big red warning flag" @JDevlieghere was pushing for.
https://github.com/llvm/llvm-project/pull/84219
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/84219
>From 97a80ffa93d9fd648f0aa995b51981f0ad949530 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Thu, 7 Mar 2024 13:03:14 -0800
Subject: [PATCH] Let GetNumChildren()/CalculateNumChildren() return
jimingham wrote:
> > I would say this differently. Many clients of the GetNumChildren API are
> > planning to respond the same way to an error and a number of children == 0.
>
> I haven't done a complete audit, but my expectation for this patch is that
> the vast majority of users of this
adrian-prantl wrote:
> I would say this differently. Many clients of the GetNumChildren API are
> planning to respond the same way to an error and a number of children == 0.
I haven't done a complete audit, but my expectation for this patch is that the
vast majority of users of this API will
jimingham wrote:
I would say this differently. Many clients of the GetNumChildren API are
planning to respond the same way to an error and a number of children == 0.
Having to embed this "i'm not actually checking the error, I'm just converting
it to num-children = 0" snippet looks odd,
https://github.com/JDevlieghere requested changes to this pull request.
I'm worried about making it too easy to ignore errors. The whole point of the
llvm::Error class is that you have to check it. There might be a legitimate
reason you don't about the error the call site, but it should very
@@ -451,8 +451,13 @@ bool FormatManager::ShouldPrintAsOneLiner(ValueObject
) {
if (valobj.GetSummaryFormat().get() != nullptr)
return valobj.GetSummaryFormat()->IsOneLiner();
+ auto num_children = valobj.GetNumChildren();
+ if (!num_children) {
+
adrian-prantl wrote:
@walter-erquinigo I was wondering if it would make sense to create a
DropAndLogError() wrapper for all these places. The main problem would be that
we end up calling these functions dozens of times over and over so we'd be
spamming the logs quite a bit. But maybe doing a
@@ -1397,7 +1398,9 @@ ValueObjectSP GetValueForOffset(StackFrame ,
ValueObjectSP ,
return parent;
}
- for (int ci = 0, ce = parent->GetNumChildren(); ci != ce; ++ci) {
+ for (int ci = 0, ce = llvm::expectedToStdOptional(parent->GetNumChildren())
@@ -451,8 +451,13 @@ bool FormatManager::ShouldPrintAsOneLiner(ValueObject
) {
if (valobj.GetSummaryFormat().get() != nullptr)
return valobj.GetSummaryFormat()->IsOneLiner();
+ auto num_children = valobj.GetNumChildren();
+ if (!num_children) {
+
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 21be2fbd17f9ff6f3f04e0ababc91c9cdd5aed85
d3112e0cd5932e1e1413ed22f71adec70bc81bbf --
https://github.com/adrian-prantl edited
https://github.com/llvm/llvm-project/pull/84219
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl edited
https://github.com/llvm/llvm-project/pull/84219
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
19 matches
Mail list logo
