[Lldb-commits] [lldb] Fix lldb-dap pickProcess command for selecting process for debugger attachment (PR #75342)

2024-01-10 Thread Walter Erquinigo via lldb-commits
walter-erquinigo wrote: @Dodzey, the typescript extension has been merged and, if you want, you can implement an integrated process picker for lldb-dap. https://github.com/llvm/llvm-project/pull/75342 ___ lldb-commits mailing list

[Lldb-commits] [lldb] Fix lldb-dap pickProcess command for selecting process for debugger attachment (PR #75342)

2023-12-14 Thread Walter Erquinigo via lldb-commits
walter-erquinigo wrote: Here it is https://github.com/llvm/llvm-project/pull/75515! https://github.com/llvm/llvm-project/pull/75342 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix lldb-dap pickProcess command for selecting process for debugger attachment (PR #75342)

2023-12-13 Thread Walter Erquinigo via lldb-commits
walter-erquinigo wrote: @Dodzey , I think I'll add the minimal TS project tonight and you can review it. Then we can add a few additional features there are as follow ups https://github.com/llvm/llvm-project/pull/75342 ___ lldb-commits mailing list

[Lldb-commits] [lldb] Fix lldb-dap pickProcess command for selecting process for debugger attachment (PR #75342)

2023-12-13 Thread Walter Erquinigo via lldb-commits
walter-erquinigo wrote: > Would you want the minimal typescript extension to be a separate extension > from the main lldb-dap one?, or would it be okay to have the typescript in > the lldb-dap project/extension? It should be part of the lldb-dap folder/project and it should also be the

[Lldb-commits] [lldb] Fix lldb-dap pickProcess command for selecting process for debugger attachment (PR #75342)

2023-12-13 Thread via lldb-commits
Dodzey wrote: I've just checked one possible failure mode that came to mind. Do you get an error if you didn't have the MS CPPTools extension enabled and you attempt to use a launch profile with a hardcoded pid (`"pid": 1000 or no pid specified - so auto detecting a single running process),

[Lldb-commits] [lldb] Fix lldb-dap pickProcess command for selecting process for debugger attachment (PR #75342)

2023-12-13 Thread via lldb-commits
Dodzey wrote: @clayborg Yes, it appears to. For context my workflow is C++ development, using recent versions of Clang and GCC. In VS Code I use the Microsoft CPPTools extension to allow for GDB debugging of GCC builds, with intellisense disabled. I am using clangd for auto-completion, inlay

[Lldb-commits] [lldb] Fix lldb-dap pickProcess command for selecting process for debugger attachment (PR #75342)

2023-12-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM. Since @Dodzey is a first-time contributor one of us needs to click the merge button. I'll leave that to @clayborg or @walter-erquinigo as the owners. https://github.com/llvm/llvm-project/pull/75342

[Lldb-commits] [lldb] Fix lldb-dap pickProcess command for selecting process for debugger attachment (PR #75342)

2023-12-13 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. This looks good to me for now. We can coordinate on adding a native TypeScript layer after this, but no need to hold this up if this work! https://github.com/llvm/llvm-project/pull/75342 ___

[Lldb-commits] [lldb] Fix lldb-dap pickProcess command for selecting process for debugger attachment (PR #75342)

2023-12-13 Thread via lldb-commits
Dodzey wrote: @walter-erquinigo Good to hear that I'm on the right track. Would you want the minimal typescript extension to be a separate extension from the main lldb-dap one?, or would it be okay to have the typescript in the lldb-dap project/extension? It looks to me from my inspection of

[Lldb-commits] [lldb] Fix lldb-dap pickProcess command for selecting process for debugger attachment (PR #75342)

2023-12-13 Thread Walter Erquinigo via lldb-commits
walter-erquinigo wrote: @dodzey, thanks for submitting this PR. @clayborg and I have recently been discussing the idea of implementing a minimal typescript extension for lldb-dap, which could host the kind of functionality that you are trying to fix. I haven't had yet time to do it, but it's

[Lldb-commits] [lldb] Fix lldb-dap pickProcess command for selecting process for debugger attachment (PR #75342)

2023-12-13 Thread via lldb-commits
https://github.com/Dodzey edited https://github.com/llvm/llvm-project/pull/75342 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix lldb-dap pickProcess command for selecting process for debugger attachment (PR #75342)

2023-12-13 Thread David Spickett via lldb-commits
DavidSpickett wrote: @clayborg and @walter-erquinigo are lldb-dap code owners and should be able to advise. https://github.com/llvm/llvm-project/pull/75342 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] Fix lldb-dap pickProcess command for selecting process for debugger attachment (PR #75342)

2023-12-13 Thread via lldb-commits
https://github.com/Dodzey edited https://github.com/llvm/llvm-project/pull/75342 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix lldb-dap pickProcess command for selecting process for debugger attachment (PR #75342)

2023-12-13 Thread via lldb-commits
https://github.com/Dodzey edited https://github.com/llvm/llvm-project/pull/75342 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix lldb-dap pickProcess command for selecting process for debugger attachment (PR #75342)

2023-12-13 Thread via lldb-commits
https://github.com/Dodzey edited https://github.com/llvm/llvm-project/pull/75342 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix lldb-dap pickProcess command for selecting process for debugger attachment (PR #75342)

2023-12-13 Thread via lldb-commits
https://github.com/Dodzey edited https://github.com/llvm/llvm-project/pull/75342 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix lldb-dap pickProcess command for selecting process for debugger attachment (PR #75342)

2023-12-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (Dodzey) Changes Hi, I see that the documentation for lldb-dap refers to a ${command.pickMyProcess} which can be used for interactive process selection within the VS Code IDE. It appears that this functionality no longer works,

[Lldb-commits] [lldb] Fix lldb-dap pickProcess command for selecting process for debugger attachment (PR #75342)

2023-12-13 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] Fix lldb-dap pickProcess command for selecting process for debugger attachment (PR #75342)

2023-12-13 Thread via lldb-commits
https://github.com/Dodzey created https://github.com/llvm/llvm-project/pull/75342 Hi, I see that the documentation for lldb-dap refers to a ${command.pickMyProcess} which can be used for interactive process selection within the VS Code IDE. It appears that this functionality no longer works,