https://github.com/jeffreytan81 closed
https://github.com/llvm/llvm-project/pull/86623
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kusmour approved this pull request.
Most comments are addressed. Stamping to unblock. We can iterate with another
PR :D
https://github.com/llvm/llvm-project/pull/86623
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/jeffreytan81 updated
https://github.com/llvm/llvm-project/pull/86623
>From 6cccde22723157260e7c0b19bf8372aae8d1afaa Mon Sep 17 00:00:00 2001
From: jeffreytan81
Date: Wed, 6 Mar 2024 12:07:03 -0800
Subject: [PATCH 1/7] Fix strcmp build error on buildbot
---
@@ -29,6 +29,9 @@ class LLDB_API SBLineEntry {
lldb::SBAddress GetEndAddress() const;
+ lldb::SBAddress
+ GetSameLineContiguousAddressRangeEnd(bool include_inlined_functions) const;
+
jeffreytan81 wrote:
I take a second look at
jimingham wrote:
> @jimingham, thanks for detailed comment.
>
> "Step in targets" or "Step Into Specific" is an IDE feature that works in two
> steps:
>
> 1. Show a list of call sites before stepping to allow users specify which
> call to step into
> 2. Perform step into with user choosing
jeffreytan81 wrote:
@jimingham, thanks for detailed comment.
"Step in targets" or "Step Into Specific" is an IDE feature that works in two
steps:
1. Show a list of call sites before stepping to allow users specify which call
to step into
2. Perform step into with user choosing call site
@@ -3180,14 +3180,153 @@ void request_stepIn(const llvm::json::Object )
{
llvm::json::Object response;
FillResponse(request, response);
auto arguments = request.getObject("arguments");
+
+ std::string step_in_target;
+ uint64_t target_id = GetUnsigned(arguments,
@@ -29,6 +29,9 @@ class LLDB_API SBLineEntry {
lldb::SBAddress GetEndAddress() const;
+ lldb::SBAddress
+ GetSameLineContiguousAddressRangeEnd(bool include_inlined_functions) const;
+
jeffreytan81 wrote:
@clayborg, right, I know I can do that but I did
jimingham wrote:
> This patch provides the initial implementation for the "Step Into
> Specific/Step In Targets" feature in VSCode DAP.
>
> The implementation disassembles all the call instructions in step range and
> try to resolve operand name (assuming one operand) using debug info. Later,
@@ -3180,14 +3180,153 @@ void request_stepIn(const llvm::json::Object )
{
llvm::json::Object response;
FillResponse(request, response);
auto arguments = request.getObject("arguments");
+
+ std::string step_in_target;
+ uint64_t target_id = GetUnsigned(arguments,
@@ -3180,14 +3180,153 @@ void request_stepIn(const llvm::json::Object )
{
llvm::json::Object response;
FillResponse(request, response);
auto arguments = request.getObject("arguments");
+
+ std::string step_in_target;
+ uint64_t target_id = GetUnsigned(arguments,
@@ -811,23 +811,34 @@ def request_next(self, threadId):
command_dict = {"command": "next", "type": "request", "arguments":
args_dict}
return self.send_recv(command_dict)
-def request_stepIn(self, threadId):
+def request_stepInTargets(self, frameId):
@@ -29,6 +29,9 @@ class LLDB_API SBLineEntry {
lldb::SBAddress GetEndAddress() const;
+ lldb::SBAddress
+ GetSameLineContiguousAddressRangeEnd(bool include_inlined_functions) const;
+
clayborg wrote:
We don't need this API right? We spoke about using
@@ -67,6 +67,21 @@ SBAddress SBLineEntry::GetEndAddress() const {
return sb_address;
}
+SBAddress SBLineEntry::GetSameLineContiguousAddressRangeEnd(
+bool include_inlined_functions) const {
+ LLDB_INSTRUMENT_VA(this);
+
+ SBAddress sb_address;
+ if (m_opaque_up) {
+
@@ -3180,14 +3180,159 @@ void request_stepIn(const llvm::json::Object )
{
llvm::json::Object response;
FillResponse(request, response);
auto arguments = request.getObject("arguments");
+
+ std::string step_in_target;
+ uint64_t target_id = GetUnsigned(arguments,
@@ -3180,14 +3180,159 @@ void request_stepIn(const llvm::json::Object )
{
llvm::json::Object response;
FillResponse(request, response);
auto arguments = request.getObject("arguments");
+
+ std::string step_in_target;
+ uint64_t target_id = GetUnsigned(arguments,
https://github.com/jeffreytan81 updated
https://github.com/llvm/llvm-project/pull/86623
>From 6cccde22723157260e7c0b19bf8372aae8d1afaa Mon Sep 17 00:00:00 2001
From: jeffreytan81
Date: Wed, 6 Mar 2024 12:07:03 -0800
Subject: [PATCH 1/6] Fix strcmp build error on buildbot
---
@@ -3180,14 +3180,159 @@ void request_stepIn(const llvm::json::Object )
{
llvm::json::Object response;
FillResponse(request, response);
auto arguments = request.getObject("arguments");
+
+ std::string step_in_target;
+ uint64_t target_id = GetUnsigned(arguments,
@@ -3180,14 +3180,159 @@ void request_stepIn(const llvm::json::Object )
{
llvm::json::Object response;
FillResponse(request, response);
auto arguments = request.getObject("arguments");
+
+ std::string step_in_target;
+ uint64_t target_id = GetUnsigned(arguments,
@@ -0,0 +1,66 @@
+"""
+Test lldb-dap stepInTargets request
+"""
+
+import dap_server
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+import lldbdap_testcase
+from lldbsuite.test import lldbutil
+
+
+class
https://github.com/jeffreytan81 updated
https://github.com/llvm/llvm-project/pull/86623
>From 6cccde22723157260e7c0b19bf8372aae8d1afaa Mon Sep 17 00:00:00 2001
From: jeffreytan81
Date: Wed, 6 Mar 2024 12:07:03 -0800
Subject: [PATCH 1/5] Fix strcmp build error on buildbot
---
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jeffreytan81)
Changes
This patch provides the initial implementation for the "Step Into Specific/Step
In Targets" feature in VSCode DAP.
The implementation disassembles all the call instructions in step range and try
to resolve
https://github.com/jeffreytan81 updated
https://github.com/llvm/llvm-project/pull/86623
>From 6cccde22723157260e7c0b19bf8372aae8d1afaa Mon Sep 17 00:00:00 2001
From: jeffreytan81
Date: Wed, 6 Mar 2024 12:07:03 -0800
Subject: [PATCH 1/4] Fix strcmp build error on buildbot
---
https://github.com/jeffreytan81 ready_for_review
https://github.com/llvm/llvm-project/pull/86623
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jeffreytan81 edited
https://github.com/llvm/llvm-project/pull/86623
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
93f9fb2c825dba48db64d5f726b54bcbd4766009...b2dfdb546808c495779e5781c6619fcadb752b00
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 93f9fb2c825dba48db64d5f726b54bcbd4766009
b2dfdb546808c495779e5781c6619fcadb752b00 --
https://github.com/jeffreytan81 created
https://github.com/llvm/llvm-project/pull/86623
None
>From 6cccde22723157260e7c0b19bf8372aae8d1afaa Mon Sep 17 00:00:00 2001
From: jeffreytan81
Date: Wed, 6 Mar 2024 12:07:03 -0800
Subject: [PATCH 1/3] Fix strcmp build error on buildbot
---
28 matches
Mail list logo
