Sent you https://reviews.llvm.org/D137000 for review :)
On Wed, Oct 19, 2022 at 2:16 PM Jorge Gorbe Moya wrote:
> Hi Jim,
>
> Thanks for the encouragement! It's unfortunate that you missed the
> notifications and couldn't contribute to the code reviews, but I'm glad you
> think the code looks
Hi Jim,
Thanks for the encouragement! It's unfortunate that you missed the
notifications and couldn't contribute to the code reviews, but I'm glad you
think the code looks fine.
Of course I don't mind adding these as a follow-up, it would be a shame if
I didn't expose the new feature for CLI
Jorge,
It's great to see you worked your way through this change!
Something in our mail pipeline is dropping all my lldb-commits and review
comment notifications. Still haven't figured out who is doing that, so I
didn't get a chance to look over the final version.
The code looks fine, but
Author: Jorge Gorbe Moya
Date: 2022-10-19T12:53:38-07:00
New Revision: d76566417e592cfac9c710f82575473b1b4a9285
URL:
https://github.com/llvm/llvm-project/commit/d76566417e592cfac9c710f82575473b1b4a9285
DIFF:
