Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

Agree, no change in coding standard should or would ever be accompanied by a wholesale change. It's more just agreeing on what clang-format can automatically do for us, and then everyone using clang-format. Note that if you use the git clang-format extension (or an equivalent svn one if one exist

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

Note, it is pure speculation that this is a bug in clang-format based on where the : is placed. I prefer the way we write it, because it places all the initializers on the same level, though I don’t feel so strongly about this one. I would really rather not go through making wholesale changes l

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

Hrmm, that's interesting. I guess I was mistaken in LLVM's rules then. Are we willing to accept this format in LLDB? LabelDecl(DeclContext *DC, SourceLocation IdentL, IdentifierInfo *II, LabelStmt *S, SourceLocation StartL) : NamedDecl(Label, DC, IdentL, II), TheStmt(S),

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

> On Dec 11, 2015, at 2:42 PM, Zachary Turner wrote: > > Yes, but as I mentioned, two things are still unsupported due to limitations > in clang-format. They are return-type-on-new-line (only in declarations. > clang-format supports it for definitions) and the constructor initializer > list

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

Er, I was twisting them together. I've been meaning clang-format. On Fri, Dec 11, 2015 at 2:56 PM, Zachary Turner wrote: > Well clang-tidy doesn't help with the coding standard anyway. It's more > semantic style rather than syntax style. nullptr instead of NULL, Foo() = > delete instead of ma

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

Well clang-tidy doesn't help with the coding standard anyway. It's more semantic style rather than syntax style. nullptr instead of NULL, Foo() = delete instead of making a constructor private. That type of thing. I'm happy letting clang-tidy be postprocessing steps that peopel occasionally run

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

What if we embedded a version? Made whatever modifications we needed, and just merged occasionally from the source? That would lower the barrier, at the cost of raising the need to refresh occasionally. But then you could count on it being there. Seems like a lot of work, though. A simple alte

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

On Fri, Dec 11, 2015 at 2:46 PM, Zachary Turner wrote: > No I'm not talking about whitespace at the end of a line, I'm saying > LLVM's style (and what clang-format does) is this: > > Foo::Foo() >: member_1() >, member_2() >, member_3() > > and what LLDB wants is this: > > Foo::Foo() :

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

clang-tidy is a little more problematic, because the source for clang-tidy isn't even in the same repository. You literally have to clone an entirely separate repo to get it, so it's not built by default. This kind of raises the barrier to entry for using clang-tidy IMO, which is unfortunate sinc

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

No I'm not talking about whitespace at the end of a line, I'm saying LLVM's style (and what clang-format does) is this: Foo::Foo() : member_1() , member_2() , member_3() and what LLDB wants is this: Foo::Foo() : member1(), member2(), member3() Neither one have whitespace at

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

On Fri, Dec 11, 2015 at 2:42 PM, Zachary Turner wrote: > Yes, but as I mentioned, two things are still unsupported due to > limitations in clang-format. They are return-type-on-new-line (only in > declarations. clang-format supports it for definitions) and the > constructor initializer list com

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

Okay. Ending a line with arbitrary whitespace seems wrong as just about any colorizing editor or diff will flag, but I'll survive :-) On Fri, Dec 11, 2015 at 2:42 PM, Zachary Turner wrote: > Yes, but as I mentioned, two things are still unsupported due to > limitations in clang-format. They ar

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

Yes, but as I mentioned, two things are still unsupported due to limitations in clang-format. They are return-type-on-new-line (only in declarations. clang-format supports it for definitions) and the constructor initializer list comma at the end (clang-format puts it at the beginning). That said

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

Yes, it's in the .clang-format at LLDB source root. Eugene. On Fri, Dec 11, 2015 at 2:37 PM, Todd Fiala wrote: > Okay, but does the format match the LLDB-modified format with some kind of > configuration file? We still need to match our guidelines here: > > http://lldb.llvm.org/lldb-coding-conv

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

Okay, but does the format match the LLDB-modified format with some kind of configuration file? We still need to match our guidelines here: http://lldb.llvm.org/lldb-coding-conventions.html We can achieve that with a config file for it, right? (Maybe already existing, maybe in the lldb source tr

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

With git you can already run "git clang-format". You just need `git-clang-format` to be in your PATH (it's under llvm/tools/clang). Not sure how to hook it into SVN On Fri, Dec 11, 2015 at 2:32 PM Eugene Zelenko wrote: > At least clang-format should be applied to all newly added files before >

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

As long as we have a style that matches our style guidelines, I imagine we can ask "set it up like so" if we can hook it into svn or git. I haven't done the pre-commit hooks myself, so I'd need somebody to tell me how to do that. But I suppose that's a good start. On Fri, Dec 11, 2015 at 2:30 PM

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

At least clang-format should be applied to all newly added files before commit. Eugene. On Fri, Dec 11, 2015 at 2:30 PM, Zachary Turner wrote: > Back on the topic of clang-format, what would it take to make clang-format a > regular part of peoples' workflows? > > On Fri, Dec 11, 2015 at 2:27 PM

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

Back on the topic of clang-format, what would it take to make clang-format a regular part of peoples' workflows? On Fri, Dec 11, 2015 at 2:27 PM Todd Fiala wrote: > Yep - sorry. I had been talking to Greg about this and misunderstood his > comment on it. My mistake entirely. Kate and I just ta

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

Yep - sorry. I had been talking to Greg about this and misunderstood his comment on it. My mistake entirely. Kate and I just talked and she pointed me to your document, Jim. The description was: where we had a clearly adhered to standard, keep it. whee we didn't, we adopted LLVM. Sorry for reha

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

It would be a great start if we could just get everyone to actually run clang-format manually. There are two outstanding issues with clang-format that dont' support LLDB style. Those two issues would go away if: 1) LLDB abandoned those styles and adoped LLVM's style (preferred), or 2) I fix clang

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

On Fri, Dec 11, 2015 at 2:11 PM Todd Fiala via lldb-commits < lldb-commits@lists.llvm.org> wrote: > On Fri, Dec 11, 2015 at 2:02 PM, Eugene Zelenko > wrote: > >> Hi, Todd! >> >> As far as I know Clang-format doesn't leave spaces. Somebody pointed >> to old discussion on this matter, but I forgot

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

> On Dec 11, 2015, at 2:01 PM, Todd Fiala via lldb-commits > wrote: > > > > On Fri, Dec 11, 2015 at 1:59 PM, Zachary Turner > wrote: > On Fri, Dec 11, 2015 at 1:55 PM Todd Fiala via lldb-commits > mailto:lldb-commits@lists.llvm.org>> wrote: > Hey Eugene and Greg,

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

On Fri, Dec 11, 2015 at 2:04 PM, Zachary Turner wrote: > No, sadly. We still have 4 space indentation, allman style braces, 120 > line character limit, return-type-on-separate-line, and a few other > differences . I've > tried on a couple of oc

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

On Fri, Dec 11, 2015 at 2:10 PM, Todd Fiala wrote: > > > On Fri, Dec 11, 2015 at 2:04 PM, Zachary Turner > wrote: > >> No, sadly. We still have 4 space indentation, allman style braces, 120 >> line character limit, return-type-on-separate-line, and a few other >> differences

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

On Fri, Dec 11, 2015 at 2:04 PM Zachary Turner wrote: > No, sadly. We still have 4 space indentation, allman style braces, 120 > line character limit, return-type-on-separate-line, and a few other > differences . I've > tried on a couple of occ

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

No, sadly. We still have 4 space indentation, allman style braces, 120 line character limit, return-type-on-separate-line, and a few other differences . I've tried on a couple of occasions to remove some of these differences and move closer to LL

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

Hi, Todd! As far as I know Clang-format doesn't leave spaces. Somebody pointed to old discussion on this matter, but I forgot it locations :-( I think will be good idea to implement automatic run of Clang-format as pre-commit hook, since LLDB code have too much diversity in code formatting for si

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

On Fri, Dec 11, 2015 at 1:59 PM, Zachary Turner wrote: > On Fri, Dec 11, 2015 at 1:55 PM Todd Fiala via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > >> Hey Eugene and Greg, >> >> I thought we were doing spaces before the open parens in places like this: >> >> -BreakpointResolverSP r

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

On Fri, Dec 11, 2015 at 1:55 PM Todd Fiala via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Hey Eugene and Greg, > > I thought we were doing spaces before the open parens in places like this: > > -BreakpointResolverSP resolver_sp(new BreakpointResolverFileLine (NULL, > ... > +Break

[Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

Author: eugenezelenko Date: Fri Dec 11 13:52:15 2015 New Revision: 255364 URL: http://llvm.org/viewvc/llvm-project?rev=255364&view=rev Log: Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp. Simplify smart pointers checks in condition