Re: [Lldb-commits] [lldb] r280755 - Reorder FreeBSD Host.cpp #includes to fix build

2016-09-06 Thread Zachary Turner via lldb-commits
he above order. > It's crucial for and to be on a top as other > headers may assume that they were > already included. > > *Sent:* Wednesday, September 07, 2016 at 12:05 AM > *From:* "Dimitry Andric via lldb-commits" > *To:* "Zachary Turner" > *Cc:*

Re: [Lldb-commits] [lldb] r280755 - Reorder FreeBSD Host.cpp #includes to fix build

2016-09-06 Thread Kamil Rytarowski via lldb-commits
e already included.   Sent: Wednesday, September 07, 2016 at 12:05 AM From: "Dimitry Andric via lldb-commits" To: "Zachary Turner" Cc: lldb-commits@lists.llvm.org Subject: Re: [Lldb-commits] [lldb] r280755 - Reorder FreeBSD Host.cpp #includes to fix build In general, and

Re: [Lldb-commits] [lldb] r280755 - Reorder FreeBSD Host.cpp #includes to fix build

2016-09-06 Thread Dimitry Andric via lldb-commits
In general, and headers should be at the top, followed by standard headers such as , then followed by application-specific headers. IIRC this is also the case for Linux. -Dimitry > On 07 Sep 2016, at 00:02, Zachary Turner via lldb-commits > wrote: > > Why was this causing a problem? The

Re: [Lldb-commits] [lldb] r280755 - Reorder FreeBSD Host.cpp #includes to fix build

2016-09-06 Thread Zachary Turner via lldb-commits
Why was this causing a problem? The only headers that were re-ordered are system headers. Does FreeBSD's libraries have requirements about certain headers being included before other headers? On Tue, Sep 6, 2016 at 2:33 PM Ed Maste via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author

[Lldb-commits] [lldb] r280755 - Reorder FreeBSD Host.cpp #includes to fix build

2016-09-06 Thread Ed Maste via lldb-commits
Author: emaste Date: Tue Sep 6 16:25:31 2016 New Revision: 280755 URL: http://llvm.org/viewvc/llvm-project?rev=280755&view=rev Log: Reorder FreeBSD Host.cpp #includes to fix build Modified: lldb/trunk/source/Host/freebsd/Host.cpp Modified: lldb/trunk/source/Host/freebsd/Host.cpp URL: http: