Re: [Lldb-commits] [lldb] r321271 - Work around test failures on red-hat linux

2018-01-02 Thread Jim Ingham via lldb-commits
This is a trivial thing, but you can use: lldbutil.run_break_set_by_source_regexp rather than having to capture the line number matching the regex and setting a line breakpoint from that. You are setting them in different source files, so you'll have to pass: extra_options = "-f

Re: [Lldb-commits] [lldb] r321271 - Work around test failures on red-hat linux

2017-12-21 Thread Pavel Labath via lldb-commits
That's great, thanks for the explanation. I'll look into that. On 21 December 2017 at 16:34, Greg Clayton wrote: > > On Dec 21, 2017, at 7:24 AM, Pavel Labath via lldb-commits > wrote: > > On 21 December 2017 at 15:17, Pavel Labath

Re: [Lldb-commits] [lldb] r321271 - Work around test failures on red-hat linux

2017-12-21 Thread Greg Clayton via lldb-commits
BTW: we should remove the GetIsDynamicLinkEditor() from Module.h/cpp and ObjectFile.h, ObjectFileMachO.h/.cpp since it is dead code now. > On Dec 21, 2017, at 7:24 AM, Pavel Labath via lldb-commits > wrote: > > On 21 December 2017 at 15:17, Pavel Labath

Re: [Lldb-commits] [lldb] r321271 - Work around test failures on red-hat linux

2017-12-21 Thread Greg Clayton via lldb-commits
> On Dec 21, 2017, at 7:24 AM, Pavel Labath via lldb-commits > wrote: > > On 21 December 2017 at 15:17, Pavel Labath wrote: >> Right now I'm looking at two (ignoring the debug-info multiplication): >> TestExprs2.py and TestTopLevelExprs.py >>

Re: [Lldb-commits] [lldb] r321271 - Work around test failures on red-hat linux

2017-12-21 Thread Pavel Labath via lldb-commits
On 21 December 2017 at 15:17, Pavel Labath wrote: > Right now I'm looking at two (ignoring the debug-info multiplication): > TestExprs2.py and TestTopLevelExprs.py > TestExprs2 is encountering ambiguity when looking up the "environ" > symbol (the dynamic linker contains an

Re: [Lldb-commits] [lldb] r321271 - Work around test failures on red-hat linux

2017-12-21 Thread Pavel Labath via lldb-commits
Right now I'm looking at two (ignoring the debug-info multiplication): TestExprs2.py and TestTopLevelExprs.py TestExprs2 is encountering ambiguity when looking up the "environ" symbol (the dynamic linker contains an extra copy). I think I know how to handle that. I haven't yet looked at what is

Re: [Lldb-commits] [lldb] r321271 - Work around test failures on red-hat linux

2017-12-21 Thread Davide Italiano via lldb-commits
What's the number of failures on Linux x86/64 red hat currently? Thanks, -- Davide On Thu, Dec 21, 2017 at 4:09 PM, Pavel Labath wrote: > Yeah, purely renaming the variables would be a bit like hiding > problems under the carpet. But, I think adding the new test makes up >

Re: [Lldb-commits] [lldb] r321271 - Work around test failures on red-hat linux

2017-12-21 Thread Pavel Labath via lldb-commits
Yeah, purely renaming the variables would be a bit like hiding problems under the carpet. But, I think adding the new test makes up for that. This way, anyone who wants to fix this issue in the future will have a simple test to validate his fix. On 21 December 2017 at 14:55, Davide Italiano

[Lldb-commits] [lldb] r321271 - Work around test failures on red-hat linux

2017-12-21 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Dec 21 06:40:03 2017 New Revision: 321271 URL: http://llvm.org/viewvc/llvm-project?rev=321271=rev Log: Work around test failures on red-hat linux Two tests were failing because the debugger was picking up multiply defined internal symbols from the system libraries. This