Re: [Lldb-commits] [lldb] r355375 - [Expression] Remove unused parameter from Evaluate

2019-03-05 Thread Jim Ingham via lldb-commits
Eh, I take that back. We switched to injecting #file and #line into the body text to do the same job, so this is indeed no longer needed. Jim > On Mar 5, 2019, at 10:21 AM, Jim Ingham via lldb-commits > wrote: > > If you don't mind, I would like to revert this patch. Though the parameter

Re: [Lldb-commits] [lldb] r355375 - [Expression] Remove unused parameter from Evaluate

2019-03-05 Thread Jim Ingham via lldb-commits
If you don't mind, I would like to revert this patch. Though the parameter is currently unused on the llvm.org side, it is used in the Swift REPL, so removing it causes unnecessary conflicts. Also, it will be necessary to support any kind of REPL - Sean gave a talk a couple of years ago at

[Lldb-commits] [lldb] r355375 - [Expression] Remove unused parameter from Evaluate

2019-03-04 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Mon Mar 4 19:33:34 2019 New Revision: 355375 URL: http://llvm.org/viewvc/llvm-project?rev=355375=rev Log: [Expression] Remove unused parameter from Evaluate Modified: lldb/trunk/include/lldb/Expression/UserExpression.h lldb/trunk/source/Expression/REPL.cpp