Re: [Lldb-commits] [PATCH] D12976: Fix TestChangeProcessGroup to properly step out of sleep.

2015-09-21 Thread Tamas Berghammer via lldb-commits
tberghammer added a subscriber: tberghammer. tberghammer added a comment. I committed in the fix mentioned by Pavel as http://reviews.llvm.org/rL248146 http://reviews.llvm.org/D12976 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D12976: Fix TestChangeProcessGroup to properly step out of sleep.

2015-09-21 Thread Chaoren Lin via lldb-commits
chaoren added a comment. Do we still need the original stepInstruction? http://reviews.llvm.org/D12976 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12976: Fix TestChangeProcessGroup to properly step out of sleep.

2015-09-18 Thread Pavel Labath via lldb-commits
labath added a comment. We have been looking into these failures also, and the cause is the recent changes, which make it impossible to evaluate c(++) expression in assembly language frames (see http://reviews.llvm.org/D12962). This is not the purpose of this test, but I don't think we should

Re: [Lldb-commits] [PATCH] D12976: Fix TestChangeProcessGroup to properly step out of sleep.

2015-09-18 Thread Chaoren Lin via lldb-commits
chaoren updated this revision to Diff 35113. chaoren added a comment. Remove old line. http://reviews.llvm.org/D12976 Files: test/functionalities/process_group/TestChangeProcessGroup.py Index: test/functionalities/process_group/TestChangeProcessGroup.py

Re: [Lldb-commits] [PATCH] D12976: Fix TestChangeProcessGroup to properly step out of sleep.

2015-09-18 Thread Chaoren Lin via lldb-commits
chaoren added a comment. I thought this was supposed to be fixed, but TestChangeProcessGroup, TestExpressionInSyscall, and TestRegisters just started failing for me recently because of this. http://reviews.llvm.org/D12976 ___ lldb-commits mailing

Re: [Lldb-commits] [PATCH] D12976: Fix TestChangeProcessGroup to properly step out of sleep.

2015-09-18 Thread Pavel Labath via lldb-commits
labath added a comment. (I wouldn't be opposed to temporarily XFAILing the failing tests, so they don't bother anyone running the test suite) http://reviews.llvm.org/D12976 ___ lldb-commits mailing list lldb-commits@lists.llvm.org