zturner added a comment.
In http://reviews.llvm.org/D14673#290280, @jingham wrote:
> If the problem is that the self of the test object doesn't always have a
> debug_info setting, why not just always initialize it to None? Seems weird
> to have a general property like this that we don't
jingham added a comment.
If the problem is that the self of the test object doesn't always have a
debug_info setting, why not just always initialize it to None? Seems weird to
have a general property like this that we don't initialize.
http://reviews.llvm.org/D14673
chying added a comment.
In http://reviews.llvm.org/D14673#290556, @zturner wrote:
> Ahh, sorry. I litearlly just committed a change to the same function. You
> may have to do a merge, sorry about that.
Ahh, I see, will merge again.
http://reviews.llvm.org/D14673
chying updated this revision to Diff 40347.
chying added a comment.
Recommit r253106 - Add a "not_in()" function you can apply to the list type
arguments to expectedFailureAll ...
Initialize self.debug_info in Base::setUp()
Check for None before calling "value in list"
chying added a comment.
The compiler None check is because inside of check_list_or_lambda function, it
checks for "value in list_or_lamda", which will throw exception if value is None
I agree that the code will be cleaner if debug_info is initialized to None.
Will try to upload another patch
This revision was automatically updated to reflect the committed changes.
Closed by commit rL253272: Re-Apply "Add a "not_in()" function you can apply to
the list type arguments… (authored by chying).
Changed prior to commit:
http://reviews.llvm.org/D14673?vs=40353=40357#toc
Repository:
rL
chying updated this revision to Diff 40353.
chying added a comment.
Rebase on the latest commit.
http://reviews.llvm.org/D14673
Files:
packages/Python/lldbsuite/test/functionalities/breakpoint/consecutive_breakpoins/TestConsecutiveBreakpoints.py
packages/Python/lldbsuite/test/lldbtest.py
zturner added a subscriber: zturner.
zturner added a comment.
I think the `is None` check should go back inside the `check_list_or_lambda`
function. Bringing it outside the function looks identical to me. If `None`
is passed to the function, the `callable()` check will fail, and then the
