Re: [Lldb-commits] [lldb] r258919 - [LLDB][MIPS] A small fix in GetBreakableLoadAddress() for MIPS

2016-02-02 Thread Hans Wennborg via lldb-commits
On Mon, Feb 1, 2016 at 9:34 AM, Hans Wennborg wrote: > On Mon, Feb 1, 2016 at 2:37 AM, Bhushan Attarde > wrote: >> Hi Hans, >> >> Could you please add this (r258919) to the release branch? >> Also commit r258967 (on top of this) by Zachary which

Re: [Lldb-commits] [lldb] r258919 - [LLDB][MIPS] A small fix in GetBreakableLoadAddress() for MIPS

2016-02-02 Thread Hans Wennborg via lldb-commits
On Tue, Feb 2, 2016 at 8:52 AM, Hans Wennborg wrote: > On Mon, Feb 1, 2016 at 9:34 AM, Hans Wennborg wrote: >> On Mon, Feb 1, 2016 at 2:37 AM, Bhushan Attarde >> wrote: >>> Hi Hans, >>> >>> Could you please add this (r258919) to

Re: [Lldb-commits] [lldb] r258919 - [LLDB][MIPS] A small fix in GetBreakableLoadAddress() for MIPS

2016-02-01 Thread Bhushan Attarde via lldb-commits
Hi Hans, Could you please add this (r258919) to the release branch? Also commit r258967 (on top of this) by Zachary which fixes some python 3 incompatibilities. Thanks, Bhushan -Original Message- From: lldb-commits [mailto:lldb-commits-boun...@lists.llvm.org] On Behalf Of Bhushan D.

Re: [Lldb-commits] [lldb] r258919 - [LLDB][MIPS] A small fix in GetBreakableLoadAddress() for MIPS

2016-02-01 Thread Hans Wennborg via lldb-commits
On Mon, Feb 1, 2016 at 2:37 AM, Bhushan Attarde wrote: > Hi Hans, > > Could you please add this (r258919) to the release branch? > Also commit r258967 (on top of this) by Zachary which fixes some python 3 > incompatibilities. Since this touched more than just

Re: [Lldb-commits] [lldb] r258919 - [LLDB][MIPS] A small fix in GetBreakableLoadAddress() for MIPS

2016-01-27 Thread Zachary Turner via lldb-commits
Just a heads up, `isinstance(foo, basestring)` doesn't work in Python 3. You need to use `isinstance(foo, six.string_types)`. I'm checking in a fix for this, but just wanted to let you know so you can keep this in the back of your head for future. On Wed, Jan 27, 2016 at 2:20 AM Bhushan D.

Re: [Lldb-commits] [lldb] r258919 - [LLDB][MIPS] A small fix in GetBreakableLoadAddress() for MIPS

2016-01-27 Thread Zachary Turner via lldb-commits
Also please add `from __future__ import print_function` to the top of every new test file you create. Sorry this didn't get caught during review, no worries. On Wed, Jan 27, 2016 at 10:42 AM Zachary Turner wrote: > Just a heads up, `isinstance(foo, basestring)` doesn't work