tberghammer updated this revision to Diff 32395.
tberghammer added a comment.
Fix incorrect assert
http://reviews.llvm.org/D11947
Files:
source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp
source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp
Hi all,
This commit was reverted in r245222 as it was causing failures on the
linux build-bot. It has a number of issues
http://reviews.llvm.org/rL245216 and I would prefer if it were not
merged until these are resolved. And in any case, this doesn't seem
like a critical bug fix suitable for
Hi Hans,
The file RegisterContext_mips64.h was replaced with
RegisterContext_mips.h in master branch.
In the release branch, the file RegisterContext_mips64.h still exists.
Could you please delete RegisterContext_mips64.h from the release branch ?
Regards,
Sagar
On Tuesday 18 August 2015
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245272: [LLGS] Avoid misrepresenting log lines as inferior
output (authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D12083?vs=32298id=32383#toc
Repository:
rL LLVM
Author: sivachandra
Date: Tue Aug 18 12:56:06 2015
New Revision: 245319
URL: http://llvm.org/viewvc/llvm-project?rev=245319view=rev
Log:
[ValueObjectSynthetic and ValueObjectDynamicValue] Override GetDeclaration
Summary:
Returns the declaration of the parent (non-synthetic or static) value.
sivachandra added a comment.
Committed. Test suite is clean.
http://reviews.llvm.org/D12092
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ovyalov accepted this revision.
Comment at: include/lldb/Core/RegisterValue.h:51
@@ -51,2 +50,3 @@
{
+m_scalar = (unsigned long)0;
}
Nit: you can initialize m_scalar within initializer list.
Comment at:
Greg: ping?
On Fri, Aug 14, 2015 at 11:06 AM, Hans Wennborg h...@chromium.org wrote:
Sure, if Greg approves.
Thanks,
Hans
On Thu, Aug 13, 2015 at 11:25 PM, Bhushan Attarde
bhushan.atta...@imgtec.com wrote:
Hi Hans,
Could you please merge this to the release branch?
Thanks
Bhushan
clayborg added a comment.
No need to wait for Sean.
http://reviews.llvm.org/D11962
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Rather than all of this ugly error-prone code, can we instead use
llvm::sys::fs::root_name to check whether the path contains a drive letter?
On Tue, Aug 18, 2015 at 1:52 PM Dawn Perchik via lldb-commits
lldb-commits@lists.llvm.org wrote:
dawn created this revision.
dawn added reviewers:
chaoren added a subscriber: chaoren.
chaoren added a comment.
Ping? It's been a week, and the buildbot is still red because of this:
http://lab.llvm.org:8011/builders/lldb-x86_64-darwin-13.4/builds/4923
http://reviews.llvm.org/D11962
___
Author: zturner
Date: Tue Aug 18 15:01:28 2015
New Revision: 245338
URL: http://llvm.org/viewvc/llvm-project?rev=245338view=rev
Log:
[Windows] XFAIL tests that depend on expression name lookup.
Name lookup doesn't work properly with Windows targets. This is
most likely due to issues with name
Author: ovyalov
Date: Tue Aug 18 16:20:25 2015
New Revision: 245357
URL: http://llvm.org/viewvc/llvm-project?rev=245357view=rev
Log:
Mark TestCModules as XFAIL on OSX.
http://reviews.llvm.org/D11962
Modified:
lldb/trunk/test/lang/c/modules/TestCModules.py
Modified:
dawn added a comment.
In http://reviews.llvm.org/D12115#227241, @brucem wrote:
... this needs a test as well if possible.
Since the lldb-mi tests don't run on Windows, I don't see how that would be
possible.
Repository:
rL LLVM
http://reviews.llvm.org/D12115
Author: chaoren
Date: Tue Aug 18 21:55:33 2015
New Revision: 245407
URL: http://llvm.org/viewvc/llvm-project?rev=245407view=rev
Log:
XFAIL TestCppChainedCalls for GCC.
Modified:
lldb/trunk/test/lang/cpp/chained-calls/TestCppChainedCalls.py
Modified:
Author: chaoren
Date: Tue Aug 18 23:08:56 2015
New Revision: 245412
URL: http://llvm.org/viewvc/llvm-project?rev=245412view=rev
Log:
Fix TestCppNsImport and TestCppScope for remote tests.
Modified:
lldb/trunk/test/lang/cpp/nsimport/TestCppNsImport.py
jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
Looks good to me.
http://reviews.llvm.org/D11947
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
chaoren added a subscriber: chaoren.
Comment at: test/lang/cpp/global_operators/TestCppGlobalOperators.py:9
@@ +8,3 @@
+class TestCppGlobalOperators(TestBase):
+
+mydir = TestBase.compute_mydir(__file__)
Please be careful of trailing whitespaces.
clayborg accepted this revision.
clayborg added a comment.
Please commit.
http://reviews.llvm.org/D11962
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dawn created this revision.
dawn added reviewers: abidh, ki.stfu, brucem.
dawn added a subscriber: lldb-commits.
dawn set the repository for this revision to rL LLVM.
This patch causes lldb-mi to print the (gdb) prompt after =breakpoint-modified
and =breakpoint-created notifications. This makes
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
I see your point. I am still not too happy with this approach but I don't have
any better idea to solve it. I am fine with committing it in in this format and
we can improve it
Author: paulherman
Date: Tue Aug 18 17:43:37 2015
New Revision: 245380
URL: http://llvm.org/viewvc/llvm-project?rev=245380view=rev
Log:
Test chaned function calls and imported namespaces in C++
Added:
lldb/trunk/test/lang/cpp/chained-calls/
lldb/trunk/test/lang/cpp/chained-calls/Makefile
dawn added a comment.
Are you saying that there is a situation where you are given a path, and you
have no idea whether it is a posix path or a windows path?
Yes. For example, in lldb on OSX, we can be debugging an app that was built on
OSX, or an app that was built on Windows targeting
Author: chaoren
Date: Tue Aug 18 20:24:57 2015
New Revision: 245398
URL: http://llvm.org/viewvc/llvm-project?rev=245398view=rev
Log:
Update to r245397.
`ast_transformer` could be null, in which case we should initialize
`m_code_generator` with the ASTContext.
Modified:
amccarth updated this revision to Diff 32475.
amccarth marked an inline comment as done.
amccarth added a comment.
Addresses some of Zach's comments.
http://reviews.llvm.org/D12126
Files:
source/Plugins/Process/Windows/ExceptionRecord.h
On 18 August 2015 at 13:16, Ed Maste ema...@freebsd.org wrote:
On 15 August 2015 at 01:21, Jason Molenda via lldb-commits
lldb-commits@lists.llvm.org wrote:
Author: jmolenda
Date: Fri Aug 14 20:21:01 2015
New Revision: 245141
URL: http://llvm.org/viewvc/llvm-project?rev=245141view=rev
clayborg added a comment.
Looks good.
Repository:
rL LLVM
http://reviews.llvm.org/D12100
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
27 matches
Mail list logo
