Re: [Lldb-commits] [PATCH] D13060: Use opaque_compiler_type_t in place of void*.

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D13060 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D12968: Fix for lldb-mi crash in Listener code if -exec-abort MI command was invoked without getting process stopped

KLapshin updated this revision to Diff 35392. Repository: rL LLVM http://reviews.llvm.org/D12968 Files: source/Target/Process.cpp Index: source/Target/Process.cpp === --- source/Target/Process.cpp +++ source/Target/Process.cpp

[Lldb-commits] [lldb] r248316 - On second thought, amend the previous patch to pass itself the ValueObject& for the static value instead of just its type

Author: enrico Date: Tue Sep 22 14:58:02 2015 New Revision: 248316 URL: http://llvm.org/viewvc/llvm-project?rev=248316=rev Log: On second thought, amend the previous patch to pass itself the ValueObject& for the static value instead of just its type Modified:

Re: [Lldb-commits] [PATCH] D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range

granata.enrico added a comment. Gotcha! My suggestion would be to add the DoesPrintValue() logic to SBTypeSummary. I can't recall if it's there already - but if not, it would be a fine thing to add. Then the MI could use SBValue and SBTypeSummary to make that determination as it sees fit.

[Lldb-commits] [lldb] r248247 - xUnit test formatter: add options for ignoring skipped tests

Author: tfiala Date: Tue Sep 22 01:32:50 2015 New Revision: 248247 URL: http://llvm.org/viewvc/llvm-project?rev=248247=rev Log: xUnit test formatter: add options for ignoring skipped tests Skipped tests can be dropped from xUnit reports if either the name or the skip reason matches one of a

Re: [Lldb-commits] [PATCH] D12976: Update TestChangeProcessGroup to remove obsolete workaround.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. That shouln't be needed anymore, thanks. http://reviews.llvm.org/D12976 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r248248 - [LLDB][MIPS] microMIPS breakpoints, disassembly and compressed addresses

Author: jaydeep Date: Tue Sep 22 01:36:56 2015 New Revision: 248248 URL: http://llvm.org/viewvc/llvm-project?rev=248248=rev Log: [LLDB][MIPS] microMIPS breakpoints, disassembly and compressed addresses SUMMARY: This patch detects microMIPS symbols, sets breakpoints using un-compressed

[Lldb-commits] [lldb] r248286 - Remove IRToDWARF.h

Author: brucem Date: Tue Sep 22 11:30:26 2015 New Revision: 248286 URL: http://llvm.org/viewvc/llvm-project?rev=248286=rev Log: Remove IRToDWARF.h Summary: The corresponding .cpp file was removed in September of 2011 in r139772. Reviewers: spyffe, clayborg Subscribers: lldb-commits

Re: [Lldb-commits] [PATCH] D13039: Rename clang_type_t to opaque_t.

This revision was automatically updated to reflect the committed changes. Closed by commit rL248288: Rename clang_type_t to opaque_compiler_type_t. (authored by brucem). Changed prior to commit: http://reviews.llvm.org/D13039?vs=35339=35382#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D13060: Use opaque_compiler_type_t in place of void*.

brucem created this revision. brucem added a reviewer: clayborg. brucem added a subscriber: lldb-commits. http://reviews.llvm.org/D13060 Files: include/lldb/Symbol/ClangASTContext.h include/lldb/Symbol/CompilerType.h include/lldb/Symbol/GoASTContext.h include/lldb/Symbol/TaggedASTType.h

[Lldb-commits] [lldb] r248301 - Update TestChangeProcessGroup to remove obsolete workaround.

Author: chaoren Date: Tue Sep 22 12:37:34 2015 New Revision: 248301 URL: http://llvm.org/viewvc/llvm-project?rev=248301=rev Log: Update TestChangeProcessGroup to remove obsolete workaround. Expression evaluation in syscalls should work now. Reviewers: labath Subscribers: lldb-commits

Re: [Lldb-commits] [PATCH] D12976: Update TestChangeProcessGroup to remove obsolete workaround.

This revision was automatically updated to reflect the committed changes. Closed by commit rL248301: Update TestChangeProcessGroup to remove obsolete workaround. (authored by chaoren). Changed prior to commit: http://reviews.llvm.org/D12976?vs=35304=35391#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D13039: Rename clang_type_t to opaque_t.

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. We should switch all of TypeSystem's methods over to use this instead of "void *" as well in a future commit. http://reviews.llvm.org/D13039

Re: [Lldb-commits] [PATCH] D13028: Merge dsym and dwarf test cases

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. For the failing test cases, just check this stuff in and we should take care or marking any needed tests and expected fail. Is there a way to mark a test such that the "dwarf

Re: [Lldb-commits] [PATCH] D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range

clayborg added a comment. As Enrico stated. there is already a SBStream based way to get the summary in "const char * SBValueGetSummary (lldb::SBStream& stream, lldb::SBTypeSummaryOptions& options);" so no need to add anything as I had suggested. http://reviews.llvm.org/D13058

Re: [Lldb-commits] [PATCH] D13039: Rename clang_type_t to opaque_t.

brucem added a comment. I already have that as a commit lined up. Just wanted this to land separately first. :) http://reviews.llvm.org/D13039 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r248288 - Rename clang_type_t to opaque_compiler_type_t.

Author: brucem Date: Tue Sep 22 12:04:24 2015 New Revision: 248288 URL: http://llvm.org/viewvc/llvm-project?rev=248288=rev Log: Rename clang_type_t to opaque_compiler_type_t. Summary: This is no longer related to Clang and is just an opaque pointer to data for a compiler type. Reviewers:

Re: [Lldb-commits] [PATCH] D12968: Fix for lldb-mi crash in Listener code if -exec-abort MI command was invoked without getting process stopped

KLapshin added a comment. Greg, I reworked initial workaround solution, now this is exact fix. Repository: rL LLVM http://reviews.llvm.org/D12968 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range

granata.enrico added a subscriber: granata.enrico. granata.enrico requested changes to this revision. granata.enrico added a reviewer: granata.enrico. granata.enrico added a comment. Is there a reason to explicitly add an API to get the concatenation of value and summary? We already have APIs

Re: [Lldb-commits] [PATCH] D12968: Fix for lldb-mi crash in Listener code if -exec-abort MI command was invoked without getting process stopped

KLapshin updated the summary for this revision. KLapshin updated this revision to Diff 35390. Repository: rL LLVM http://reviews.llvm.org/D12968 Files: source/Target/Process.cpp Index: source/Target/Process.cpp === ---

Re: [Lldb-commits] [PATCH] D13056: Fix race condition during process detach

KLapshin added a comment. See http://reviews.llvm.org/D12968 also - fix for missed hijacked listener set in Process::HaltForDestroyOrDetach() http://reviews.llvm.org/D13056 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D13028: Merge dsym and dwarf test cases

I am at CppCon all week. If you need to get this in before Monday, can you have Oleksiy or Chaoren test on Windows? Otherwise I can take a look next week. On Tue, Sep 22, 2015 at 9:51 AM Tamas Berghammer wrote: > tberghammer retitled this revision from "[RFC] Merge

Re: [Lldb-commits] [PATCH] D13028: Merge dsym and dwarf test cases

tberghammer added a comment. In http://reviews.llvm.org/D13028#250822, @clayborg wrote: > Looks good. For the failing test cases, just check this stuff in and we > should take care or marking any needed tests and expected fail. Is there a > way to mark a test such that the "dwarf in .o files"

[Lldb-commits] [lldb] r248306 - Test runner process group isolation take 2.

Author: tfiala Date: Tue Sep 22 13:05:11 2015 New Revision: 248306 URL: http://llvm.org/viewvc/llvm-project?rev=248306=rev Log: Test runner process group isolation take 2. This one does not create a session, but just creates a new process group in the same session. Modified:

Re: [Lldb-commits] [PATCH] D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. You can't use std::string in the public API. Use lldb::SBStream as noted in inlined comments. Comment at: include/lldb/API/SBValue.h:132-133 @@ -131,1 +131,4

Re: [Lldb-commits] [PATCH] D13028: Merge dsym and dwarf test cases

zturner added a comment. At some point I really would love to reduce the number of decorators. It's starting to get ridiculous :) Seems like we only need one decorator that takes everything as optional arguments http://reviews.llvm.org/D13028 ___

Re: [Lldb-commits] [PATCH] D12968: Fix for lldb-mi crash in Listener code if -exec-abort MI command was invoked without getting process stopped

KLapshin added a subscriber: labath. KLapshin added a comment. Due to @labath reworked and replaced HaltForDestroyOrDetach to StopHaltForDestroyOrDetach method (see http://reviews.llvm.org/D13056) and his patch already approved by @clayborg and crash still reproducible with just race condition

Re: [Lldb-commits] [PATCH] D13066: Make DWARFASTParserClang::ParseChildMembers return a bool.

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. We have the same problem with base classes where if we have a class that has a DW_TAG_inheritance tag that points to a forward declaration for a class, then we start and end the

Re: [Lldb-commits] [PATCH] D13066: Make DWARFASTParserClang::ParseChildMembers return a bool.

clayborg added a comment. Emitting a warning is a good idea as well if the compiler is clang and how to fix it (something like "please specify -fno-limit-debug-info ...") http://reviews.llvm.org/D13066 ___ lldb-commits mailing list

[Lldb-commits] [lldb] r248364 - Fix indentation in ExpressionParser.h.

Author: brucem Date: Tue Sep 22 21:23:02 2015 New Revision: 248364 URL: http://llvm.org/viewvc/llvm-project?rev=248364=rev Log: Fix indentation in ExpressionParser.h. Modified: lldb/trunk/include/lldb/Expression/ExpressionParser.h Modified:

[Lldb-commits] [PATCH] D13084: Fix covered-switch-default warning in FormatManager.

brucem created this revision. brucem added reviewers: granata.enrico, clayborg. brucem added a subscriber: lldb-commits. The default case doesn't need to be here as the switch covers all possible values. If there's a new "lazy bool" value added in the future, the compiler would start to warn

Re: [Lldb-commits] [PATCH] D13084: Fix covered-switch-default warning in FormatManager.

granata.enrico accepted this revision. granata.enrico added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D13084 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r248363 - Allow CompilerType to express a vote on whether oneliner printing should happen

Author: enrico Date: Tue Sep 22 21:04:34 2015 New Revision: 248363 URL: http://llvm.org/viewvc/llvm-project?rev=248363=rev Log: Allow CompilerType to express a vote on whether oneliner printing should happen Modified: lldb/trunk/include/lldb/Symbol/CompilerType.h

Re: [Lldb-commits] [PATCH] D13084: Fix covered-switch-default warning in FormatManager.

This revision was automatically updated to reflect the committed changes. Closed by commit rL248365: Fix covered-switch-default warning in FormatManager. (authored by brucem). Changed prior to commit: http://reviews.llvm.org/D13084?vs=35454=35456#toc Repository: rL LLVM

[Lldb-commits] [lldb] r248365 - Fix covered-switch-default warning in FormatManager.

Author: brucem Date: Tue Sep 22 21:33:30 2015 New Revision: 248365 URL: http://llvm.org/viewvc/llvm-project?rev=248365=rev Log: Fix covered-switch-default warning in FormatManager. Summary: The default case doesn't need to be here as the switch covers all possible values. If there's a new "lazy

[Lldb-commits] [lldb] r248359 - Add {TypeSystem|CompilerType}::GetTypeForFormatters()

Author: enrico Date: Tue Sep 22 20:39:46 2015 New Revision: 248359 URL: http://llvm.org/viewvc/llvm-project?rev=248359=rev Log: Add {TypeSystem|CompilerType}::GetTypeForFormatters() Different type system may have different notions of attributes of a type that do not matter for data formatters

[Lldb-commits] [PATCH] D13066: Make DWARFASTParserClang::ParseChildMembers return a bool.

sivachandra created this revision. sivachandra added a reviewer: clayborg. sivachandra added a subscriber: lldb-commits. The return value is false if any of the child members have incomplete type info. This helps in cases like these: class Foo { public: std::string str; }; ... Foo f; If a

Re: [Lldb-commits] [PATCH] D13066: Make DWARFASTParserClang::ParseChildMembers return a bool.

sivachandra updated this revision to Diff 35410. sivachandra added a comment. Fix few copy-paste typos. http://reviews.llvm.org/D13066 Files: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.h

Re: [Lldb-commits] [PATCH] D13066: Make DWARFASTParserClang::ParseChildMembers return a bool.

clayborg added a comment. We also need to make sure that if the class is specified anywhere else within the current binary (in another .o file), that we find that class definition and use it in place of the forward declaration. So if you can make another test with the same source file, and

[Lldb-commits] [lldb] r248323 - test framework: default to threading-based test runners

Author: tfiala Date: Tue Sep 22 16:19:40 2015 New Revision: 248323 URL: http://llvm.org/viewvc/llvm-project?rev=248323=rev Log: test framework: default to threading-based test runners Windows gets threading-pool, OS X versions < 10.10 get multiprocessing, everyone else gets threading. Modified:

Re: [Lldb-commits] [PATCH] D13028: Merge dsym and dwarf test cases

tfiala accepted this revision. tfiala added a comment. LGTM as well. Thanks! http://reviews.llvm.org/D13028 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r248343 - A small fixup needed for debugserver to work natively

Author: jmolenda Date: Tue Sep 22 18:25:44 2015 New Revision: 248343 URL: http://llvm.org/viewvc/llvm-project?rev=248343=rev Log: A small fixup needed for debugserver to work natively on iOS devices; fallout from Vince's cleanups made in r237218 back in May. iOS native lldbs will call

Re: [Lldb-commits] [PATCH] D13066: DWARFASTParserClang::CompleteTypeFromDWARF: Handle incomplete baseclass or child

sivachandra added a comment. I am not sure how portable my Makefile is. I have no idea if it will work on Windows for example. http://reviews.llvm.org/D13066 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r248352 - Use opaque_compiler_type_t in place of void*.

Author: brucem Date: Tue Sep 22 19:18:24 2015 New Revision: 248352 URL: http://llvm.org/viewvc/llvm-project?rev=248352=rev Log: Use opaque_compiler_type_t in place of void*. Reviewers: clayborg Subscribers: lldb-commits Differential Revision: http://reviews.llvm.org/D13060 Modified:

[Lldb-commits] [lldb] r248338 - Move the "run" alias from process launch --shell to process launch --shell-expand-args when building on OS X

Author: enrico Date: Tue Sep 22 17:57:12 2015 New Revision: 248338 URL: http://llvm.org/viewvc/llvm-project?rev=248338=rev Log: Move the "run" alias from process launch --shell to process launch --shell-expand-args when building on OS X The argdumper-based launching is more friendly to System

[Lldb-commits] [lldb] r248339 - Fix a test case which was failing. There was no actual problem in the test logic, just a cosmetic issue with the presentation of the result by Foundation

Author: enrico Date: Tue Sep 22 18:08:13 2015 New Revision: 248339 URL: http://llvm.org/viewvc/llvm-project?rev=248339=rev Log: Fix a test case which was failing. There was no actual problem in the test logic, just a cosmetic issue with the presentation of the result by Foundation Modified:

[Lldb-commits] [lldb] r248285 - Add missing file that contains the curses test suite code. To run with curses you now execute:

Author: gclayton Date: Tue Sep 22 11:29:15 2015 New Revision: 248285 URL: http://llvm.org/viewvc/llvm-project?rev=248285=rev Log: Add missing file that contains the curses test suite code. To run with curses you now execute: % ./dotest.py --results-formatter=curses_results.Curses

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

jaydeep closed this revision. jaydeep added a comment. Closed by commit http://reviews.llvm.org/rL248248 Repository: rL LLVM http://reviews.llvm.org/D12079 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D12877: [LLDB] Switch to assembly view if source is moved

mohit.bhakkad added a comment. Hi Jason, thanks for your suggestions. Yes, this approach looks good and one time warning should be helpful from users view, I will implement it get back with a patch soon. Repository: rL LLVM http://reviews.llvm.org/D12877

Re: [Lldb-commits] [PATCH] D13056: Fix race condition during process detach

labath updated this revision to Diff 35372. labath added a comment. remove some binaries that managed to sneak in http://reviews.llvm.org/D13056 Files: include/lldb/Target/Process.h source/Target/Process.cpp test/functionalities/attach_resume/TestAttachResume.py Index:

[Lldb-commits] [PATCH] D13056: Fix race condition during process detach

labath created this revision. labath added reviewers: jingham, clayborg. labath added a subscriber: lldb-commits. The following situation occured in TestAttachResume: The inferior was stoped at a breakpoint and we did a continue, immediately followed by a detach. Since there was a trap

[Lldb-commits] [PATCH] D13049: execinfo.h isn't needed on Mac OS X for Host.mm.

brucem created this revision. brucem added a reviewer: clayborg. brucem added a subscriber: lldb-commits. This is no longer needed as this file no longer calls backtrace(). http://reviews.llvm.org/D13049 Files: source/Host/macosx/Host.mm Index: source/Host/macosx/Host.mm

[Lldb-commits] [lldb] r248255 - Use fcntl.h to retrieve the O_CREAT and O_RDWR constants.

Author: vkalintiris Date: Tue Sep 22 04:46:35 2015 New Revision: 248255 URL: http://llvm.org/viewvc/llvm-project?rev=248255=rev Log: Use fcntl.h to retrieve the O_CREAT and O_RDWR constants. Summary: Normally, these macros are defined in fnctl.h. However, GLIBC exposes their definition through

Re: [Lldb-commits] [Diffusion] rL248277: [MIPS32] Emulate MSA instructions for MIPS32

tberghammer resigned from this audit. tberghammer added a comment. I committed in a build fix as http://reviews.llvm.org/rL248281 Users: tberghammer (Auditor) http://reviews.llvm.org/rL248277 ___ lldb-commits mailing list

[Lldb-commits] [lldb] r248268 - Remove unused header .

Author: vkalintiris Date: Tue Sep 22 07:43:23 2015 New Revision: 248268 URL: http://llvm.org/viewvc/llvm-project?rev=248268=rev Log: Remove unused header . Modified: lldb/trunk/source/Host/linux/Host.cpp Modified: lldb/trunk/source/Host/linux/Host.cpp URL:

Re: [Lldb-commits] [Diffusion] rL248277: [MIPS32] Emulate MSA instructions for MIPS32

tberghammer added a subscriber: tberghammer. tberghammer raised a concern with this commit. tberghammer added a comment. Hi Sagar, This change break the Linux build (http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/6568) because the register enums have been renamed

[Lldb-commits] [lldb] r248282 - test runner: Unix systems now put inferior dotest in its own process group.

Author: tfiala Date: Tue Sep 22 10:21:50 2015 New Revision: 248282 URL: http://llvm.org/viewvc/llvm-project?rev=248282=rev Log: test runner: Unix systems now put inferior dotest in its own process group. This increases isolation as it relates to signal handling between parent and children.