Re: [Lldb-commits] [PATCH] D14042: Add more NetBSD platform glue for lldb

joerg accepted this revision. joerg added a reviewer: joerg. joerg added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM http://reviews.llvm.org/D14042 ___ lldb-commits mailing list

[Lldb-commits] [lldb] r252390 - Add SBType::IsAnonymousType() and relative plumbing in the debugger internals

Author: enrico Date: Fri Nov 6 20:06:57 2015 New Revision: 252390 URL: http://llvm.org/viewvc/llvm-project?rev=252390=rev Log: Add SBType::IsAnonymousType() and relative plumbing in the debugger internals For language that support such a thing, this API allows to ask whether a type is

[Lldb-commits] [lldb] r252356 - Make the language specifier to "break set" actually filter the names by their language. So for

Author: jingham Date: Fri Nov 6 16:48:59 2015 New Revision: 252356 URL: http://llvm.org/viewvc/llvm-project?rev=252356=rev Log: Make the language specifier to "break set" actually filter the names by their language. So for instance: break set -l c++ -r Name will only break on C++ symbols

[Lldb-commits] [lldb] r252382 - Python 3 - Use __bool__() instead of __nonzero__() for truthiness.

Author: zturner Date: Fri Nov 6 19:08:25 2015 New Revision: 252382 URL: http://llvm.org/viewvc/llvm-project?rev=252382=rev Log: Python 3 - Use __bool__() instead of __nonzero__() for truthiness. Python has a complicated mechanism of checking an objects truthity. This involves a number of steps,

[Lldb-commits] [lldb] r252381 - Python 3 - Don't use unbuffered I/O in text mode.

Author: zturner Date: Fri Nov 6 19:08:15 2015 New Revision: 252381 URL: http://llvm.org/viewvc/llvm-project?rev=252381=rev Log: Python 3 - Don't use unbuffered I/O in text mode. This is unsupported in Python 3. This could also have been fixed by using "wb" instead of "w", but it doesn't seem

[Lldb-commits] [lldb] r252374 - Fix some Clang-tidy warnings and formatting in recently added code.

Author: eugenezelenko Date: Fri Nov 6 18:28:50 2015 New Revision: 252374 URL: http://llvm.org/viewvc/llvm-project?rev=252374=rev Log: Fix some Clang-tidy warnings and formatting in recently added code. Fixed Clang-tidy warnings: * modernize-use-override; * modernize-use-nullptr; *

[Lldb-commits] [PATCH] D14472: Fix TestThreadSpecificBreakpoint.py on Linux after rL252355.

chaoren created this revision. chaoren added reviewers: sivachandra, jingham. chaoren added a subscriber: lldb-commits. On Linux, if a thread-specific conditional breakpoint was hit, it won't necessarily be the thread that hit the breakpoint itself that evaluates the conditional expression, so

Re: [Lldb-commits] [PATCH] D14042: Add more NetBSD platform glue for lldb

emaste accepted this revision. emaste added a comment. Fine by me. I'm not sure how we ended up with the Python-with-semicolons in scripts/buildSwigWrapperClasses.py (prior to this change) though. Repository: rL LLVM http://reviews.llvm.org/D14042

[Lldb-commits] [lldb] r252353 - Fix Linux tests after r252348.

Author: chaoren Date: Fri Nov 6 16:30:30 2015 New Revision: 252353 URL: http://llvm.org/viewvc/llvm-project?rev=252353=rev Log: Fix Linux tests after r252348. Modified: lldb/trunk/packages/Python/lldbsuite/test/dotest.py Modified: lldb/trunk/packages/Python/lldbsuite/test/dotest.py URL:

[Lldb-commits] [lldb] r252378 - lldb/ADT: Remove implicit ilist iterator conversions, NFC

Author: dexonsmith Date: Fri Nov 6 18:54:13 2015 New Revision: 252378 URL: http://llvm.org/viewvc/llvm-project?rev=252378=rev Log: lldb/ADT: Remove implicit ilist iterator conversions, NFC Remove implicit ilist iterator conversions before reapplying r252372 (which will disallow them).

[Lldb-commits] [lldb] r252384 - Remove a debug print statement.

Author: zturner Date: Fri Nov 6 19:12:53 2015 New Revision: 252384 URL: http://llvm.org/viewvc/llvm-project?rev=252384=rev Log: Remove a debug print statement. Modified: lldb/trunk/scripts/Python/modify-python-lldb.py Modified: lldb/trunk/scripts/Python/modify-python-lldb.py URL:

[Lldb-commits] [lldb] r252391 - Fix TestThreadSpecificBreakpoint.py on Linux after rL252355.

Author: chaoren Date: Fri Nov 6 20:16:31 2015 New Revision: 252391 URL: http://llvm.org/viewvc/llvm-project?rev=252391=rev Log: Fix TestThreadSpecificBreakpoint.py on Linux after rL252355. Summary: On Linux, if a thread-specific conditional breakpoint was hit, it won't necessarily be the thread

Re: [Lldb-commits] [PATCH] D14042: Add more NetBSD platform glue for lldb

brucem added a comment. Kamil, please rebase forward and I'll land it. The semicolons in Python are gone now. And so is the need for that block of Python at all. Repository: rL LLVM http://reviews.llvm.org/D14042 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D14417: Make lldb::endian::InlHostByteOrder() private.

This revision was automatically updated to reflect the committed changes. Closed by commit rL252396: Make lldb::endian::InlHostByteOrder() private. (authored by brucem). Changed prior to commit: http://reviews.llvm.org/D14417?vs=39473=39630#toc Repository: rL LLVM

[Lldb-commits] [lldb] r252396 - Make lldb::endian::InlHostByteOrder() private.

Author: brucem Date: Fri Nov 6 22:40:13 2015 New Revision: 252396 URL: http://llvm.org/viewvc/llvm-project?rev=252396=rev Log: Make lldb::endian::InlHostByteOrder() private. Summary: Since this is within the lldb namespace, the compiler tries to export a symbol for it. Unfortunately, since it

Re: [Lldb-commits] [PATCH] D14415: [swig] Simplify check_lldb_swig_executable_file_exists.

This revision was automatically updated to reflect the committed changes. Closed by commit rL252330: [swig] Remove check_lldb_swig_executable_file_exists. (authored by brucem). Changed prior to commit: http://reviews.llvm.org/D14415?vs=39558=39562#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D14406: Don't depend on implementation details of unittest2 for our custom decorators

zturner added a comment. In http://reviews.llvm.org/D14406#283034, @labath wrote: > (The upstream unittest does not seem to have the bugnumber feature. I am > assuming the intention here is to make this upstream compatible, in hope of > moving over there at some point.) I can leave the

[Lldb-commits] [lldb] r252298 - Fix for AArch64 watchpoint cache corruption in case of ptrace failure

Author: omjavaid Date: Fri Nov 6 06:56:34 2015 New Revision: 252298 URL: http://llvm.org/viewvc/llvm-project?rev=252298=rev Log: Fix for AArch64 watchpoint cache corruption in case of ptrace failure Same fix has been submitted for Arm. Review can be found here: Differential revision:

[Lldb-commits] [lldb] r252326 - Don't use module internal implementation details in our decorators.

Author: zturner Date: Fri Nov 6 12:14:42 2015 New Revision: 252326 URL: http://llvm.org/viewvc/llvm-project?rev=252326=rev Log: Don't use module internal implementation details in our decorators. We tried implementing something akin to a conditionalExpectedFailure decorator for unittest2. We

Re: [Lldb-commits] [PATCH] D14406: Don't depend on implementation details of unittest2 for our custom decorators

zturner added inline comments. Comment at: packages/Python/lldbsuite/test/lldbtest.py:605 @@ -611,2 +604,3 @@ if expected_fn(self): -raise case._UnexpectedSuccess(sys.exc_info(), bugnumber) +xfail_func = unittest2.expectedFailure(func)

[Lldb-commits] [PATCH] D14453: Python 3 - Fix some portability issues with class / instance attributes

zturner created this revision. zturner added reviewers: tfiala, labath, tberghammer. zturner added a subscriber: lldb-commits. TBH I'm honestly not sure what the problem was before, or why this fixes it. But what I can tell from debugging is that under Py3, `sortMethodsUsing` is

Re: [Lldb-commits] [PATCH] D14395: Fix some portability issues in unittest2

tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. Looks reasonable. Do we know if it runs anywhere else yet? http://reviews.llvm.org/D14395 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D14415: [swig] Simplify check_lldb_swig_executable_file_exists.

zturner added a comment. Eh, just delete it IMO. I don't like leaving code around "just in case". These scripts already need to be practically re-written (due to not using the standard argparse module), the less work we have to do the better. CMake is the only user of this script as far as

Re: [Lldb-commits] [PATCH] D14395: Fix some portability issues in unittest2

zturner added a comment. I'm probably being dense. But do we know if what runs anywhere else? http://reviews.llvm.org/D14395 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D14415: [swig] Simplify check_lldb_swig_executable_file_exists.

brucem updated this revision to Diff 39558. brucem added a comment. Instead of simplifying, just remove. Expand scope of removal as well. http://reviews.llvm.org/D14415 Files: scripts/Python/buildSwigPython.py scripts/buildSwigWrapperClasses.py Index: scripts/buildSwigWrapperClasses.py

Re: [Lldb-commits] [PATCH] D14415: [swig] Simplify check_lldb_swig_executable_file_exists.

zturner added a comment. If it's never used in practice, can you just delete the codepath entirely? I'm a strong proponent of deleting code that nobody cares about. (Of course, if you found this because you do care about it and this codepath didn't work when you tried to use it, that's a

Re: [Lldb-commits] [PATCH] D14406: Don't depend on implementation details of unittest2 for our custom decorators

tberghammer added a comment. If the purpose of the change to get closer to upstream then I am fine with removing the bug number here. In general I don't feel it is a that high risk change, but I might miss something. http://reviews.llvm.org/D14406

Re: [Lldb-commits] [PATCH] D14415: [swig] Simplify check_lldb_swig_executable_file_exists.

brucem added a comment. Well, I'm pretty sure ... but I don't know if someone in some configuration or set of build arrangements might use it. It might also be used if we ever make the Makefiles or xcode projects use these scripts. http://reviews.llvm.org/D14415

Re: [Lldb-commits] [PATCH] D14163: Address another race condition running tests on Windows

zturner added a comment. Feel free to get this in. Maybe put it in file `lldbsuite/support/filesystem.py` http://reviews.llvm.org/D14163 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D13819: LLDBStandalone: Report nice errors on missing vars

tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. Okay, this seems reasonable. http://reviews.llvm.org/D13819 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D14395: Fix some portability issues in unittest2

tfiala added a comment. I meant I looked at it but didn't try to run it (on Linux or OS X), and was wondering if you had tried to run it on a non-Windows platform. http://reviews.llvm.org/D14395 ___ lldb-commits mailing list

[Lldb-commits] [lldb] r252347 - Python 3 - Use the exec function, not the exec statement.

Author: zturner Date: Fri Nov 6 15:37:21 2015 New Revision: 252347 URL: http://llvm.org/viewvc/llvm-project?rev=252347=rev Log: Python 3 - Use the exec function, not the exec statement. exec statement is gone in Python 3, this version works in both. Modified:

Re: [Lldb-commits] [PATCH] D14395: Fix some portability issues in unittest2

Ahh, no sorry. There's nothing platform specific in the patch though, so I don't anticipate any problems on that front. I did run it under 2.7 and it worked, so I expect it will run under 2.7 on other platforms. On Fri, Nov 6, 2015 at 1:42 PM Todd Fiala wrote: > tfiala

[Lldb-commits] [lldb] r252351 - Fixed a problem where a test case referred to a

Author: spyffe Date: Fri Nov 6 16:05:47 2015 New Revision: 252351 URL: http://llvm.org/viewvc/llvm-project?rev=252351=rev Log: Fixed a problem where a test case referred to a wrongly-capitalized header. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/objc/ivar-IMP/myclass.m