Re: [Lldb-commits] [lldb] r254499 - PTRACE ABI to read FXSAVE area for 32-bit inferior

Hi Tamas Yes, it was a bug in clang that I had submitted some months ago (ID: 23491) and it was fixed. But the fix is not present in clang 3.5/3.6. Hence, the failure is occurring. Thanks & Regards Abhishek Aggarwal From: Tamas Berghammer [mailto:tbergham...@google.com] Sent: Wednesday,

[Lldb-commits] [PATCH] D15152: Change Platform::LoadImage to copy the file to the remote platform

tberghammer created this revision. tberghammer added reviewers: labath, clayborg. tberghammer added a subscriber: lldb-commits. Herald added subscribers: danalbert, tberghammer, emaste. Change Platform::LoadImage to copy the file to the remote platform The new implementation mimic the behavior

Re: [Lldb-commits] [PATCH] D11465: Fix "process load/unload" on android

jingham added a subscriber: jingham. jingham added a comment. It seems like an awful lot of logic is duplicated between the POSIX & Android versions of LoadImage when all that really changes is the name of the function you are calling. Is it possible to centralize this some more? Repository:

Re: [Lldb-commits] [PATCH] D11465: Fix "process load/unload" on android

labath added a subscriber: labath. labath added a comment. In http://reviews.llvm.org/D11465#300581, @jingham wrote: > It seems like an awful lot of logic is duplicated between the POSIX & Android > versions of LoadImage when all that really changes is the name of the > function you are

Re: [Lldb-commits] [PATCH] D15106: [LLDB][MIPS] fix watchpoint searched on client side for same masked variables

This revision was automatically updated to reflect the committed changes. Closed by commit rL254522: [LLDB][MIPS] fix watchpoint searched on client side for same masked variables (authored by mohit.bhakkad). Changed prior to commit: http://reviews.llvm.org/D15106?vs=41486=41644#toc

[Lldb-commits] [lldb] r254530 - Adds candidate formatter for replacing legacy summary results.

Author: tfiala Date: Wed Dec 2 12:48:38 2015 New Revision: 254530 URL: http://llvm.org/viewvc/llvm-project?rev=254530=rev Log: Adds candidate formatter for replacing legacy summary results. Also cleans up some usages of strings where symbolic names were safer and made more sense. Try a test

Re: [Lldb-commits] [PATCH] D13754: Split Socket class into Tcp/Udp/DomainSocket subclasses.

ovyalov closed this revision. ovyalov added a comment. Submitted as r250474 http://reviews.llvm.org/D13754 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [lldb] r254476 - Added support for -gmodule debugging when debug info is left in the .o files on Darwin.

Never mind, top of tree LLDB is working correctly. I ran our Apple built LLDB that had a different version of this -gmodule fix for an Apple specific version we did and it shows the same issue so I was led to believe this existed for a while now, but it is definitely due to the -gmodule patch.

Re: [Lldb-commits] [PATCH] D15152: Change Platform::LoadImage to copy the file to the remote platform

jingham added a subscriber: jingham. jingham added a comment. We use process load to load images that are already extant (and system libraries at that.) So it's got to be possible to load a library into a target process without trying to get the image over to the target. And given how slow

Re: [Lldb-commits] [lldb] r254476 - Added support for -gmodule debugging when debug info is left in the .o files on Darwin.

So the question is why is "S" being found in "std" when we are essentially looking for "::S"?? Do we have a "using namespace std;" in the source? We recently added support for using all of the using directives in the user code so it might be doing a "using namespace std;" into the expression

Re: [Lldb-commits] [lldb] r254476 - Added support for -gmodule debugging when debug info is left in the .o files on Darwin.

So I was able to repro this with the following code: #include #include namespace a { struct S { int s; int ss; }; } int main (int argc, char const *argv[], char const *envp[]) { a::S s = { 11, 22 }; puts("stop here"); // evaluate expression:

[Lldb-commits] [lldb] r254533 - Use sub-commands instead of --mode={client, server}.

Author: zturner Date: Wed Dec 2 13:00:52 2015 New Revision: 254533 URL: http://llvm.org/viewvc/llvm-project?rev=254533=rev Log: Use sub-commands instead of --mode={client,server}. This is more pythonic and allows a more idiomatic way of getting detailed usage information for each individual

Re: [Lldb-commits] [PATCH] D15046: Fix for TestNoreturnUnwind.py on i386

ravitheja added a comment. The reason assembly unwind did not work is because if the ebp register is set to 0 at that time, so the CFA is not available. In the case of clang the frame pointer is not set by any function, which is why the formula does not work. (lldb) image show-unwind -n

[Lldb-commits] [lldb] r254546 - Make --results-file stdout implied if unspecified when using a results formatter.

Author: tfiala Date: Wed Dec 2 15:12:17 2015 New Revision: 254546 URL: http://llvm.org/viewvc/llvm-project?rev=254546=rev Log: Make --results-file stdout implied if unspecified when using a results formatter. Also cleans up pylint warnings (stock settings) in the modified function. Modified:

Re: [Lldb-commits] [PATCH] D15162: Have result formatter send bytes instead of strings

Lgtm -Todd > On Dec 2, 2015, at 2:28 PM, Zachary Turner wrote: > > zturner created this revision. > zturner added a reviewer: tfiala. > zturner added a subscriber: lldb-commits. > > http://reviews.llvm.org/D15162 > > Files: >

Re: [Lldb-commits] [PATCH] D15162: Have result formatter send bytes instead of strings

tfiala added a subscriber: tfiala. tfiala added a comment. Lgtm -Todd http://reviews.llvm.org/D15162 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D15046: Fix for TestNoreturnUnwind.py on i386

jasonmolenda added a comment. Interesting. The routine is 0xf7fd9d70 <+0>: pushl %ecx 0xf7fd9d71 <+1>: pushl %edx 0xf7fd9d72 <+2>: pushl %ebp 0xf7fd9d73 <+3>: movl %esp, %ebp 0xf7fd9d75 <+5>: sysenter [...] 0xf7fd9d7e <+14>: int$0x80 --> 0xf7fd9d80 <+16>: popl %ebp

[Lldb-commits] [PATCH] D15175: Fix breakpoint language filtering for other C variants (like C99) and Pascal.

dawn created this revision. dawn added a reviewer: jingham. dawn added a subscriber: lldb-commits. dawn set the repository for this revision to rL LLVM. This patch fixes setting breakpoints on symbol for variants of C and Pascal where the language is "unknown" within the filtering process added

Re: [Lldb-commits] [PATCH] D12877: [LLDB] Switch to assembly view if source is moved

This revision was automatically updated to reflect the committed changes. Closed by commit rL254588: [LLDB] Switch to assembly view if source is moved (authored by mohit.bhakkad). Changed prior to commit: http://reviews.llvm.org/D12877?vs=38799=41714#toc Repository: rL LLVM

[Lldb-commits] [lldb] r254588 - [LLDB] Switch to assembly view if source is moved

Author: mohit.bhakkad Date: Wed Dec 2 22:56:16 2015 New Revision: 254588 URL: http://llvm.org/viewvc/llvm-project?rev=254588=rev Log: [LLDB] Switch to assembly view if source is moved Reviewers: clayborg, jingham, jasonmolenda. Subscribers: jaydeep, bhushan, sagar, nitesh.jain,lldb-commits.

[Lldb-commits] [lldb] r254590 - [LLDB][MIPS] Using enum instead of a constant to fetch PC and CAUSE registers.

Author: jaydeep Date: Thu Dec 3 00:41:24 2015 New Revision: 254590 URL: http://llvm.org/viewvc/llvm-project?rev=254590=rev Log: [LLDB][MIPS] Using enum instead of a constant to fetch PC and CAUSE registers. SUMMARY: Using enum instead of a constant to fetch PC and CAUSE registers.

[Lldb-commits] [lldb] r254563 - Fix test result serialization to use bytes.

Author: zturner Date: Wed Dec 2 17:07:33 2015 New Revision: 254563 URL: http://llvm.org/viewvc/llvm-project?rev=254563=rev Log: Fix test result serialization to use bytes. Modified: lldb/trunk/packages/Python/lldbsuite/test/dotest_channels.py

Re: [Lldb-commits] [PATCH] D15162: Have result formatter send bytes instead of strings

tfiala added a comment. Okay I also had a chance to run it with the patch locally, and I didn't see any issues. http://reviews.llvm.org/D15162 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r254499 - PTRACE ABI to read FXSAVE area for 32-bit inferior

Author: abhishek Date: Wed Dec 2 03:40:17 2015 New Revision: 254499 URL: http://llvm.org/viewvc/llvm-project?rev=254499=rev Log: PTRACE ABI to read FXSAVE area for 32-bit inferior Summary: - Problem occurs when: -- 32-bit inferiors run on x86_32 machine and the architecture doesn't

[Lldb-commits] [lldb] r254502 - Revert "Added support for -gmodule debugging when debug info is left in the .o files on Darwin."

Author: tberghammer Date: Wed Dec 2 05:35:54 2015 New Revision: 254502 URL: http://llvm.org/viewvc/llvm-project?rev=254502=rev Log: Revert "Added support for -gmodule debugging when debug info is left in the .o files on Darwin." The commit caused a test failure on the linux buildbot in

[Lldb-commits] [lldb] r254504 - Fix "process load/unload" on android

Author: tberghammer Date: Wed Dec 2 05:58:51 2015 New Revision: 254504 URL: http://llvm.org/viewvc/llvm-project?rev=254504=rev Log: Fix "process load/unload" on android On android the symbols exposed by libdl (dlopen, dlclose, dlerror) prefixed by "__dl_". This change moves the handling of

Re: [Lldb-commits] [PATCH] D11465: Fix "process load/unload" on android

This revision was automatically updated to reflect the committed changes. Closed by commit rL254504: Fix "process load/unload" on android (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D11465?vs=41491=41608#toc Repository: rL LLVM http://reviews.llvm.org/D11465

Re: [Lldb-commits] [lldb] r254499 - PTRACE ABI to read FXSAVE area for 32-bit inferior

Hi Abhishek, After this change TestReturnValue.py is failing on Linux with i386 inferior when compiling the inferior with clang-3.5 (it passes with gcc and with ToT clang). I marked the test XFAIL for that specific configuration to get the buildbot green but can you take a look? My suspicion is

[Lldb-commits] [lldb] r254507 - XFAIL TestReturnValue for linux i386 clang 3.5-3.6

Author: tberghammer Date: Wed Dec 2 07:36:17 2015 New Revision: 254507 URL: http://llvm.org/viewvc/llvm-project?rev=254507=rev Log: XFAIL TestReturnValue for linux i386 clang 3.5-3.6 The test failing most likely because clang 3.5 and 3.6 uses an incorrect ABI for returning small structs from a

Re: [Lldb-commits] [PATCH] D12809: Better scheme to lookup alternate mangled name when looking up function address.

sivachandra updated this revision to Diff 41706. sivachandra added a comment. Rebased and updated to take in DWO changes. http://reviews.llvm.org/D12809 Files: include/lldb/Symbol/ClangASTContext.h include/lldb/Symbol/CompilerDeclContext.h include/lldb/Symbol/GoASTContext.h

Re: [Lldb-commits] [PATCH] D12809: Better scheme to lookup alternate mangled name when looking up function address.

sivachandra added a comment. A test for this already exists: TestCallStdStringFunction.py http://reviews.llvm.org/D12809 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D15172: Fix in-memory section loading for JIT-ed code.

ovyalov created this revision. ovyalov added reviewers: clayborg, tberghammer. ovyalov added a subscriber: lldb-commits. Debug sections for JIT-ed code are stored in-memory and loaded as part of module's image once __jit_debug_register_code is called - if we cannot load a section by its base

Re: [Lldb-commits] [PATCH] D12809: Better scheme to lookup alternate mangled name when looking up function address.

sivachandra added a comment. PTaL I finally got time to work on this. I have now rebased it and updated it take in DWO changes. I understand this change only enhances debug experience when GCC is used as the DWARF producer (the targeted functionality already works as expected when the