[Lldb-commits] [lldb] r255584 - Make few adjustments after r255542.

Author: sivachandra Date: Mon Dec 14 18:26:52 2015 New Revision: 255584 URL: http://llvm.org/viewvc/llvm-project?rev=255584=rev Log: Make few adjustments after r255542. Reviewers: zturner Subscribers: lldb-commits Differential Revision: http://reviews.llvm.org/D15511 Modified:

Re: [Lldb-commits] [PATCH] D15511: Make few adjustments after r255542.

This revision was automatically updated to reflect the committed changes. Closed by commit rL255584: Make few adjustments after r255542. (authored by sivachandra). Changed prior to commit: http://reviews.llvm.org/D15511?vs=42796=42802#toc Repository: rL LLVM http://reviews.llvm.org/D15511

Re: [Lldb-commits] [PATCH] D15511: Make few adjustments after r255542.

sivachandra added a comment. I went ahead and committed this. Repository: rL LLVM http://reviews.llvm.org/D15511 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D15482: Welcome to NetBSD signals

krytarowski added inline comments. Comment at: source/Target/UnixSignals.cpp:66 @@ -64,4 +65,3 @@ case llvm::Triple::FreeBSD: case llvm::Triple::OpenBSD: return std::make_shared(); emaste wrote: > Not part of your change, but just

Re: [Lldb-commits] [PATCH] D15482: Welcome to NetBSD signals

krytarowski updated this revision to Diff 42800. krytarowski added a comment. Improve abc order of source files Repository: rL LLVM http://reviews.llvm.org/D15482 Files: source/Plugins/Process/Utility/CMakeLists.txt source/Plugins/Process/Utility/NetBSDSignals.cpp

Re: [Lldb-commits] [PATCH] D15511: Make few adjustments after r255542.

tfiala added a comment. Yep this fixed the issues I was having on OS X with the related change. Thanks, Siva! Repository: rL LLVM http://reviews.llvm.org/D15511 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [lldb] r255542 - Make skipIf decorator support not_in() functor.

This change looks very innocent, but: On Mon, Dec 14, 2015 at 1:26 PM, Zachary Turner via lldb-commits wrote: > URL: > http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py?rev=255542=255541=255542=diff >

[Lldb-commits] [lldb] r255590 - When constructing an address range to "step" or "next" through,

Author: jmolenda Date: Mon Dec 14 18:40:30 2015 New Revision: 255590 URL: http://llvm.org/viewvc/llvm-project?rev=255590=rev Log: When constructing an address range to "step" or "next" through, find the largest address range (possibly combining multiple LineEntry's for this line number) that is

Re: [Lldb-commits] [lldb] r255542 - Make skipIf decorator support not_in() functor.

On Mon, Dec 14, 2015 at 4:10 PM Siva Chandra wrote: > This change looks very innocent, but: > > On Mon, Dec 14, 2015 at 1:26 PM, Zachary Turner via lldb-commits > wrote: > > URL: >

Re: [Lldb-commits] [lldb] r255603 - Fix a bug where language categories would hold on to their caches even after changes

It’s a hard unit test to write though I caught this because I deleted a formatter in a language category and saw it still applied Problem is that you can’t add new formatters or add back previously deleted formatters to a language category, and the FormatManager is global state, so a deletion

Re: [Lldb-commits] [lldb] r255592 - Welcome to NetBSD signals

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Sorry, only NetBSD around :-) (I'm ok to port xcode to it, perhaps it might run with the Darwin compat layer..) Thanks for fixing xcode. I'm planning to land more NetBSD platform parts in the following days. Keep tuned and thank you! On

[Lldb-commits] [lldb] r255598 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in some files in source/Target/.

Author: eugenezelenko Date: Mon Dec 14 19:33:19 2015 New Revision: 255598 URL: http://llvm.org/viewvc/llvm-project?rev=255598=rev Log: Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in some files in source/Target/. Simplify smart pointers checks in

[Lldb-commits] [lldb] r255581 - test infra: catch and print exception info on test runner socket listener

Author: tfiala Date: Mon Dec 14 17:45:38 2015 New Revision: 255581 URL: http://llvm.org/viewvc/llvm-project?rev=255581=rev Log: test infra: catch and print exception info on test runner socket listener This is the listener's spawned connection, not the listener itself. (i.e. this is the test

Re: [Lldb-commits] [PATCH] D15482: Welcome to NetBSD signals

krytarowski added a comment. Thank you. After fixing the order I'm going to land this diff. Comment at: source/Plugins/Process/Utility/CMakeLists.txt:6 @@ -5,2 +5,3 @@ FreeBSDSignals.cpp + NetBSDSignals.cpp GDBRemoteSignals.cpp emaste wrote: > Should

[Lldb-commits] [PATCH] D15511: Make few adjustments after r255542.

sivachandra created this revision. sivachandra added a reviewer: zturner. sivachandra added a subscriber: lldb-commits. http://reviews.llvm.org/D15511 Files: packages/Python/lldbsuite/test/lldbtest.py Index: packages/Python/lldbsuite/test/lldbtest.py

Re: [Lldb-commits] [PATCH] D15407: When stepping in/over source lines, combine the addr ranges of all line table entries w/ same line num

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. That looks fine. http://reviews.llvm.org/D15407 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r255592 - Welcome to NetBSD signals

Author: kamil Date: Mon Dec 14 18:50:19 2015 New Revision: 255592 URL: http://llvm.org/viewvc/llvm-project?rev=255592=rev Log: Welcome to NetBSD signals Summary: Signals 1-32 are matching the default UNIX platform. There are platform specific ones above 32. From the `/usr/include/sys/signal.h`

Re: [Lldb-commits] [lldb] r255598 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in some files in source/Target/.

I see the value of replacing NULL with nullptr, but I don't see the value of these sorts of changes: > On Dec 14, 2015, at 5:33 PM, Eugene Zelenko via lldb-commits > wrote: > > @@ -118,19 +111,13 @@ ThreadPlanStepInstruction::IsPlanStale ( > StackID

Re: [Lldb-commits] [PATCH] D15511: Make few adjustments after r255542.

zturner added inline comments. Comment at: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py:622 @@ -621,3 +621,3 @@ return list_or_lambda(value) -elif isinstance(list_or_lambda, list): -return list_or_lambda is None or value is None or value in

Re: [Lldb-commits] [lldb] r255592 - Welcome to NetBSD signals

Ah, yes! Thank you. On Mon, Dec 14, 2015 at 6:41 PM, Jim Ingham wrote: > I think Jason already did (r255597). > > Jim > >> On Dec 14, 2015, at 6:35 PM, Siva Chandra via lldb-commits >> wrote: >> >> On Mon, Dec 14, 2015 at 4:50 PM, Kamil

Re: [Lldb-commits] [PATCH] D15312: Fix scope-based lookup when more than one function is found.

labath added a subscriber: labath. labath added a comment. Hi, all of the new tests in TestNamespaceLookup were failing on linux, against all tested compilers (http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/9405), so I have XFAILed them. I don't know if this is

Re: [Lldb-commits] [PATCH] D15357: Update code to silent some ARM/ARM64 specific compiler warnings

omjavaid abandoned this revision. omjavaid added a comment. Let the warnings stay for now. http://reviews.llvm.org/D15357 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D15355: Add failure paths to a few JSONNumber members

omjavaid abandoned this revision. omjavaid added a comment. Correction made upstream by @tberghammer. http://reviews.llvm.org/D15355 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D15488: [LLDB][MIPS] Mark TestConcurrentEvents.py expected failure, as MIPS atomic sequences are yet to be supported in LLDB

jaydeep accepted this revision. jaydeep added a comment. This revision is now accepted and ready to land. Looks good to me. Repository: rL LLVM http://reviews.llvm.org/D15488 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r255490 - XFAIL TestNamespaceLookup for linux

Author: labath Date: Mon Dec 14 05:05:44 2015 New Revision: 255490 URL: http://llvm.org/viewvc/llvm-project?rev=255490=rev Log: XFAIL TestNamespaceLookup for linux Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/namespace/TestNamespaceLookup.py Modified:

[Lldb-commits] [lldb] r255488 - [LLDB][MIPS] Mark TestConcurrentEvents.py expected failure, as MIPS atomic sequences are yet to be supported in LLDB

Author: mohit.bhakkad Date: Mon Dec 14 04:26:18 2015 New Revision: 255488 URL: http://llvm.org/viewvc/llvm-project?rev=255488=rev Log: [LLDB][MIPS] Mark TestConcurrentEvents.py expected failure, as MIPS atomic sequences are yet to be supported in LLDB Reviewers: jaydeep. Subscribers:

Re: [Lldb-commits] [PATCH] D15451: Make test categories composable

tberghammer added inline comments. Comment at: packages/Python/lldbsuite/test/lldbtest.py:518 @@ +517,3 @@ +if hasattr(func, "categories"): +cat.extend(func.categories) +func.categories = cat tfiala wrote: > This code could potentially

Re: [Lldb-commits] [PATCH] D15437: Read macro info from .debug_macro section and use it for expression evaluation.

tberghammer added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugMacro.cpp:38-41 @@ +37,6 @@ + +if (flags & OPCODE_OPERANDS_TABLE_MASK) +{ +OperandTable::ReadOperandTable(debug_macro_data, offset, _operand_table); +} +

[Lldb-commits] [lldb] r255619 - [LLDB][MIPS] Added support for MIPS1, MIPS2, MIPS3, MIPS4 and MIPS5 instruction sets

Author: slthakur Date: Mon Dec 14 23:50:55 2015 New Revision: 255619 URL: http://llvm.org/viewvc/llvm-project?rev=255619=rev Log: [LLDB][MIPS] Added support for MIPS1, MIPS2, MIPS3, MIPS4 and MIPS5 instruction sets Patch by Nitesh Jain. Summary: This Patch will allowed LLDB to debug respective

Re: [Lldb-commits] [PATCH] D15482: Welcome to NetBSD signals

emaste added inline comments. Comment at: source/Plugins/Process/Utility/CMakeLists.txt:6 @@ -5,2 +5,3 @@ FreeBSDSignals.cpp + NetBSDSignals.cpp GDBRemoteSignals.cpp Should keep these in alpha order Comment at:

[Lldb-commits] [PATCH] D15498: Merge ENABLE_THREADS and ENABLE_STD_THREADS markers

tberghammer created this revision. tberghammer added reviewers: labath, zturner. tberghammer added a subscriber: lldb-commits. Herald added subscribers: danalbert, tberghammer. Merge ENABLE_THREADS and ENABLE_STD_THREADS markers Both of these markers are used in the test suit for annotating when

Re: [Lldb-commits] [lldb] r255603 - Fix a bug where language categories would hold on to their caches even after changes

All of these things are theoretically possible (i.e. They can be done by writing enough code :-), but I would love if there were a real feature driver for them before I sit down and write said code. The most interesting avenue is making the FormatManager be a per-debugger entity instead of a

Re: [Lldb-commits] [PATCH] D15511: Make few adjustments after r255542.

I tried to google the semantics of the in keyword, but Python documentation is so horrible. I literally couldn't find a description of how it works :-/ Anyway, thanks! On Mon, Dec 14, 2015 at 7:27 PM Todd Fiala wrote: > This seems right: > > python > Python 2.7.10

Re: [Lldb-commits] [PATCH] D15511: Make few adjustments after r255542.

This seems right: python Python 2.7.10 (default, Oct 23 2015, 18:05:06) [GCC 4.2.1 Compatible Apple LLVM 7.0.0 (clang-700.0.59.5)] on darwin Type "help", "copyright", "credits" or "license" for more information. >>> s = 'abc' >>> 'bc' in 'abc' True >>> 'bc' in s True >>> 'clang' in 'clang' True

Re: [Lldb-commits] [PATCH] D15482: Welcome to NetBSD signals

joerg accepted this revision. joerg added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM http://reviews.llvm.org/D15482 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D15451: Make test categories composable

This revision was automatically updated to reflect the committed changes. Closed by commit rL255493: Make test categories composable (authored by labath). Changed prior to commit: http://reviews.llvm.org/D15451?vs=42522=42704#toc Repository: rL LLVM http://reviews.llvm.org/D15451 Files:

Re: [Lldb-commits] [PATCH] D15428: Make debug info specification use categories system

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In http://reviews.llvm.org/D15428#308401, @zturner wrote: > In hindsight I wonder if I even needed to manually mark the test with a debug > info. Maybe we can say that tests should *never*

[Lldb-commits] [lldb] r255499 - Add failure paths to a few JSONNumber members

Author: omjavaid Date: Mon Dec 14 08:52:07 2015 New Revision: 255499 URL: http://llvm.org/viewvc/llvm-project?rev=255499=rev Log: Add failure paths to a few JSONNumber members Differential revision: http://reviews.llvm.org/D15355 Modified: lldb/trunk/include/lldb/Utility/JSON.h

Re: [Lldb-commits] [PATCH] D15355: Add failure paths to a few JSONNumber members

This revision was automatically updated to reflect the committed changes. Closed by commit rL255499: Add failure paths to a few JSONNumber members (authored by omjavaid). Changed prior to commit: http://reviews.llvm.org/D15355?vs=42706=42712#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D15451: Make test categories composable

tberghammer added inline comments. Comment at: packages/Python/lldbsuite/test/lldbtest.py:518 @@ +517,3 @@ +if hasattr(func, "categories"): +cat.extend(func.categories) +func.categories = cat labath wrote: > tberghammer wrote: > >

Re: [Lldb-commits] [PATCH] D15498: Merge ENABLE_THREADS and ENABLE_STD_THREADS markers

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks like a nice simplification. http://reviews.llvm.org/D15498 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r255543 - test infra: enable single-worker rerun phase for flakey tests.

Author: tfiala Date: Mon Dec 14 15:28:46 2015 New Revision: 255543 URL: http://llvm.org/viewvc/llvm-project?rev=255543=rev Log: test infra: enable single-worker rerun phase for flakey tests. Use of --rerun-all-issues will enable any test method failure, not just test methods marked with the

[Lldb-commits] [lldb] r255547 - Correction in TestFrames.py test for arm targets in thumb mode

Author: omjavaid Date: Mon Dec 14 15:41:18 2015 New Revision: 255547 URL: http://llvm.org/viewvc/llvm-project?rev=255547=rev Log: Correction in TestFrames.py test for arm targets in thumb mode Differential revision: http://reviews.llvm.org/D15061 Modified:

Re: [Lldb-commits] [PATCH] D15061: Correction in TestFrames.py test for arm targets in thumb mode

This revision was automatically updated to reflect the committed changes. Closed by commit rL255547: Correction in TestFrames.py test for arm targets in thumb mode (authored by omjavaid). Changed prior to commit: http://reviews.llvm.org/D15061?vs=41359=42765#toc Repository: rL LLVM

[Lldb-commits] [lldb] r255548 - [Editline] Redesign automatic indentation fix command for robustness

Author: kate Date: Mon Dec 14 15:43:59 2015 New Revision: 255548 URL: http://llvm.org/viewvc/llvm-project?rev=255548=rev Log: [Editline] Redesign automatic indentation fix command for robustness The FixIndentationCommand implementation has proven to be fragile across various libedit iterations.

[Lldb-commits] [lldb] r255549 - Temporarily skip TestWithLimitDebugInfo on Darwin and OS X

Author: tfiala Date: Mon Dec 14 15:49:39 2015 New Revision: 255549 URL: http://llvm.org/viewvc/llvm-project?rev=255549=rev Log: Temporarily skip TestWithLimitDebugInfo on Darwin and OS X This test is erroring out on a sequence call to a function. Modified:

Re: [Lldb-commits] [lldb] r255549 - Temporarily skip TestWithLimitDebugInfo on Darwin and OS X

I believe zturner already fixed this. However, there is a problem with his original change itself; will bring it up in a different thread. On Mon, Dec 14, 2015 at 1:49 PM, Todd Fiala via lldb-commits wrote: > Author: tfiala > Date: Mon Dec 14 15:49:39 2015 > New

Re: [Lldb-commits] [lldb] r255525 - Make debug info specification use categories system.

Hi Zachary, This change broke TestLimitDebugInfo with the following error message(copied from the Linux buildbot): == ERROR: test_limit_debug_info_dwarf (TestWithLimitDebugInfo.TestWithLimitDebugInfo)

Re: [Lldb-commits] [PATCH] D15355: Add failure paths to a few JSONNumber members

tberghammer added a comment. I don't know what correction you are referring to as I haven't made any change in JSON.{h,cpp} since you created this patch but I am happy with the current situation (no warning on clang) http://reviews.llvm.org/D15355

Re: [Lldb-commits] [PATCH] D15437: Read macro info from .debug_macro section and use it for expression evaluation.

sivachandra updated this revision to Diff 42754. sivachandra marked 2 inline comments as done. sivachandra added a comment. Remove storing of an unused data structure. http://reviews.llvm.org/D15437 Files: include/lldb/Symbol/CompileUnit.h include/lldb/Symbol/DebugMacros.h

Re: [Lldb-commits] [PATCH] D15428: Make debug info specification use categories system

This revision was automatically updated to reflect the committed changes. Closed by commit rL255525: Make debug info specification use categories system. (authored by zturner). Changed prior to commit: http://reviews.llvm.org/D15428?vs=42550=42739#toc Repository: rL LLVM

Re: [Lldb-commits] [lldb] r255525 - Make debug info specification use categories system.

On Mon, Dec 14, 2015 at 10:49 AM, Zachary Turner via lldb-commits wrote: > Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py > URL: > http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py?rev=255525=255524=255525=diff

Re: [Lldb-commits] [lldb] r255525 - Make debug info specification use categories system.

The previous code was just an unrolled loop as far as I can tell. Do you mean the loop has different behavior than the unrolled loop? Because it looks identical to me (although admittedly python has a lot of nuances that I don't understand in great detail) On Mon, Dec 14, 2015 at 1:59 PM Siva

Re: [Lldb-commits] [lldb] r255549 - Temporarily skip TestWithLimitDebugInfo on Darwin and OS X

Looks like, though that particular test was "fixed", zturner's change triggered a whole bunch of other failures: http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/9446 On Mon, Dec 14, 2015 at 1:56 PM, Siva Chandra wrote: > I believe zturner already

[Lldb-commits] [lldb] r255557 - Revert "Temporarily skip TestWithLimitDebugInfo on Darwin and OS X"

Author: tfiala Date: Mon Dec 14 16:04:20 2015 New Revision: 27 URL: http://llvm.org/viewvc/llvm-project?rev=27=rev Log: Revert "Temporarily skip TestWithLimitDebugInfo on Darwin and OS X" This reverts commit 30ed0826a1bb800454088ea1ae16c113a69b92b1. Modified:

Re: [Lldb-commits] [lldb] r255525 - Make debug info specification use categories system.

Previously, self.debug_info was under different functions (dwarf_test_method, dwo_test_method etc.). Now, they are all under test_method. Even I am equally ignorant about the Python nuances here. On Mon, Dec 14, 2015 at 2:04 PM, Zachary Turner wrote: > The previous code was

Re: [Lldb-commits] [lldb] r255525 - Make debug info specification use categories system.

On Mon, Dec 14, 2015 at 2:15 PM, Zachary Turner wrote: > Diff looks like this: > > -@dwarf_test > -@wraps(attrvalue) > -def dwarf_test_method(self, attrvalue=attrvalue): > -self.debug_info = "dwarf" > -

Re: [Lldb-commits] [PATCH] D15437: Read macro info from .debug_macro section and use it for expression evaluation.

sivachandra updated this revision to Diff 42758. sivachandra added a comment. Use std::unordered_map instead of std::map. http://reviews.llvm.org/D15437 Files: include/lldb/Symbol/CompileUnit.h include/lldb/Symbol/DebugMacros.h include/lldb/Symbol/SymbolFile.h

Re: [Lldb-commits] [lldb] r255525 - Make debug info specification use categories system.

Sure, sorry about that On Mon, Dec 14, 2015 at 11:52 AM Tamas Berghammer wrote: > Hi Zachary, > > This change broke TestLimitDebugInfo with the following error > message(copied from the Linux buildbot): >

Re: [Lldb-commits] [PATCH] D15487: [LLDB][MIPS] Added support for MIPS1, MIPS2, MIPS3, MIPS4 and MIPS5 instruction sets

jaydeep accepted this revision. jaydeep added a comment. This revision is now accepted and ready to land. Looks good to me. Repository: rL LLVM http://reviews.llvm.org/D15487 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r255567 - Remove the multiplier loop.

Author: zturner Date: Mon Dec 14 16:58:16 2015 New Revision: 255567 URL: http://llvm.org/viewvc/llvm-project?rev=255567=rev Log: Remove the multiplier loop. This is leading to some kind of subtle issue related to local functions and closures, so let's just go back to the old way for now.

Re: [Lldb-commits] [lldb] r255525 - Make debug info specification use categories system.

Alright, I'll revert this loop for now. This is in at r255567. On Mon, Dec 14, 2015 at 2:33 PM Siva Chandra wrote: > On Mon, Dec 14, 2015 at 2:15 PM, Zachary Turner > wrote: > > Diff looks like this: > > > > -@dwarf_test > > -

[Lldb-commits] [lldb] r255568 - [Test] Addresses failing test when path to make contains spaces

Author: kate Date: Mon Dec 14 16:59:26 2015 New Revision: 255568 URL: http://llvm.org/viewvc/llvm-project?rev=255568=rev Log: [Test] Addresses failing test when path to make contains spaces Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/load_unload/a.mk Modified: