[Lldb-commits] [lldb] r266361 - Fix Xcode project after recent s390x changes.

Author: gclayton Date: Thu Apr 14 15:05:21 2016 New Revision: 266361 URL: http://llvm.org/viewvc/llvm-project?rev=266361=rev Log: Fix Xcode project after recent s390x changes. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

Re: [Lldb-commits] [PATCH] D19092: Fix Android build after r266267

labath added a subscriber: labath. labath added a comment. Judging by the cryptic error message, and the fact that a global variable should not cause an issue, i suspect stdout was a macro in this case... http://reviews.llvm.org/D19092 ___

Re: [Lldb-commits] [PATCH] D19086: [clang-analyzer] fix warnings emitted on lldb code base

apelete marked 2 inline comments as done. apelete added a comment. http://reviews.llvm.org/D19086 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D19122: LLDB: Fixed race condition on timeout when stopping private state thread

clayborg added a comment. agreed Repository: rL LLVM http://reviews.llvm.org/D19122 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D19114: [test] Relax stderr expectations on targets with chatty output

srhines added inline comments. Comment at: packages/Python/lldbsuite/test/lldbplatformutil.py:142 @@ +141,3 @@ +def hasChattyStderr(test_case): +"""Some targets produce garbage on the standard error output. This utility function +determines whether the tests can be

Re: [Lldb-commits] [PATCH] D19122: LLDB: Fixed race condition on timeout when stopping private state thread

At the Command & SB API level, we restrict access to the process from multiple threads with the run lock. But internally it is currently more of a gentleman's agreement not to do this. I don't think it would ever be useful to try to make calling functions in the target (which is the job of

Re: [Lldb-commits] [PATCH] D19122: LLDB: Fixed race condition on timeout when stopping private state thread

jingham added a subscriber: jingham. jingham added a comment. At the Command & SB API level, we restrict access to the process from multiple threads with the run lock. But internally it is currently more of a gentleman's agreement not to do this. I don't think it would ever be useful to try

[Lldb-commits] [lldb] r266384 - Don't disable stdin buffering on Windows

Author: amccarth Date: Thu Apr 14 18:31:17 2016 New Revision: 266384 URL: http://llvm.org/viewvc/llvm-project?rev=266384=rev Log: Don't disable stdin buffering on Windows Disabling buffering exposes a bug in the MS VS 2015 CRT implementation of fgets, where you sometimes have to hit Enter

Re: [Lldb-commits] [PATCH] D19122: LLDB: Fixed race condition on timeout when stopping private state thread

cameron314 added inline comments. Comment at: source/Target/Process.cpp:4116 @@ -4120,1 +4115,3 @@ +// Signal the private state thread +if (m_private_state_thread.IsJoinable()) { clayborg wrote: > If you are going to do IsJoinable(), Cancel(), and

Re: [Lldb-commits] [PATCH] D19122: LLDB: Fixed race condition on timeout when stopping private state thread

clayborg added a comment. from the C++ docs: > All member functions (including copy constructor and copy assignment) can be > called by multiple threads on different instances of shared_ptr without > additional synchronization even if these instances are copies and share > ownership of the

Re: [Lldb-commits] [PATCH] D19122: LLDB: Fixed race condition on timeout when stopping private state thread

cameron314 added a comment. I read the same docs :D This is the important part: > If multiple threads of execution access the same shared_ptr without > synchronization and any of those accesses uses a non-const member function of > shared_ptr then a data race will occur; the shared_ptr

Re: [Lldb-commits] [PATCH] D19122: LLDB: Fixed race condition on timeout when stopping private state thread

cameron314 added a comment. OK, I'll pare down the patch to just that line then. I found the reason for the time out. At the end of our debug session, we destroy the Target, which destroys the process. Process::Destroy in turn calls Process::Detach, which calls DoDetach just before calling

Re: [Lldb-commits] [PATCH] D19122: LLDB: Fixed race condition on timeout when stopping private state thread

clayborg added a comment. > I think the real bug is in StopPrivateStateThread, which only sends the stop > state if the thread is still joinable; since I removed the Reset, it is of > course still joinable after it exits. But even with the Reset (which we agree > shouldn't be there), there is

Re: [Lldb-commits] [PATCH] D18848: Add PDBASTParser and parse type information from PDB

zturner updated this revision to Diff 53780. zturner added a comment. Generated the wrong patch last time. This one should be good http://reviews.llvm.org/D18848 Files: include/lldb/Symbol/ClangASTContext.h source/Plugins/SymbolFile/PDB/CMakeLists.txt

Re: [Lldb-commits] [PATCH] D19122: LLDB: Fixed race condition on timeout when stopping private state thread

clayborg added a comment. HostThread::Reset() is a bad function and should not be directly used by anyone other that Join() or Detach(). Just clearing the thread ID and setting the result to zero is bad and means we will leak a thread if no one else joins it. If someone else already called

Re: [Lldb-commits] [PATCH] D19136: Don't disable stdin and stdout buffering on Windows

zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. I think you can probably leave buffering turned off for stdout and only do this change for stdin unless we find some other bug. AFAIK the problem is confined to stdin. I'd probably leave

Re: [Lldb-commits] [PATCH] D18978: Support Linux on SystemZ as platform

Ulrich Weigand/Germany/IBM wrote on 14.04.2016 18:20:20: > So there seem to be at least two different issues, looking at the build bot > logs. After the main SystemZ patch went it, there was just a single > failure, a timeout on the new s390x.core test. I guess we can just disable > that test

Re: [Lldb-commits] [PATCH] D18848: Add PDBASTParser and parse type information from PDB

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Sounds good. Lets start with this and add on as needed. http://reviews.llvm.org/D18848 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D19122: LLDB: Fixed race condition on timeout when stopping private state thread

cameron314 added a comment. Hmm, interesting. Yes, it should not be timing out in the first place. That's likely a bug on our side, still to be determined. I'm looking into it. Regardless, it led us to find and fix this race :-) I think it still makes sense for LLDB to do a `Cancel()` as a

Re: [Lldb-commits] [PATCH] D19122: LLDB: Fixed race condition on timeout when stopping private state thread

clayborg added a comment. We should figure out what is going wrong on your system though and figure out why we need to call Cancel() as well. Repository: rL LLVM http://reviews.llvm.org/D19122 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D19122: LLDB: Fixed race condition on timeout when stopping private state thread

cameron314 added a comment. Ooh, that might work. But when ControlProvateStateThread resets m_private_state_control_wait to false there's still a race between that and the thread exiting. It could then be set back to false even after the thread has exited (this is even likely for a detach). I

Re: [Lldb-commits] [PATCH] D19122: LLDB: Fixed race condition on timeout when stopping private state thread

cameron314 added a comment. Note also that using a copy of the instance variable is no different from using the instance variable directly, here, since as you say they both have a shared pointer to the same underlying object which is manipulated through either of the two to the same effect.

Re: [Lldb-commits] [PATCH] D18848: Add PDBASTParser and parse type information from PDB

clayborg added a comment. So you will need to make up base types if you have any types that use them. Like if a struct contains an "int", you will need to make an integer up and feed it to your CXXRecordDecl. So you will probably need to add those functions back. You will need them for: -

Re: [Lldb-commits] [PATCH] D18848: Add PDBASTParser and parse type information from PDB

zturner added a comment. That should be fine, but as long as I don't have to create a `TypeSP` for it when someone calls `FindTypes`, which is the only thing I'm implementing here, I think I should be ok. When I go to create `CXXRecordDecls` to complete class types, or when I add support for

[Lldb-commits] [PATCH] D19136: Don't disable stdin and stdout buffering on Windows

amccarth created this revision. amccarth added a reviewer: zturner. amccarth added a subscriber: lldb-commits. Disabling buffering exposes a bug in the MS VS 2015 CRT implementation of fgets, where you sometimes have to hit Enter twice, depending on if the input had an odd or even number of

Re: [Lldb-commits] [PATCH] D19136: Don't disable stdin and stdout buffering on Windows

amccarth added a comment. In http://reviews.llvm.org/D19136#401888, @zturner wrote: > I think you can probably leave buffering turned off for stdout and only do > this change for stdin unless we find some other bug. AFAIK the problem is > confined to stdin. I'd probably leave a comment in

[Lldb-commits] [lldb] r266389 - Added a testcase for defining and using a block in the expression parser.

Author: spyffe Date: Thu Apr 14 19:05:50 2016 New Revision: 266389 URL: http://llvm.org/viewvc/llvm-project?rev=266389=rev Log: Added a testcase for defining and using a block in the expression parser. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/c/blocks/TestBlocks.py

[Lldb-commits] [lldb] r266392 - Initial support for reading type information from PDBs.

Author: zturner Date: Thu Apr 14 19:21:26 2016 New Revision: 266392 URL: http://llvm.org/viewvc/llvm-project?rev=266392=rev Log: Initial support for reading type information from PDBs. This implements a PDBASTParser and corresponding logic in SymbolFilePDB to do type lookup by name. This is

[Lldb-commits] [lldb] r266401 - Rename out->std_out in AppleObjCRuntimeV2.cpp.

Author: ovyalov Date: Thu Apr 14 19:56:11 2016 New Revision: 266401 URL: http://llvm.org/viewvc/llvm-project?rev=266401=rev Log: Rename out->std_out in AppleObjCRuntimeV2.cpp. Modified: lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp Modified:

[Lldb-commits] [lldb] r266397 - Added a testcase for defining and using lambdas in the expression parser.

Author: spyffe Date: Thu Apr 14 19:26:32 2016 New Revision: 266397 URL: http://llvm.org/viewvc/llvm-project?rev=266397=rev Log: Added a testcase for defining and using lambdas in the expression parser. Added: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/lambdas/

Re: [Lldb-commits] [PATCH] D18848: Add PDBASTParser and parse type information from PDB

A new file was added, Greg or someone else at Apple may need to add it to the Xcode workspace On Thu, Apr 14, 2016 at 6:26 PM Vedant Kumar wrote: > vsk added a subscriber: vsk. > vsk added a comment. > > Hi @zturner, this seems to have upset an lldb bot. Could you take a look ( >

Re: [Lldb-commits] [PATCH] D18848: Add PDBASTParser and parse type information from PDB

zturner added a comment. A new file was added, Greg or someone else at Apple may need to add it to the Xcode workspace http://reviews.llvm.org/D18848 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r266400 - Blocks are only reliably supported on Darwin. Disable the test otherwise.

Author: spyffe Date: Thu Apr 14 19:44:59 2016 New Revision: 266400 URL: http://llvm.org/viewvc/llvm-project?rev=266400=rev Log: Blocks are only reliably supported on Darwin. Disable the test otherwise. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/c/blocks/TestBlocks.py

Re: [Lldb-commits] [PATCH] D18848: Add PDBASTParser and parse type information from PDB

jingham added a subscriber: jingham. jingham added a comment. Done in r266407. It built for me after this. Jim http://reviews.llvm.org/D18848 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D18848: Add PDBASTParser and parse type information from PDB

Done in r266407. It built for me after this. Jim > On Apr 14, 2016, at 6:34 PM, Zachary Turner via lldb-commits > wrote: > > zturner added a comment. > > A new file was added, Greg or someone else at Apple may need to add it to > the Xcode workspace > > >

[Lldb-commits] [lldb] r266407 - Add the PDBParser.{cpp, h} files to the Xcode project.

Author: jingham Date: Thu Apr 14 20:42:30 2016 New Revision: 266407 URL: http://llvm.org/viewvc/llvm-project?rev=266407=rev Log: Add the PDBParser.{cpp,h} files to the Xcode project. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

Re: [Lldb-commits] [PATCH] D19067: Make sure to use lib instead of lib64 for LLDB_LIB_DIR

labath added a subscriber: labath. labath added a comment. Actually, the destination for liblldb.so depends on the LLVM_LIBDIR_SUFFIX cmake variable. If you're on a system which likes to shove things into lib64, maybe you could follow suit and define the variable when you build llvm/lldb.

Re: [Lldb-commits] [PATCH] D18978: Support Linux on SystemZ as platform

labath accepted this revision. labath added a comment. That's perfect, thanks a lot. :) Do you have commit access? If not, let me know when you're ready to start landing these things... http://reviews.llvm.org/D18978 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D18981: Fix usage of APInt.getRawData for big-endian systems

labath accepted this revision. labath added a comment. I am glad that the unit tests are finding real problems and not just being a nuisance. Thanks a lot. Comment at: source/Core/Scalar.cpp:2655 @@ -2654,3 +2656,3 @@ int128.x[1] = (uint64_t)data.GetU64

Re: [Lldb-commits] [PATCH] D19060: FileSpec: make matching separator-agnostic again

This revision was automatically updated to reflect the committed changes. Closed by commit rL266286: FileSpec: make matching separator-agnostic again (authored by labath). Changed prior to commit: http://reviews.llvm.org/D19060?vs=53567=53680#toc Repository: rL LLVM

[Lldb-commits] [lldb] r266286 - FileSpec: make matching separator-agnostic again

Author: labath Date: Thu Apr 14 04:38:06 2016 New Revision: 266286 URL: http://llvm.org/viewvc/llvm-project?rev=266286=rev Log: FileSpec: make matching separator-agnostic again Summary: In D18689, I removed the call to Normalize() in FileSpec::SetFile, because it no longer seemed needed, and it

[Lldb-commits] [lldb] r266309 - Fixes for platforms that default to unsigned char

Author: uweigand Date: Thu Apr 14 09:30:12 2016 New Revision: 266309 URL: http://llvm.org/viewvc/llvm-project?rev=266309=rev Log: Fixes for platforms that default to unsigned char This fixes several test case failure on s390x caused by the fact that on this platform, the default "char" type is

Re: [Lldb-commits] [PATCH] D18981: Fix usage of APInt.getRawData for big-endian systems

This revision was automatically updated to reflect the committed changes. Closed by commit rL266311: Fix usage of APInt.getRawData for big-endian systems (authored by uweigand). Changed prior to commit: http://reviews.llvm.org/D18981?vs=53622=53710#toc Repository: rL LLVM

[Lldb-commits] [lldb] r266311 - Fix usage of APInt.getRawData for big-endian systems

Author: uweigand Date: Thu Apr 14 09:32:01 2016 New Revision: 266311 URL: http://llvm.org/viewvc/llvm-project?rev=266311=rev Log: Fix usage of APInt.getRawData for big-endian systems The Scalar implementation and a few other places in LLDB directly access the internal implementation of APInt

[Lldb-commits] [PATCH] D19114: [test] Relax stderr expectations on targets with chatty output

labath created this revision. labath added reviewers: tfiala, ovyalov. labath added a subscriber: lldb-commits. Herald added subscribers: srhines, danalbert, tberghammer. On some android targets, a binary can produce additional garbage (e.g. warning messages from the dynamic linker) on the

[Lldb-commits] [lldb] r266312 - Handle bit fields on big-endian systems correctly

Author: uweigand Date: Thu Apr 14 09:32:57 2016 New Revision: 266312 URL: http://llvm.org/viewvc/llvm-project?rev=266312=rev Log: Handle bit fields on big-endian systems correctly Currently, the DataExtractor::GetMaxU64Bitfield and GetMaxS64Bitfield routines assume the incoming

[Lldb-commits] [lldb] r266313 - Miscellaneous fixes for big-endian systems

Author: uweigand Date: Thu Apr 14 09:33:47 2016 New Revision: 266313 URL: http://llvm.org/viewvc/llvm-project?rev=266313=rev Log: Miscellaneous fixes for big-endian systems This patch fixes a bunch of issues that show up on big-endian systems: - The gnu_libstdcpp.py script doesn't follow the

[Lldb-commits] [lldb] r266314 - Fix ARM instruction emulation tests on big-endian systems

Author: uweigand Date: Thu Apr 14 09:34:19 2016 New Revision: 266314 URL: http://llvm.org/viewvc/llvm-project?rev=266314=rev Log: Fix ARM instruction emulation tests on big-endian systems Running the ARM instruction emulation test on a big-endian system would fail, since the code doesn't respect

Re: [Lldb-commits] [PATCH] D18983: Miscellaneous fixes for big-endian systems

This revision was automatically updated to reflect the committed changes. Closed by commit rL266313: Miscellaneous fixes for big-endian systems (authored by uweigand). Changed prior to commit: http://reviews.llvm.org/D18983?vs=53299=53712#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D18982: Handle bit fields on big-endian systems correctly

This revision was automatically updated to reflect the committed changes. Closed by commit rL266312: Handle bit fields on big-endian systems correctly (authored by uweigand). Changed prior to commit: http://reviews.llvm.org/D18982?vs=53605=53711#toc Repository: rL LLVM

[Lldb-commits] [lldb] r266316 - Find .plt section in object files generated by recent ld

Author: uweigand Date: Thu Apr 14 09:36:29 2016 New Revision: 266316 URL: http://llvm.org/viewvc/llvm-project?rev=266316=rev Log: Find .plt section in object files generated by recent ld Code in ObjectFileELF::ParseTrampolineSymbols assumes that the sh_info field of the .rel(a).plt section

Re: [Lldb-commits] [PATCH] D18973: Find .plt section in object files generated by recent ld

This revision was automatically updated to reflect the committed changes. Closed by commit rL266316: Find .plt section in object files generated by recent ld (authored by uweigand). Changed prior to commit: http://reviews.llvm.org/D18973?vs=53288=53715#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D19114: [test] Relax stderr expectations on targets with chatty output

tberghammer accepted this revision. tberghammer added a reviewer: tberghammer. tberghammer added a comment. This revision is now accepted and ready to land. Looks good http://reviews.llvm.org/D19114 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D18978: Support Linux on SystemZ as platform

Hi, this has broken basically everything on 32-bit targets . Will you be able to track down the problem quickly? I don't expect the fix to be complicated, but if we can't track it down quickly (1-2 hours?) we should

Re: [Lldb-commits] [PATCH] D18978: Support Linux on SystemZ as platform

labath added a subscriber: labath. labath added a comment. Hi, this has broken basically everything on 32-bit targets http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/13413. Will you be able to track down the problem quickly? I don't expect the fix to be complicated, but

Re: [Lldb-commits] [PATCH] D18978: Support Linux on SystemZ as platform

Pavel Labath wrote on 14.04.2016 17:36:40: > this has broken basically everything on 32-bit targets > >. > Will you be able to track down the problem quickly? I don't expect the > fix to be

[Lldb-commits] [lldb] r266352 - Fix regression in gnu_libstdcpp.py introduced by r266313

Author: uweigand Date: Thu Apr 14 13:31:12 2016 New Revision: 266352 URL: http://llvm.org/viewvc/llvm-project?rev=266352=rev Log: Fix regression in gnu_libstdcpp.py introduced by r266313 CreateChildAtOffset needs a byte offset, not an element number. Modified:

Re: [Lldb-commits] [PATCH] D19052: Make destructor breakpoint location test more resilient

labath updated this revision to Diff 53694. labath added a comment. One more tweak to make the test work on linux clang: I've needed to move the constructors out-of-line to make sure the compiler generates the expected symbols. http://reviews.llvm.org/D19052 Files:

Re: [Lldb-commits] [PATCH] D19114: [test] Relax stderr expectations on targets with chatty output

This revision was automatically updated to reflect the committed changes. Closed by commit rL266326: [test] Relax stderr expectations on targets with chatty output (authored by labath). Changed prior to commit: http://reviews.llvm.org/D19114?vs=53718=53737#toc Repository: rL LLVM

[Lldb-commits] [lldb] r266327 - [test] make expect_state_changes actually expect *only* them

Author: labath Date: Thu Apr 14 10:52:58 2016 New Revision: 266327 URL: http://llvm.org/viewvc/llvm-project?rev=266327=rev Log: [test] make expect_state_changes actually expect *only* them The android dirty stderr problem has uncovered an issue where lldbutil.expect_state_changes was reading

[Lldb-commits] [lldb] r266326 - [test] Relax stderr expectations on targets with chatty output

Author: labath Date: Thu Apr 14 10:52:53 2016 New Revision: 266326 URL: http://llvm.org/viewvc/llvm-project?rev=266326=rev Log: [test] Relax stderr expectations on targets with chatty output Summary: On some android targets, a binary can produce additional garbage (e.g. warning messages from

Re: [Lldb-commits] [PATCH] D18978: Support Linux on SystemZ as platform

Pavel Labath wrote on 14.04.2016 17:36:40: > this has broken basically everything on 32-bit targets > >. > Will you be able to track down the problem quickly? I don't expect the > fix to be

[Lldb-commits] [PATCH] D19122: LLDB: Fixed race condition on timeout when stopping private state thread

cameron314 created this revision. cameron314 added reviewers: clayborg, zturner, jingham. cameron314 added subscribers: mamai, lldb-commits. cameron314 set the repository for this revision to rL LLVM. When stopping the private state thread, there was a race condition between the time the thread

Re: [Lldb-commits] [PATCH] D18978: Support Linux on SystemZ as platform

uweigand added a comment. In http://reviews.llvm.org/D18978#400787, @labath wrote: > That's perfect, thanks a lot. :) > > Do you have commit access? If not, let me know when you're ready to start > landing these things... I do have commit access, and have committed the 10 out of 12 patches

[Lldb-commits] [PATCH] D19124: [LLDB] Added support for PHI nodes to IR interpreter

cameron314 created this revision. cameron314 added a reviewer: spyffe. cameron314 added subscribers: mamai, lldb-commits. cameron314 set the repository for this revision to rL LLVM. This allows expressions such as 'i == 1 || i == 2` to be executed using the IR interpreter. Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D19067: Make sure to use lib instead of lib64 for LLDB_LIB_DIR

fjricci added a comment. When I use LLVM_LIBDIR_SUFFIX=64, it looks like the python _lldb.so symlink still points to build/lib/liblldb.so, instead of using the lib64 directory. So if I do this, none of the tests will run on the check-lldb target, since importing lldb in python fails. Perhaps

Re: [Lldb-commits] [PATCH] D19124: [LLDB] Added support for PHI nodes to IR interpreter

zturner added a subscriber: zturner. zturner added a comment. I'll let Sean comment on the content of the patch, but please add a test that runs such an expression and demonstrates the correct output. Repository: rL LLVM http://reviews.llvm.org/D19124

Re: [Lldb-commits] [PATCH] D19124: [LLDB] Added support for PHI nodes to IR interpreter

cameron314 added a comment. Ah, that's a bit tricky at the moment. The LLVM tip no longer compiles with VS2015 (specifically lib\Support\SourceMgr.cpp), and my Python setup for VS2013 is all wonky. This will have to wait a bit. Repository: rL LLVM http://reviews.llvm.org/D19124

Re: [Lldb-commits] [PATCH] D19124: [LLDB] Added support for PHI nodes to IR interpreter

http://lab.llvm.org:8011/builders/lldb-x86-windows-msvc2015 My build bot which uses MSVC 2015 is workign fine. What kind of error are you seeing? On Thu, Apr 14, 2016 at 10:14 AM Cameron wrote: > cameron314 added a comment. > > Ah, that's a bit tricky at the moment.

Re: [Lldb-commits] [PATCH] D19124: [LLDB] Added support for PHI nodes to IR interpreter

cameron314 added a comment. Whoops, my fault. I was accidentally using the VS2013 command prompt with the 2015 cmake files. Compiling happily as we speak, test coming up soon after. Repository: rL LLVM http://reviews.llvm.org/D19124 ___

Re: [Lldb-commits] [PATCH] D19092: Fix Android build after r266267

jingham added a subscriber: jingham. jingham added a comment. Why is this necessary? stdout is a local variable defined in this scope. Why would the android g++ have problems with this? Anyway, if you have to avoid using stdout as a name, maybe name it std_out as that better reflects its

Re: [Lldb-commits] [PATCH] D19124: [LLDB] Added support for PHI nodes to IR interpreter

I'll let Sean comment on the content of the patch, but please add a test that runs such an expression and demonstrates the correct output. On Thu, Apr 14, 2016 at 10:01 AM Cameron via lldb-commits < lldb-commits@lists.llvm.org> wrote: > cameron314 created this revision. > cameron314 added a

[Lldb-commits] [lldb] r266341 - Revert r266311 - Fix usage of APInt.getRawData for big-endian systems

Author: uweigand Date: Thu Apr 14 12:22:18 2016 New Revision: 266341 URL: http://llvm.org/viewvc/llvm-project?rev=266341=rev Log: Revert r266311 - Fix usage of APInt.getRawData for big-endian systems Try to get 32-bit build bots running again. Modified:

[Lldb-commits] [lldb] r266343 - Disable LinuxCoreTestCase.test_s390x

Author: uweigand Date: Thu Apr 14 12:36:41 2016 New Revision: 266343 URL: http://llvm.org/viewvc/llvm-project?rev=266343=rev Log: Disable LinuxCoreTestCase.test_s390x This seems to hang on non-s390x hosts. Disable for now to get the build bots going again. Modified:

Re: [Lldb-commits] [PATCH] D19092: Fix Android build after r266267

ovyalov added a comment. In http://reviews.llvm.org/D19092#401450, @jingham wrote: > Why is this necessary? stdout is a local variable defined in this scope. > Why would the android g++ have problems with this? > > Anyway, if you have to avoid using stdout as a name, maybe name it std_out as

Re: [Lldb-commits] [PATCH] D19122: LLDB: Fixed race condition on timeout when stopping private state thread

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. If you use the instance variable directly, we will need a mutex inside the HostNativeThreadBase class to protect against multi-threaded access. I believe the reason it was being

Re: [Lldb-commits] [PATCH] D19092: Fix Android build after r266267

> On Apr 14, 2016, at 10:56 AM, Oleksiy Vyalov via lldb-commits > wrote: > > ovyalov added a comment. > > In http://reviews.llvm.org/D19092#401450, @jingham wrote: > >> Why is this necessary? stdout is a local variable defined in this scope. >> Why would the

Re: [Lldb-commits] [PATCH] D18979: Fixes for platforms that default to unsigned char

This revision was automatically updated to reflect the committed changes. Closed by commit rL266309: Fixes for platforms that default to unsigned char (authored by uweigand). Changed prior to commit: http://reviews.llvm.org/D18979?vs=53294=53708#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D18985: Fix test cases for big-endian systems

This revision was automatically updated to reflect the committed changes. Closed by commit rL266315: Fix test cases for big-endian systems (authored by uweigand). Changed prior to commit: http://reviews.llvm.org/D18985?vs=53501=53714#toc Repository: rL LLVM http://reviews.llvm.org/D18985

[Lldb-commits] [lldb] r266315 - Fix test cases for big-endian systems

Author: uweigand Date: Thu Apr 14 09:35:02 2016 New Revision: 266315 URL: http://llvm.org/viewvc/llvm-project?rev=266315=rev Log: Fix test cases for big-endian systems A number of test cases were failing on big-endian systems simply due to byte order assumptions in the tests themselves, and no

Re: [Lldb-commits] [PATCH] D18984: Fix ARM instruction emulation tests on big-endian systems

This revision was automatically updated to reflect the committed changes. Closed by commit rL266314: Fix ARM instruction emulation tests on big-endian systems (authored by uweigand). Changed prior to commit: http://reviews.llvm.org/D18984?vs=53500=53713#toc Repository: rL LLVM