Re: [Lldb-commits] [PATCH] D21751: Implement GetMemoryRegions() for Linux and Mac OSX core files.

2016-07-06 Thread Howard Hellyer via lldb-commits
hhellyer updated this revision to Diff 62839. hhellyer added a comment. Updated patch to export IsMapped in the C++ and Python APIs. Updated the test case to verify all the regions returned in the list are mapped. http://reviews.llvm.org/D21751 Files: include/lldb/API/SBMemoryRegionInfo.h

[Lldb-commits] [PATCH] D22039: [LLGS] Log more precise errors during inferior launch

2016-07-06 Thread Pavel Labath via lldb-commits
labath created this revision. labath added a reviewer: tberghammer. labath added a subscriber: lldb-commits. Herald added subscribers: danalbert, tberghammer. We are seeing infrequent failures to launch the inferior process on android. The failing call seems to be execve(). This adds more

Re: [Lldb-commits] [PATCH] D22039: [LLGS] Log more precise errors during inferior launch

2016-07-06 Thread Pavel Labath via lldb-commits
labath updated this revision to Diff 62842. labath added a comment. run clang-format over the patch http://reviews.llvm.org/D22039 Files: source/Plugins/Process/Linux/NativeProcessLinux.cpp source/Plugins/Process/Linux/NativeProcessLinux.h Index:

[Lldb-commits] [lldb] r274621 - In AddressSanitizer and ThreadSanitizer, let's explicitly set the language of the expression we're evaluating.

2016-07-06 Thread Kuba Brecka via lldb-commits
Author: kuba.brecka Date: Wed Jul 6 06:46:20 2016 New Revision: 274621 URL: http://llvm.org/viewvc/llvm-project?rev=274621=rev Log: In AddressSanitizer and ThreadSanitizer, let's explicitly set the language of the expression we're evaluating. Modified:

[Lldb-commits] [PATCH] D22040: Add oat symbolization support for odex files

2016-07-06 Thread Tamas Berghammer via lldb-commits
tberghammer created this revision. tberghammer added reviewers: labath, ovyalov. tberghammer added a subscriber: lldb-commits. Herald added subscribers: srhines, danalbert, tberghammer. Add oat symbolization support for odex files http://reviews.llvm.org/D22040 Files:

Re: [Lldb-commits] [PATCH] D22039: [LLGS] Log more precise errors during inferior launch

2016-07-06 Thread Tamas Berghammer via lldb-commits
tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. Looks good. You might want to print the errno a bit better but I am fine with the current implementation as well. http://reviews.llvm.org/D22039

[Lldb-commits] [lldb] r274624 - [LLGS] Log more precise errors during inferior launch

2016-07-06 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Jul 6 08:18:50 2016 New Revision: 274624 URL: http://llvm.org/viewvc/llvm-project?rev=274624=rev Log: [LLGS] Log more precise errors during inferior launch Summary: We are seeing infrequent failures to launch the inferior process on android. The failing call seems to

Re: [Lldb-commits] [PATCH] D22039: [LLGS] Log more precise errors during inferior launch

2016-07-06 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL274624: [LLGS] Log more precise errors during inferior launch (authored by labath). Changed prior to commit: http://reviews.llvm.org/D22039?vs=62842=62854#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D22029: Fix ADB client disconnect issues

2016-07-06 Thread Tamas Berghammer via lldb-commits
tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. Looks good http://reviews.llvm.org/D22029 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r274638 - Fix ADB client disconnect issues.

2016-07-06 Thread Oleksiy Vyalov via lldb-commits
Author: ovyalov Date: Wed Jul 6 12:02:42 2016 New Revision: 274638 URL: http://llvm.org/viewvc/llvm-project?rev=274638=rev Log: Fix ADB client disconnect issues. http://reviews.llvm.org/D22029 Modified: lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp

Re: [Lldb-commits] [PATCH] D22029: Fix ADB client disconnect issues

2016-07-06 Thread Oleksiy Vyalov via lldb-commits
ovyalov closed this revision. ovyalov added a comment. Files: /lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp /lldb/trunk/source/Plugins/Platform/Android/AdbClient.h /lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp

[Lldb-commits] [PATCH] D22060: [expression evaluation] Prevent invalid function declarations ending up in clang AST

2016-07-06 Thread Luke Drummond via lldb-commits
ldrumm created this revision. ldrumm added reviewers: spyffe, jingham. ldrumm added a subscriber: lldb-commits. Due to the way the lldb override for `clang::ExternalASTSource::FindExternalGlobalVisibleDeclsByName` callback was searching for functions, it was possible for invalid declarations to

Re: [Lldb-commits] [PATCH] D22060: [expression evaluation] Prevent invalid function declarations ending up in clang AST

2016-07-06 Thread Jim Ingham via lldb-commits
jingham added a comment. Shouldn't it be the job of the subsequent filtering loop to sort this out? The debugger should be able to call functions from a given frame, even if that function is not actually visible from the current frame. So I don't think you want to reject such functions from

[Lldb-commits] [lldb] r274683 - Because of our lifetime rules w.r.t. ValueObjects and ClusterManagers, synthetic children caching is a tricky area:

2016-07-06 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed Jul 6 16:24:28 2016 New Revision: 274683 URL: http://llvm.org/viewvc/llvm-project?rev=274683=rev Log: Because of our lifetime rules w.r.t. ValueObjects and ClusterManagers, synthetic children caching is a tricky area: - if a synthetic child comes from the same hierarchy

Re: [Lldb-commits] [PATCH] D22052: Respect `ANDROID_SERIAL` environment variable used by ADB

2016-07-06 Thread Oleksiy Vyalov via lldb-commits
ovyalov added inline comments. Comment at: source/Plugins/Platform/Android/AdbClient.cpp:71 @@ +70,3 @@ +{ +if (const char *android_serial = std::getenv("ANDROID_SERIAL")) +adb.SetDeviceID(android_serial); Could you check

[Lldb-commits] [lldb] r274635 - Add oat symbolization support for odex files

2016-07-06 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Wed Jul 6 11:40:09 2016 New Revision: 274635 URL: http://llvm.org/viewvc/llvm-project?rev=274635=rev Log: Add oat symbolization support for odex files Differential revision: http://reviews.llvm.org/D22040 Modified:

Re: [Lldb-commits] [PATCH] D22040: Add oat symbolization support for odex files

2016-07-06 Thread Pavel Labath via lldb-commits
labath added a comment. What is the performance implication of this? http://reviews.llvm.org/D22040 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D21751: Implement GetMemoryRegions() for Linux and Mac OSX core files.

2016-07-06 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D21751 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D22040: Add oat symbolization support for odex files

2016-07-06 Thread Tamas Berghammer via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL274635: Add oat symbolization support for odex files (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D22040?vs=62851=62895#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D22052: Respect `ANDROID_SERIAL` environment variable used by ADB

2016-07-06 Thread Luke Drummond via lldb-commits
ldrumm created this revision. ldrumm added reviewers: tberghammer, ovyalov. ldrumm added a subscriber: lldb-commits. ldrumm set the repository for this revision to rL LLVM. Herald added subscribers: srhines, danalbert, tberghammer. Respect `ANDROID_SERIAL` environment variable used by ADB

[Lldb-commits] [lldb] r274718 - Add support to debugserver for some new ways to interact with dyld

2016-07-06 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Wed Jul 6 20:09:23 2016 New Revision: 274718 URL: http://llvm.org/viewvc/llvm-project?rev=274718=rev Log: Add support to debugserver for some new ways to interact with dyld to find the solibs loaded in a process. Support two new ways of sending the

[Lldb-commits] [lldb] r274700 - Enhance FuncUnwinders::GetUnwindPlanAtNonCallSite to detect when we

2016-07-06 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Wed Jul 6 18:06:19 2016 New Revision: 274700 URL: http://llvm.org/viewvc/llvm-project?rev=274700=rev Log: Enhance FuncUnwinders::GetUnwindPlanAtNonCallSite to detect when we may be in a function that is non-ABI conformant, and the eh_frame instructions correctly describe

[Lldb-commits] [lldb] r274703 - "frame variable" and "target variable" shouldn't allow us to get the address of bitfields.

2016-07-06 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Wed Jul 6 18:16:24 2016 New Revision: 274703 URL: http://llvm.org/viewvc/llvm-project?rev=274703=rev Log: "frame variable" and "target variable" shouldn't allow us to get the address of bitfields. "frame variable" and "target variable" are trying to emulate the

Re: [Lldb-commits] [PATCH] D21221: Fix for PrintStackTraces

2016-07-06 Thread Jason Molenda via lldb-commits
jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Ravitheja and I had some discussions over email about a possible alternate approach to this issue - I've committed that approach as r274700 after testing help from Ravi. This

[Lldb-commits] [lldb] r274701 - LLDB reads incorrect memory ranges when displaying bitfields when reading bits from file memory.

2016-07-06 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Wed Jul 6 18:11:13 2016 New Revision: 274701 URL: http://llvm.org/viewvc/llvm-project?rev=274701=rev Log: LLDB reads incorrect memory ranges when displaying bitfields when reading bits from file memory. Bitfields were not correctly describing their offsets within the

[Lldb-commits] [PATCH] D22081: Use shell cat command as a workaround if ADB stat cannot lookup a file

2016-07-06 Thread Oleksiy Vyalov via lldb-commits
ovyalov created this revision. ovyalov added reviewers: tberghammer, labath. ovyalov added a subscriber: lldb-commits. Herald added subscribers: danalbert, tberghammer. adbd may fail to access a file due security constraints - in such case sync:stat command returns file's mode as 0. If it's the

[Lldb-commits] [lldb] r274697 - Fix the installation of the vector data formatters in order to restore functionality

2016-07-06 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed Jul 6 17:35:34 2016 New Revision: 274697 URL: http://llvm.org/viewvc/llvm-project?rev=274697=rev Log: Fix the installation of the vector data formatters in order to restore functionality Modified: lldb/trunk/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp

[Lldb-commits] [lldb] r274725 - debugserver will now report the minimum version load command

2016-07-06 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Wed Jul 6 22:12:01 2016 New Revision: 274725 URL: http://llvm.org/viewvc/llvm-project?rev=274725=rev Log: debugserver will now report the minimum version load command os name and version # from the mach-o binary as it scans the header/load commands from memory and sends

Re: [Lldb-commits] [PATCH] D22040: Add oat symbolization support for odex files

2016-07-06 Thread Oleksiy Vyalov via lldb-commits
ovyalov accepted this revision. ovyalov added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D22040 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D21221: Fix for PrintStackTraces

2016-07-06 Thread Ravitheja Addepally via lldb-commits
ravitheja updated this revision to Diff 62831. ravitheja added a comment. Removing other files. http://reviews.llvm.org/D21221 Files: packages/Python/lldbsuite/test/functionalities/unwind/ehframe/ packages/Python/lldbsuite/test/functionalities/unwind/ehframe/Makefile

Re: [Lldb-commits] [PATCH] D21984: Add data formatter for libstdc++ shared_ptr and weak_ptr

2016-07-06 Thread Tamas Berghammer via lldb-commits
tberghammer added inline comments. Comment at: source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:665 @@ +664,3 @@ + +stl_summary_flags.SetDontShowChildren(true); +AddCXXSummary(cpp_category_sp, lldb_private::formatters::LibStdcppSmartPointerSummaryProvider,

[Lldb-commits] [lldb] r274617 - Add data formatter for libstdc++ shared_ptr and weak_ptr

2016-07-06 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Wed Jul 6 04:50:00 2016 New Revision: 274617 URL: http://llvm.org/viewvc/llvm-project?rev=274617=rev Log: Add data formatter for libstdc++ shared_ptr and weak_ptr Differential revision: http://reviews.llvm.org/D21984 Added:

Re: [Lldb-commits] [PATCH] D21984: Add data formatter for libstdc++ shared_ptr and weak_ptr

2016-07-06 Thread Tamas Berghammer via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL274617: Add data formatter for libstdc++ shared_ptr and weak_ptr (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D21984?vs=62730=62838#toc Repository: rL LLVM