Re: [Lldb-commits] [PATCH] D20464: [LLDB][MIPS] Check if libatomic needs to be specified explicitly.

Eugene.Zelenko added a comment. > Then we need to introduce a 64 bit atomic check in > cmake/modules/LLDBStandalone.cmake. What do you think? > > Thanks I think this should be right solution. Repository: rL LLVM http://reviews.llvm.org/D20464

Re: [Lldb-commits] [PATCH] D22081: Use shell cat command as a workaround if ADB stat cannot lookup a file

labath added a comment. You raised good points here, Luke. I've thought about the quoting issue, but as you have already noticed there is no way to pass arguments containing quotes to adb correctly. Thinking about it more, what we could do is detect this situation (look for `'` in the file

Re: [Lldb-commits] [PATCH] D22081: Use shell cat command as a workaround if ADB stat cannot lookup a file

ldrumm added a subscriber: ldrumm. Comment at: source/Plugins/Platform/Android/PlatformAndroid.cpp:244 @@ +243,3 @@ +char cmd[PATH_MAX]; +snprintf (cmd, sizeof (cmd), "cat '%s'", source_spec.GetCString (false)); + I have some issues with this

[Lldb-commits] [lldb] r274750 - Fix for PrintStackTraces

Author: ravitheja Date: Thu Jul 7 08:00:29 2016 New Revision: 274750 URL: http://llvm.org/viewvc/llvm-project?rev=274750=rev Log: Fix for PrintStackTraces Summary: The issue arises due to the wrong unwinder used for the first stack frame, where the default unwinder returns erroneous frame

[Lldb-commits] [PATCH] D22097: [zorg] Remove flunkOnFailure=False from the scripted LLDB builder

labath created this revision. labath added reviewers: chying, gkistanova. labath added a subscriber: lldb-commits. The unit tests appear to be running reliably, so let's make them affect the build output. (All scripted LLDB builtbots are still marked as experimental though.)

Re: [Lldb-commits] [PATCH] D22052: Respect `ANDROID_SERIAL` environment variable used by ADB

ovyalov accepted this revision. ovyalov added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D22052 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r274763 - [LLGS] Work around an adb bug on Android <=M

Author: labath Date: Thu Jul 7 10:46:00 2016 New Revision: 274763 URL: http://llvm.org/viewvc/llvm-project?rev=274763=rev Log: [LLGS] Work around an adb bug on Android <=M On android M it can happen that we get a ETXTBSY, when we try to launch the inferior. Sleeping and retrying should help us

[Lldb-commits] [lldb] r274762 - Bump up timeout in TestCallWithTimeout

Author: labath Date: Thu Jul 7 10:45:57 2016 New Revision: 274762 URL: http://llvm.org/viewvc/llvm-project?rev=274762=rev Log: Bump up timeout in TestCallWithTimeout remote targets need a bit more time to get their act together Modified:

[Lldb-commits] [lldb] r274783 - Add an "experimental" setting to disable injecting local variables into expressions.

Author: jingham Date: Thu Jul 7 13:25:48 2016 New Revision: 274783 URL: http://llvm.org/viewvc/llvm-project?rev=274783=rev Log: Add an "experimental" setting to disable injecting local variables into expressions. This feature was added to solve a lookup problem in expressions when local

Re: [Lldb-commits] [PATCH] D22097: [zorg] Remove flunkOnFailure=False from the scripted LLDB builder

chying accepted this revision. chying added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D22097 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D22052: Respect `ANDROID_SERIAL` environment variable used by ADB

This revision was automatically updated to reflect the committed changes. ldrumm marked an inline comment as done. Closed by commit rL274776: Respect ANDROID_SERIAL environment variable used by ADB (authored by ldrumm). Changed prior to commit: http://reviews.llvm.org/D22052?vs=63055=63095#toc

[Lldb-commits] [lldb] r274776 - Respect ANDROID_SERIAL environment variable used by ADB

Author: ldrumm Date: Thu Jul 7 13:02:44 2016 New Revision: 274776 URL: http://llvm.org/viewvc/llvm-project?rev=274776=rev Log: Respect ANDROID_SERIAL environment variable used by ADB When multiple Android devices are attached, the default behaviour of ADB is to resolve a device number based on

[Lldb-commits] [lldb] r274787 - Check whether Sema::CreateBuiltinUnaryOp returns an empty result.

Author: jingham Date: Thu Jul 7 14:06:37 2016 New Revision: 274787 URL: http://llvm.org/viewvc/llvm-project?rev=274787=rev Log: Check whether Sema::CreateBuiltinUnaryOp returns an empty result. If it does, calling AddInitializerToDecl will crash, so we should abort the result synthesis in this

[Lldb-commits] [lldb] r274741 - Implement GetMemoryRegions() for Linux and Mac OSX core files.

Author: hhellyer Date: Thu Jul 7 03:21:28 2016 New Revision: 274741 URL: http://llvm.org/viewvc/llvm-project?rev=274741=rev Log: Implement GetMemoryRegions() for Linux and Mac OSX core files. Summary: This patch fills in the implementation of GetMemoryRegions() on the Linux and Mac OS core

Re: [Lldb-commits] [lldb] r274725 - debugserver will now report the minimum version load command

Hi Jason, This CL caused a build failure on our OSX build bot: http://lab.llvm.org:8011/builders/lldb-x86_64-darwin-13.4/builds/11405/steps/ninja%20build%20local/logs/stdio I committed in a possible fix at http://reviews.llvm.org/rL274743 but please take a look as I don't know too much about

Re: [Lldb-commits] [PATCH] D22081: Use shell cat command as a workaround if ADB stat cannot lookup a file

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good. Please also run clang-format over the patch (also when I don't request it, i tend to forget about that). Comment at:

Re: [Lldb-commits] [PATCH] D20464: [LLDB][MIPS] Check if libatomic needs to be specified explicitly.

nitesh.jain added a comment. In http://reviews.llvm.org/D20464#473884, @Eugene.Zelenko wrote: > As fas as I could judge from log, you built LLDB with LLVM/Clang. But problem > happens when it's necessary to build LLDB separately from LLVM/Clang > (standalone build). Then we need to introduce

[Lldb-commits] [lldb] r274743 - Try to fix the OSX build with old SDK after r274725

Author: tberghammer Date: Thu Jul 7 05:38:05 2016 New Revision: 274743 URL: http://llvm.org/viewvc/llvm-project?rev=274743=rev Log: Try to fix the OSX build with old SDK after r274725 Modified: lldb/trunk/tools/debugserver/source/MacOSX/MachProcess.mm Modified:

[Lldb-commits] [lldb] r274788 - Fix DWARF 4 bitfield support in LLDB to support the DW_AT_data_bit_offset attribute.

Author: gclayton Date: Thu Jul 7 14:44:14 2016 New Revision: 274788 URL: http://llvm.org/viewvc/llvm-project?rev=274788=rev Log: Fix DWARF 4 bitfield support in LLDB to support the DW_AT_data_bit_offset attribute. Modified:

[Lldb-commits] [lldb] r274809 - Fix it so that we only grab the typedef from the module DWARF file if the type that is typedef'ed is a declaration. This fixes the following bugs:

Author: gclayton Date: Thu Jul 7 18:57:39 2016 New Revision: 274809 URL: http://llvm.org/viewvc/llvm-project?rev=274809=rev Log: Fix it so that we only grab the typedef from the module DWARF file if the type that is typedef'ed is a declaration. This fixes the following bugs: [PR28156]

[Lldb-commits] [lldb] r274822 - Add an API to unwind from a hand-called expression.

Author: jingham Date: Thu Jul 7 21:12:05 2016 New Revision: 274822 URL: http://llvm.org/viewvc/llvm-project?rev=274822=rev Log: Add an API to unwind from a hand-called expression. This is just an SB API way of doing "thread return -x". Modified: lldb/trunk/include/lldb/API/SBThread.h

Re: [Lldb-commits] [PATCH] D22081: Use shell cat command as a workaround if ADB stat cannot lookup a file

ovyalov updated this revision to Diff 63173. ovyalov added a comment. Addressed review comments: - Check whether shell command output starts with /system/bin/sh: in order to find out whether command failed - Fail-fast download if filename contains single-quotes - clang-format

Re: [Lldb-commits] [PATCH] D22081: Use shell cat command as a workaround if ADB stat cannot lookup a file

ovyalov added a comment. In http://reviews.llvm.org/D22081#476766, @labath wrote: > You raised good points here, Luke. > > I've thought about the quoting issue, but as you have already noticed there > is no way to pass arguments containing quotes to adb correctly. Thinking > about it more,

Re: [Lldb-commits] [PATCH] D22052: Respect `ANDROID_SERIAL` environment variable used by ADB

ldrumm removed rL LLVM as the repository for this revision. ldrumm updated this revision to Diff 63055. ldrumm added a comment. - Ensure if ANDROID_SERIAL is set, it exists in the list of connected devices (Address feedback from @ovyalov) - Also add a hint in the error message in case multiple