Re: [Lldb-commits] [lldb] r282683 - Add a unit test for an x86_64 assembly inspection of

2016-09-29 Thread Pavel Labath via lldb-commits
Note that the test fails when using gcc as a compiler (specifically gcc-4.9 in this case, but hopefully the exact version does not matter here). Jason, will you be able to check this out today? On 29 September 2016 at 05:45, Dimitar Vlahovski via lldb-commits < lldb-commits@lists.llvm.org>

Re: [Lldb-commits] [PATCH] D25057: Fix ARM/AArch64 Step-Over watchpoint issue remove provision for duplicate watchpoints

2016-09-29 Thread Pavel Labath via lldb-commits
[phabricator seems to be down, so I'll reply here] Thank you for looking into this. Hmm... I think we can consider this an improvement over the status quo, but it's not going to solve the problem in all cases. E.g., on aarch64, a single stp instruction with neon registers can access a block of

Re: [Lldb-commits] [lldb] r282648 - Fix an issue where libc++ changed the type information we get for std::map::iterator, rendering LLDB unable to display elements vended by an iterator

2016-09-29 Thread Enrico Granata via lldb-commits
> On Sep 29, 2016, at 10:50 AM, Zachary Turner wrote: > > > > On Thu, Sep 29, 2016 at 10:43 AM Enrico Granata > wrote: >> On Sep 28, 2016, at 5:58 PM, Zachary Turner > >

Re: [Lldb-commits] [lldb] r282648 - Fix an issue where libc++ changed the type information we get for std::map::iterator, rendering LLDB unable to display elements vended by an iterator

2016-09-29 Thread Enrico Granata via lldb-commits
> On Sep 29, 2016, at 10:58 AM, Enrico Granata via lldb-commits > wrote: > > >> On Sep 29, 2016, at 10:50 AM, Zachary Turner > > wrote: >> >> >> >> On Thu, Sep 29, 2016 at 10:43 AM Enrico Granata

Re: [Lldb-commits] [lldb] r282648 - Fix an issue where libc++ changed the type information we get for std::map::iterator, rendering LLDB unable to display elements vended by an iterator

2016-09-29 Thread Zachary Turner via lldb-commits
Yea :( In practice you're right that it might not ever be an issue, but I know one time I spent quite a long time trying to figure out why I couldn't create a variable named "unix", so any time I see questionable names it brings back terrible memories. On Thu, Sep 29, 2016 at 10:58 AM Enrico

Re: [Lldb-commits] [lldb] r282648 - Fix an issue where libc++ changed the type information we get for std::map::iterator, rendering LLDB unable to display elements vended by an iterator

2016-09-29 Thread Enrico Granata via lldb-commits
> On Sep 28, 2016, at 5:58 PM, Zachary Turner wrote: > > > > On Wed, Sep 28, 2016 at 4:02 PM Enrico Granata via lldb-commits > > wrote: > > - > + > + static ConstString g___i_("__i_"); > + >// this

Re: [Lldb-commits] [lldb] r282648 - Fix an issue where libc++ changed the type information we get for std::map::iterator, rendering LLDB unable to display elements vended by an iterator

2016-09-29 Thread Zachary Turner via lldb-commits
On Thu, Sep 29, 2016 at 10:43 AM Enrico Granata wrote: > On Sep 28, 2016, at 5:58 PM, Zachary Turner wrote: > > > > On Wed, Sep 28, 2016 at 4:02 PM Enrico Granata via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > > > - > + > + static ConstString

Re: [Lldb-commits] [lldb] r282683 - Add a unit test for an x86_64 assembly inspection of

2016-09-29 Thread Jason Molenda via lldb-commits
Yep, will do. I saw that build bot result last night and ran the testsuite on my local ubuntu box and didn't repo the failure so I thought maybe it was an already-failing test case that the bot was just telling me about. But I think I was running the test x86_64 - I'll figure out how to run

[Lldb-commits] [lldb] r282787 - Fixed TestObjCMethods2/i386 by separating out the portions that require ObjC V2.

2016-09-29 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Thu Sep 29 16:43:31 2016 New Revision: 282787 URL: http://llvm.org/viewvc/llvm-project?rev=282787=rev Log: Fixed TestObjCMethods2/i386 by separating out the portions that require ObjC V2. Modified:

[Lldb-commits] [lldb] r282790 - Add a quick note about how to build lldb with debug info using

2016-09-29 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Sep 29 16:47:15 2016 New Revision: 282790 URL: http://llvm.org/viewvc/llvm-project?rev=282790=rev Log: Add a quick note about how to build lldb with debug info using cmake/ninja on linux/bsd systems. Modified: lldb/trunk/www/build.html Modified:

[Lldb-commits] [lldb] r282774 - This test will not work in i386 mode because we don't create interesting types from the ObjC runtime

2016-09-29 Thread Enrico Granata via lldb-commits
Author: enrico Date: Thu Sep 29 16:20:56 2016 New Revision: 282774 URL: http://llvm.org/viewvc/llvm-project?rev=282774=rev Log: This test will not work in i386 mode because we don't create interesting types from the ObjC runtime "Fixes" rdar://28501616 Modified:

[Lldb-commits] [lldb] r282741 - To fix TestObjCMethods2/i386, allowed messaging nil ObjC objects as in x86_64.

2016-09-29 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Thu Sep 29 12:57:33 2016 New Revision: 282741 URL: http://llvm.org/viewvc/llvm-project?rev=282741=rev Log: To fix TestObjCMethods2/i386, allowed messaging nil ObjC objects as in x86_64. Modified:

Re: [Lldb-commits] [PATCH] D25021: [LLDB][MIPS] Fix qProcessInfo to return correct pointer size based on ELF ABI

2016-09-29 Thread Nitesh Jain via lldb-commits
nitesh.jain added inline comments. Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp:1218 @@ +1217,3 @@ +response.Printf("eflags:%" PRIx32 ";", proc_arch.GetFlags()); +if (proc_triple.isArch64Bit()) { + if (proc_arch.IsMIPS()) {

[Lldb-commits] [lldb] r282810 - Add some logging when trace is on. We're getting a bot failure on i386 that doesn't

2016-09-29 Thread Jim Ingham via lldb-commits
Author: jingham Date: Thu Sep 29 18:48:21 2016 New Revision: 282810 URL: http://llvm.org/viewvc/llvm-project?rev=282810=rev Log: Add some logging when trace is on. We're getting a bot failure on i386 that doesn't I can't reproduce locally. Hopefully this will help us catch the reason.

[Lldb-commits] [lldb] r282811 - Switch to using TEST_EQ, TEST_FALSE where appropriate.

2016-09-29 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Sep 29 18:57:33 2016 New Revision: 282811 URL: http://llvm.org/viewvc/llvm-project?rev=282811=rev Log: Switch to using TEST_EQ, TEST_FALSE where appropriate. Modified: lldb/trunk/unittests/UnwindAssembly/x86/Testx86AssemblyInspectionEngine.cpp Modified:

[Lldb-commits] [lldb] r282794 - Don't expect new-style Objective-C literals to work on i386 with the V1 runtime.

2016-09-29 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Thu Sep 29 17:01:11 2016 New Revision: 282794 URL: http://llvm.org/viewvc/llvm-project?rev=282794=rev Log: Don't expect new-style Objective-C literals to work on i386 with the V1 runtime. Modified:

[Lldb-commits] [lldb] r282803 - [CMake] LLDB/Expression needs to depend on intrinsics_gen

2016-09-29 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Thu Sep 29 17:55:09 2016 New Revision: 282803 URL: http://llvm.org/viewvc/llvm-project?rev=282803=rev Log: [CMake] LLDB/Expression needs to depend on intrinsics_gen IRExecutionUnit.h includes Module.h, which through a long chain of includes eventually includes

[Lldb-commits] [lldb] r282822 - Move UTF functions into namespace llvm.

2016-09-29 Thread Justin Lebar via lldb-commits
Author: jlebar Date: Thu Sep 29 19:38:45 2016 New Revision: 282822 URL: http://llvm.org/viewvc/llvm-project?rev=282822=rev Log: Move UTF functions into namespace llvm. Summary: This lets people link against LLVM and their own version of the UTF library. I determined this only affects llvm,

[Lldb-commits] [lldb] r282825 - Add unit tests for simple frameless i386 and x86_64 function

2016-09-29 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Sep 29 19:41:15 2016 New Revision: 282825 URL: http://llvm.org/viewvc/llvm-project?rev=282825=rev Log: Add unit tests for simple frameless i386 and x86_64 function instruction inspection to UnwindPlans. Modified:

[Lldb-commits] [lldb] r282823 - Do not assume we will be able to discover the return type of this selector call, for that is not true in i386 mode

2016-09-29 Thread Enrico Granata via lldb-commits
Author: enrico Date: Thu Sep 29 19:40:04 2016 New Revision: 282823 URL: http://llvm.org/viewvc/llvm-project?rev=282823=rev Log: Do not assume we will be able to discover the return type of this selector call, for that is not true in i386 mode Modified:

[Lldb-commits] [lldb] r282824 - Prefer skipping over x-failing

2016-09-29 Thread Enrico Granata via lldb-commits
Author: enrico Date: Thu Sep 29 19:41:07 2016 New Revision: 282824 URL: http://llvm.org/viewvc/llvm-project?rev=282824=rev Log: Prefer skipping over x-failing Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/type_lookup/TestTypeLookup.py Modified:

[Lldb-commits] [lldb] r282830 - Add the tracking radar on our end.

2016-09-29 Thread Jim Ingham via lldb-commits
Author: jingham Date: Thu Sep 29 20:23:46 2016 New Revision: 282830 URL: http://llvm.org/viewvc/llvm-project?rev=282830=rev Log: Add the tracking radar on our end. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/thread/break_after_join/TestBreakAfterJoin.py Modified:

Re: [Lldb-commits] [lldb] r282683 - Add a unit test for an x86_64 assembly inspection of

2016-09-29 Thread Dimitar Vlahovski via lldb-commits
Hi, Is the work that you are currently doing the reason why the lldb build on i386 is failing? http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/20099 Dimitar On Thu, Sep 29, 2016 at 5:30 AM, Jason Molenda

Re: [Lldb-commits] [lldb] r282683 - Add a unit test for an x86_64 assembly inspection of

2016-09-29 Thread Dimitar Vlahovski via lldb-commits
This is the first build that failed right after your CL: http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/20083 On Thu, Sep 29, 2016 at 1:35 PM, Dimitar Vlahovski wrote: > Hi, > > Is the work that you are currently doing the reason why the lldb