Eugene.Zelenko added a comment.
Headers orders is still not correct.
Repository:
rL LLVM
https://reviews.llvm.org/D25733
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284828: Improve the libstdc++ smart pointer formatters
(authored by tberghammer).
Changed prior to commit:
https://reviews.llvm.org/D25726?vs=75300=75431#toc
Repository:
rL LLVM
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284829: Add data formatter for libstdc++ tuple (authored by
tberghammer).
Changed prior to commit:
https://reviews.llvm.org/D25733?vs=75417=75433#toc
Repository:
rL LLVM
Author: tberghammer
Date: Fri Oct 21 10:02:38 2016
New Revision: 284829
URL: http://llvm.org/viewvc/llvm-project?rev=284829=rev
Log:
Add data formatter for libstdc++ tuple
Differential revision: https://reviews.llvm.org/D25733
Added:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284830: Add data formatter for libstdc++ unique_ptr
(authored by tberghammer).
Changed prior to commit:
https://reviews.llvm.org/D25734?vs=75425=75432#toc
Repository:
rL LLVM
Eugene.Zelenko added a comment.
Headers orders is still not correct.
https://reviews.llvm.org/D25734
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: tberghammer
Date: Fri Oct 21 10:02:44 2016
New Revision: 284830
URL: http://llvm.org/viewvc/llvm-project?rev=284830=rev
Log:
Add data formatter for libstdc++ unique_ptr
Differential revision: https://reviews.llvm.org/D25734
Added:
Author: tberghammer
Date: Fri Oct 21 10:05:03 2016
New Revision: 284831
URL: http://llvm.org/viewvc/llvm-project?rev=284831=rev
Log:
Fix incorrect header order introduced in rL284830
Modified:
lldb/trunk/source/Plugins/Language/CPlusPlus/LibStdcppTuple.cpp
krytarowski added a comment.
NetBSD is still focused on amd64-only port.
I start a funded project November 1st on getting x86 process plugin to work.
More details here:
http://blog.netbsd.org/tnf/entry/funded_contract_2016_2017
Estimated time is 4 months full-time.
However there every help
tfiala commandeered this revision.
tfiala edited reviewers, added: vivkong; removed: tfiala.
tfiala added a comment.
@beanz and I discussed. This isn't needed here at all. The issue is entirely
in the current manifestation of the GitHub side of swift-lldb.
Closing this out, we'll resolve in
krytarowski added a comment.
I just scrolled the discussion so it's not really started. Thanks.
My plan is to work on ptrace(2) for about a month.
Then I will take the FreeBSD code as it is and port to NetBSD trying to make it
functional. This is difficult part as there is everywhere OS
dmikulin marked an inline comment as done.
dmikulin added a comment.
Thanks Pavel! I'll start working on it. Do you know when lldb-server Linux
changes were committed? I want to use those patches as a template, but it's
hard to locate them digging through thousands of commit log entries...
Ed,
emaste added a subscriber: krytarowski.
emaste added a comment.
On a quick look this seems OK. I'll try to test/review in detail.
In https://reviews.llvm.org/D25756#576642, @dmikulin wrote:
> Thanks Pavel! I'll start working on it. Do you know when lldb-server Linux
> changes were committed? I
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
LGTM as long as you've run the test suite and confirmed everything works.
https://reviews.llvm.org/D25681
___
lldb-commits mailing list
Yeah, sorry, that was an oversight on my part, but I think it's trivial to fix.
The WatchpointSentry was being set up before the little single step over the
watchpoint dance, and it was accidentally being used to get the watchpoint
disabled. That's not the main point of the sentry, which is
Author: jingham
Date: Fri Oct 21 13:18:25 2016
New Revision: 284851
URL: http://llvm.org/viewvc/llvm-project?rev=284851=rev
Log:
Add the new stdcpp formatters to the Xcode project.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
I uploaded:
https://reviews.llvm.org/D25875
Can you see if that fixes the failures you were seeing.
I'm not sure why that step over is happening in the StopInfoWatchpoint. We
usually try to hide that sort of platform difference down in the process
plugins and then let the upper layers see
Author: enrico
Date: Fri Oct 21 13:03:55 2016
New Revision: 284847
URL: http://llvm.org/viewvc/llvm-project?rev=284847=rev
Log:
I hadn't fixed all the instances of the old marker for scripted format strings;
do so now
Modified:
lldb/trunk/www/formats.html
Modified:
Author: cbieneman
Date: Fri Oct 21 13:38:44 2016
New Revision: 284854
URL: http://llvm.org/viewvc/llvm-project?rev=284854=rev
Log:
[CMake] Fix standalone build
not and FileCheck targets may not be defined in standalone builds.
Modified:
lldb/trunk/lit/CMakeLists.txt
Modified:
Author: cbieneman
Date: Fri Oct 21 17:13:55 2016
New Revision: 284893
URL: http://llvm.org/viewvc/llvm-project?rev=284893=rev
Log:
[Test Suite] Allow overriding codesign identity
Summary: Not everyone names their code sign identity "lldb_codesign", so it is
nice to allow this to be overridden.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284893: [Test Suite] Allow overriding codesign identity
(authored by cbieneman).
Changed prior to commit:
https://reviews.llvm.org/D25714?vs=75057=75499#toc
Repository:
rL LLVM
beanz updated this revision to Diff 75507.
beanz added a comment.
Cleaning up extra references to lldb-launcher
https://reviews.llvm.org/D25745
Files:
scripts/Python/finish-swig-Python-LLDB.sh
scripts/Python/finishSwigPythonLLDB.py
tools/darwin-debug/CMakeLists.txt
Index:
beanz created this revision.
beanz added reviewers: tfiala, zturner.
beanz added a subscriber: lldb-commits.
Convert tests using LLDB headers to use generateSource to put the right include
paths in place regardless of whether or not you're building a framework.
This also abstracted
Note that the WatchpointSentry logic predated the support for
"!watchpoint_triggers_after", and it's real goal was to have accesses to the
watchpoint in commands in the breakpoint action not re-trigger the watchpoint.
The step-over-watchpoint logic was accidentally getting the benefit of this,
beanz created this revision.
beanz added a reviewer: tfiala.
beanz added a subscriber: lldb-commits.
Herald added a subscriber: mgorny.
dotest.py has a framework option that is not respected. This patch makes the
framework path properly configurable via the --framework option.
This patch also
Hello everyone,
LLVM buildmaster will be updated and restarted after 7 PM Pacific time
today.
Thanks
Galina
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D25887
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
Author: jmolenda
Date: Fri Oct 21 18:45:07 2016
New Revision: 284900
URL: http://llvm.org/viewvc/llvm-project?rev=284900=rev
Log:
Add some additional logging to
DynamicLoaderDarwinKernel::CheckForKernelImageAtAddress to debug
corefiles that may not be correctly formed.
Modified:
zturner added a comment.
Maybe put that function `lldbplatformutil`?
https://reviews.llvm.org/D25886
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
Looks good.
I do wonder if we should have a general helper for lines like this:
sys.platform.rstrip('0123456789') in ('freebsd', 'linux', 'netbsd', 'darwin')
but that doesn't have to be
tberghammer added a comment.
Sorry, I missed that part. I just submitted r284831 what should fix the header
order for both case.
Repository:
rL LLVM
https://reviews.llvm.org/D25733
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
Ok, after the latest round of changes, I was not able to reproduce the
behaviour where we would continually be-continually re-hitting a
watchpoint. However, I did manage to get the lldb-server to hang if I
set two watchpoints close to each other and trigger them both with a
single instruction. I
labath added a comment.
I don't know of any good source of documentation for this, but I am willing to
answer any questions you might have about this. Basically, the idea of
lldb-server is that you use the same code path for remote debugging as you to
for local. So all the debugging is done in
tberghammer added a comment.
A few high level comments:
- I have the feeling you ported much more code over to use the LLDB register
numbers then it would be strictly necessary. I am not sure if it is good or bad
as it can help us consolidate the confusion around the different register
tberghammer updated this revision to Diff 75417.
tberghammer marked 4 inline comments as done.
https://reviews.llvm.org/D25733
Files:
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/tuple/Makefile
tberghammer updated this revision to Diff 75425.
tberghammer marked 2 inline comments as done.
Herald added subscribers: mgorny, beanz.
https://reviews.llvm.org/D25734
Files:
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/unique_ptr/Makefile
tberghammer added inline comments.
Comment at: source/Plugins/Language/CPlusPlus/LibStdcppUniquePointer.cpp:110
+ if (name == ConstString("ptr") || name == ConstString("pointer")) return 2;
+ return UINT32_MAX;
+}
labath wrote:
> ~0 ?
The user compares the
Ilod updated this revision to Diff 75426.
Ilod added a comment.
Yeah, you're right, the previous code is used for reference was inconsistent
here. Now I return false and set an error string. Also remove an hacky ifdef
which was needed on previous implementation (because the master id was
Author: labath
Date: Fri Oct 21 05:52:11 2016
New Revision: 284817
URL: http://llvm.org/viewvc/llvm-project?rev=284817=rev
Log:
Revert "Fix a race condition between "ephemeral watchpoint disable/enable" and
continue in commands."
This reverts commit r284795, as it breaks watchpoint handling on
Author: labath
Date: Fri Oct 21 06:14:04 2016
New Revision: 284819
URL: http://llvm.org/viewvc/llvm-project?rev=284819=rev
Log:
Add TestMultipleHits.py
This tests that lldb handles the situation when a single instruction triggers
multiple watchpoint hits. It currently fails on arm due to what
40 matches
Mail list logo
