Author: labath
Date: Wed Nov 8 02:48:50 2017
New Revision: 317678
URL: http://llvm.org/viewvc/llvm-project?rev=317678&view=rev
Log:
Make TestTopLevelExprs more robust in face of linker GC
Summary:
This test was failing in various configurations on linux in a fairly
unpredictible way. The success
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317678: Make TestTopLevelExprs more robust in face of linker
GC (authored by labath).
Repository:
rL LLVM
https://reviews.llvm.org/D39727
Files:
lldb/trunk/packages/Python/lldbsuite/test/expression
Author: labath
Date: Wed Nov 8 02:48:54 2017
New Revision: 317679
URL: http://llvm.org/viewvc/llvm-project?rev=317679&view=rev
Log:
Log: delimit thread name in log message
The thread name was not followed by a space, which meant it was glued to
the log message. I also align the name as we do tha
labath added inline comments.
Comment at: include/lldb/Host/common/NativeProcessProtocol.h:104
- virtual bool GetArchitecture(ArchSpec &arch) const = 0;
+ virtual const ArchSpec &GetArchitecture() const = 0;
eugene wrote:
> labath wrote:
> > eugene wrote:
>
labath updated this revision to Diff 122050.
labath marked an inline comment as done.
labath added a comment.
Avoid a couple of ArchSpec copies, as suggested.
https://reviews.llvm.org/D39733
Files:
include/lldb/Host/common/NativeProcessProtocol.h
source/Host/common/NativeProcessProtocol.cpp
Author: labath
Date: Wed Nov 8 03:51:49 2017
New Revision: 317683
URL: http://llvm.org/viewvc/llvm-project?rev=317683&view=rev
Log:
Xfail TestConcurrentTwoWatchpointsOneSignal on arm
r317561 exposed an interesting bug (pr35228) in handling of simultaneous
watchpoint hits. Disabling the test unti
labath created this revision.
Herald added a subscriber: mgorny.
These tests used to log the error message and return plain bool mainly
because at the time they we written, we did not have a nice way to
assert on llvm::Error values. That is no longer true, so replace this
pattern with a more idiom
labath updated this revision to Diff 122063.
labath added a comment.
Avoid mutable arguments
https://reviews.llvm.org/D35356
Files:
buildbot/osuosl/master/config/builders.py
zorg/buildbot/builders/LLDBBuilder.py
Index: zorg/buildbot/builders/LLDBBuilder.py
labath marked an inline comment as done.
labath added a comment.
I am sorry about the delay, I was on extended leave.
Comment at: zorg/buildbot/builders/LLDBBuilder.py:921
scriptExt='.sh',
+ extra_cmake_args=[],
alexshap created this revision.
Herald added subscribers: JDevlieghere, aprantl.
At the moment for DIERefs coming from DWO/DWP LLDB expects cu_offset to be
equal to the offset of
the original compilation unit. This invariant is ensured during the "indexing"
of DIEs of the original SymbolFileDWAR
10 matches
Mail list logo