[Lldb-commits] [PATCH] D47492: DWARFUnit::m_die_array swap()->shrink_to_fit()

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. shrink_to_fit should be fine. I wouldn't expect to see any difference as it is implemented (in libstdc++ at least) using the swap trick too. https://reviews.llvm.org/D47492

[Lldb-commits] [PATCH] D47551: [IRMemoryMap] Fix the alignment adjustment in Malloc

labath added a comment. I don't know much about IRMemoryMap myself, but this does seem uncontroversial. Nonetheless, I did manage to find something to rip into. :D Comment at: source/Expression/IRMemoryMap.cpp:312-316 +// Round up the requested size to an aligned value,

[Lldb-commits] [PATCH] D47492: DWARFUnit::m_die_array swap()->shrink_to_fit()

This revision was automatically updated to reflect the committed changes. Closed by commit rL333636: Simplify DWARFUnit::m_die_array swap() to use shrink_to_fit() (authored by jankratochvil, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r333636 - Simplify DWARFUnit::m_die_array swap() to use shrink_to_fit()

Author: jankratochvil Date: Thu May 31 01:55:40 2018 New Revision: 333636 URL: http://llvm.org/viewvc/llvm-project?rev=333636=rev Log: Simplify DWARFUnit::m_die_array swap() to use shrink_to_fit() rL145086 introduced m_die_array.shrink_to_fit() implemented by exact_size_die_array.swap, it was

Re: [Lldb-commits] [lldb] r303907 - Fix bug #28898

On May 31, 10:31am, lab...@google.com (Pavel Labath) wrote: -- Subject: Re: [Lldb-commits] [lldb] r303907 - Fix bug #28898 | I hate to resurrect an old thread, but there has been a new spurt of | this discussion about this patch here | . | | I think I have an

[Lldb-commits] [PATCH] D47579: dotest: make inline tests compatible with -f

labath updated this revision to Diff 149269. labath added a comment. - obliterate using_dsym property - reduce confusion in the MakeInlineTest function (variable "test" used for multiple things) https://reviews.llvm.org/D47579 Files: packages/Python/lldbsuite/test/lldbinline.py Index:

[Lldb-commits] [PATCH] D47579: dotest: make inline tests compatible with -f

labath added a comment. In https://reviews.llvm.org/D47579#1117457, @JDevlieghere wrote: > If I correctly understand this change, this might make it possible to apply > the `add_test_categories` decorator to an inline test. We had issues with > this when introducing the swiftpr category

[Lldb-commits] [PATCH] D47539: [Platform] Accept arbitrary kext variants

JDevlieghere added a comment. In https://reviews.llvm.org/D47539#1117114, @jasonmolenda wrote: > LGTM. If we added more knowledge specifically about kext bundle layouts, we > could restrict which files we test to see if they are valid binaries - but > we'd need to parse the Info.plist at the

[Lldb-commits] Support of MSVC function-level linking

Hello! I'm Aleksandr from JetBrains. We are working on improving support of MSVC-compiled binaries in lldb. We have made several fixes and would like to upstream them. The first patch adds support of function-level linking feature. The SymbolFilePDB::ParseCompileUnitLineTable function relies on

[Lldb-commits] [PATCH] D47470: AppleDWARFIndex: Get function method-ness directly from debug info

labath marked 4 inline comments as done. labath added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp:153 +return true; + bool looking_for_methods = name_type_mask & eFunctionNameTypeMethod; + return looking_for_methods == die.IsMethod();

[Lldb-commits] [lldb] r333640 - Remove the TestSequenceFunctions "example" test

Author: labath Date: Thu May 31 02:56:38 2018 New Revision: 333640 URL: http://llvm.org/viewvc/llvm-project?rev=333640=rev Log: Remove the TestSequenceFunctions "example" test This test was using unittest (not unittest2) as the test framework, and it worked with dotest only by accident. Remove

[Lldb-commits] [PATCH] D40470: Protect DWARFCompileUnit::m_die_array by a new mutex

jankratochvil updated this revision to Diff 149255. jankratochvil marked an inline comment as done. jankratochvil added a comment. RAII lock `DWARFUnit::ScopedExtractDIEs` with mutexes `m_die_array_mutex`, `m_die_array_scoped_mutex` and `m_first_die_mutex`. https://reviews.llvm.org/D40470

[Lldb-commits] [PATCH] D47470: AppleDWARFIndex: Get function method-ness directly from debug info

labath marked 4 inline comments as done. labath added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFDIE.cpp:222 +return true; + return GetReferencedDIE(DW_AT_specification) + .GetParent() JDevlieghere wrote: > labath wrote: > >

[Lldb-commits] [PATCH] D47492: DWARFUnit::m_die_array swap()->shrink_to_fit()

labath added a comment. Well, if a type is trivially copyable (which DWARFDebugInfo **should** be, though I haven't checked), it should be able to do the copy via a single `memcpy` instead of a bunch of constructor calls. That should be more-or-less equivalent to realloc. If this does not end

[Lldb-commits] [PATCH] D47470: AppleDWARFIndex: Get function method-ness directly from debug info

JDevlieghere added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFDIE.cpp:222 +return true; + return GetReferencedDIE(DW_AT_specification) + .GetParent() labath wrote: > clayborg wrote: > > labath wrote: > > > clayborg wrote: > > > >

[Lldb-commits] [PATCH] D47579: dotest: make inline tests compatible with -f

JDevlieghere added a comment. If I correctly understand this change, this might make it possible to apply the `add_test_categories` decorator to an inline test. We had issues with this when introducing the swiftpr category because the methods were part of the inline test class. From the

[Lldb-commits] [PATCH] D47492: DWARFUnit::m_die_array swap()->shrink_to_fit()

jankratochvil added a comment. In https://reviews.llvm.org/D47492#1117350, @labath wrote: > it is implemented (in libstdc++ at least) using the swap trick too. Thanks for the heads up, I expected it does `realloc()`: implementation absolutely cannot rely on realloc ... because realloc, if it

Re: [Lldb-commits] [lldb] r303907 - Fix bug #28898

I hate to resurrect an old thread, but there has been a new spurt of this discussion about this patch here . I think I have an idea on how to improve things slightly for us here, but as I know very little about this issue, I'd like someone to take a look at this

[Lldb-commits] [PATCH] D47470: AppleDWARFIndex: Get function method-ness directly from debug info

labath updated this revision to Diff 149253. labath added a comment. Implement recursive search in IsMethod() https://reviews.llvm.org/D47470 Files: lit/SymbolFile/DWARF/find-method-local-struct.cpp source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp

[Lldb-commits] [PATCH] D46885: Remove append parameter to FindGlobalVariables

This revision was automatically updated to reflect the committed changes. Closed by commit rL333639: Remove append parameter to FindGlobalVariables (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r333639 - Remove append parameter to FindGlobalVariables

Author: labath Date: Thu May 31 02:46:26 2018 New Revision: 333639 URL: http://llvm.org/viewvc/llvm-project?rev=333639=rev Log: Remove append parameter to FindGlobalVariables Summary: As discussed in https://bugs.llvm.org/show_bug.cgi?id=37317, FindGlobalVariables does not properly handle the

[Lldb-commits] [PATCH] D46885: Remove append parameter to FindGlobalVariables

labath added a comment. Thanks for the patch. I've clang-formatted it and committed in r333639. https://reviews.llvm.org/D46885 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D40470: Protect DWARFCompileUnit::m_die_array by a new mutex

jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.h:181 + // ExtractDIEsIfNeeded() will keep m_die_array populated forever. + uint32_t m_die_array_usecount = 0; // GetUnitDIEPtrOnly()

[Lldb-commits] [PATCH] D47579: dotest: make inline tests compatible with -f

labath created this revision. labath added reviewers: JDevlieghere, aprantl, tberghammer. Herald added a subscriber: eraman. This is split off from https://reviews.llvm.org/D47265 where I needed to be able to invoke every test with -f. That patch is kinda dead now, but this part seems like a

[Lldb-commits] [PATCH] D47481: Initialize FunctionCaller::m_struct_valid

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. We need a clang warning that tells us when POD types are not initialized! I am sure we have other similar issues... https://reviews.llvm.org/D47481

Re: [Lldb-commits] Support of MSVC function-level linking

Can you post your patch to https://reviews.llvm.org/ ? On Thu, May 31, 2018 at 10:36 AM, Leonard Mosescu via lldb-commits < lldb-commits@lists.llvm.org> wrote: > If anyone's working on this I'd suggest adding a test case for the "split > code" case as well (where even a single function is split

Re: [Lldb-commits] Support of MSVC function-level linking

> On May 31, 2018, at 2:31 AM, Aleksandr Urakov via lldb-commits > wrote: > > Hello! > > I'm Aleksandr from JetBrains. We are working on improving support of > MSVC-compiled binaries in lldb. We have made several fixes and would like to > upstream them. > > The first patch adds support of

[Lldb-commits] [PATCH] D47470: AppleDWARFIndex: Get function method-ness directly from debug info

clayborg accepted this revision. clayborg added a comment. Very nice https://reviews.llvm.org/D47470 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D47481: Initialize FunctionCaller::m_struct_valid

tromey added a comment. I don't have write access so someone will have to land this for me. Thanks. https://reviews.llvm.org/D47481 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D47481: Initialize FunctionCaller::m_struct_valid

This revision was automatically updated to reflect the committed changes. Closed by commit rL333690: Set m_struct_valid to initial value in ctor. (authored by jmolenda, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D47481 Files:

[Lldb-commits] [lldb] r333690 - Set m_struct_valid to initial value in ctor.

Author: jmolenda Date: Thu May 31 13:01:15 2018 New Revision: 333690 URL: http://llvm.org/viewvc/llvm-project?rev=333690=rev Log: Set m_struct_valid to initial value in ctor. Patch from Tom Tromey . Differential Revision: https://reviews.llvm.org/D47481 Modified:

[Lldb-commits] [lldb] r333666 - Remove infinite recursion due to FileSpec change.

Author: jdevlieghere Date: Thu May 31 09:28:29 2018 New Revision: 333666 URL: http://llvm.org/viewvc/llvm-project?rev=333666=rev Log: Remove infinite recursion due to FileSpec change. Fixes infinite recursion due to change in how FileSpec deals with removing the last path component. Fixes

Re: [Lldb-commits] Support of MSVC function-level linking

If anyone's working on this I'd suggest adding a test case for the "split code" case as well (where even a single function is split into multiple ranges). MSVC with PGO should help produce hot/cold cold split repros. On Thu, May 31, 2018 at 10:24 AM, Greg Clayton via lldb-commits <

[Lldb-commits] [PATCH] D47470: AppleDWARFIndex: Get function method-ness directly from debug info

clayborg added a comment. After seeing this, it might be nice to put the recursion that follows the DW_AT_specification and DW_AT_abstract_origin and avoids infinite recursion into a DWARFDIE function that takes a callback: typedef bool (*DIECallback)(DWARFDIE ); void

[Lldb-commits] [PATCH] D47551: [IRMemoryMap] Fix the alignment adjustment in Malloc

vsk added a comment. In https://reviews.llvm.org/D47551#1117086, @lhames wrote: > LGTM. > > I haven't looked at process memory management. How hard would your FIXME be > to implement? After looking at this more carefully, I think the FIXME makes a bad prescription. It's based on the

[Lldb-commits] [lldb] r333701 - [lit] Remove the *.test suffix from two test inputs

Author: vedantk Date: Thu May 31 15:09:01 2018 New Revision: 333701 URL: http://llvm.org/viewvc/llvm-project?rev=333701=rev Log: [lit] Remove the *.test suffix from two test inputs This prevents the test inputs from being marked as unsupported tests, due to their lack of RUN lines. Added:

[Lldb-commits] [PATCH] D47612: Add dependency on clang-headers when building LLDB.framework using CMake

xiaobai created this revision. xiaobai added reviewers: clayborg, labath, sas. Herald added a subscriber: mgorny. The LLDB.framework generated when building with CMake + Ninja/Make is completely missing the clang headers. Although the code to copy them exists, we don't even generate them unless

[Lldb-commits] [lldb] r333700 - [IRMemoryMap] Test interleaved Mallocs and Frees

Author: vedantk Date: Thu May 31 15:09:01 2018 New Revision: 333700 URL: http://llvm.org/viewvc/llvm-project?rev=333700=rev Log: [IRMemoryMap] Test interleaved Mallocs and Frees This adds a new command to the ir-memory-map tester: free The argument to free is an index which identifies which

[Lldb-commits] [lldb] r333698 - [IRMemoryMap] Test host-side allocations

Author: vedantk Date: Thu May 31 15:09:00 2018 New Revision: 333698 URL: http://llvm.org/viewvc/llvm-project?rev=333698=rev Log: [IRMemoryMap] Test host-side allocations r333583 introduced testing for IRMemoryMap's process-side allocations (eAllocationPolicyProcessOnly). This adds support for

[Lldb-commits] [lldb] r333699 - [lldb-test] Make logging available to all subcommands

Author: vedantk Date: Thu May 31 15:09:00 2018 New Revision: 333699 URL: http://llvm.org/viewvc/llvm-project?rev=333699=rev Log: [lldb-test] Make logging available to all subcommands Modified: lldb/trunk/tools/lldb-test/lldb-test.cpp Modified: lldb/trunk/tools/lldb-test/lldb-test.cpp URL:

[Lldb-commits] [lldb] r333697 - [IRMemoryMap] Fix the alignment adjustment in Malloc

Author: vedantk Date: Thu May 31 15:08:59 2018 New Revision: 333697 URL: http://llvm.org/viewvc/llvm-project?rev=333697=rev Log: [IRMemoryMap] Fix the alignment adjustment in Malloc This prevents Malloc from allocating the same chunk of memory twice, as a byproduct of an alignment adjustment

[Lldb-commits] [PATCH] D47551: [IRMemoryMap] Fix the alignment adjustment in Malloc

vsk updated this revision to Diff 149355. vsk marked 2 inline comments as done. vsk added a comment. - Address Pavel's feedback, remove a questionable FIXME. https://reviews.llvm.org/D47551 Files: lit/Expr/Inputs/ir-memory-map-basic.test lit/Expr/Inputs/ir-memory-map-overlap1.test

[Lldb-commits] [PATCH] D47551: [IRMemoryMap] Fix the alignment adjustment in Malloc

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL333697: [IRMemoryMap] Fix the alignment adjustment in Malloc (authored by vedantk, committed by ). Herald added a