[Lldb-commits] [PATCH] D66654: Prevent D66398 `TestDataFormatterStdList`-like regressions in the future

clayborg added a comment. What about having the first one that matched being the one that is used and avoid errors all together? We do this with the regex alias stuff already. With regular expressions people are sure to make ones that conflict with each other. Repository: rLLDB LLDB

[Lldb-commits] [PATCH] D66249: [JIT][Breakpoint] Add "BreakpointInjectedSite" and FCB Trampoline

xiaobai added inline comments. Comment at: lldb/source/Breakpoint/BreakpointInjectedSite.cpp:341 + "\n" + " typedef unsigned intuint32_t;\n" + " typedef unsigned long long uint64_t ;\n" labath wrote: > aprantl

[Lldb-commits] [PATCH] D66249: [JIT][Breakpoint] Add "BreakpointInjectedSite" and FCB Trampoline

mib marked 4 inline comments as done. mib added a comment. In D66249#1644791 , @labath wrote: > In D66249#1643594 , @mib wrote: > > > In D66249#1642316 , @labath wrote: > >

[Lldb-commits] [PATCH] D66739: [lldb] Add -w flag for expressions to print compiler warnings even if expression succeeds.

shafik added inline comments. Comment at: lldb/source/Expression/UserExpression.cpp:276 keep_expression_in_memory, generate_debug_info); + if (parse_success) { Is this just white space? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] r369939 - [lldb][NFC] Remove dead code that handles situations where LLDB has no dummy target

Author: teemperor Date: Mon Aug 26 11:12:44 2019 New Revision: 369939 URL: http://llvm.org/viewvc/llvm-project?rev=369939=rev Log: [lldb][NFC] Remove dead code that handles situations where LLDB has no dummy target Summary: We always have a dummy target, so any error handling regarding a

[Lldb-commits] [PATCH] D66654: Prevent D66398 `TestDataFormatterStdList`-like regressions in the future

jankratochvil added a comment. In D66654#1645658 , @clayborg wrote: > What about having the first one that matched being the one that is used and > avoid errors all together? This is how it worked so far before the fix D66398

[Lldb-commits] [PATCH] D66737: [lldb][NFC] Remove dead code that handles situations where LLDB has no dummy target

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb2380c9fa4b: [lldb][NFC] Remove dead code that handles situations where LLDB has no dummy… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] r369970 - [Core] GetAPInt should return an Optional

Author: xiaobai Date: Mon Aug 26 14:09:57 2019 New Revision: 369970 URL: http://llvm.org/viewvc/llvm-project?rev=369970=rev Log: [Core] GetAPInt should return an Optional The current implementation returns a bool for indicating success and whether or not the APInt passed by reference was

[Lldb-commits] [lldb] r369987 - [build_exception] Decode build failure messages

Author: vedantk Date: Mon Aug 26 16:24:45 2019 New Revision: 369987 URL: http://llvm.org/viewvc/llvm-project?rev=369987=rev Log: [build_exception] Decode build failure messages This is so that the test harness pretty-prints build error messages in trace mode, instead of dumping a raw python

[Lldb-commits] [PATCH] D66774: [dotest] Remove long running test "decorator" and re-enable tests.

davide added a comment. Herald added a subscriber: dexonsmith. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66774/new/ https://reviews.llvm.org/D66774 ___ lldb-commits mailing list

[Lldb-commits] [lldb] r370002 - [ConnectionFileDescriptor] Add shutdown check in ::Write.

Author: jdevlieghere Date: Mon Aug 26 18:34:16 2019 New Revision: 370002 URL: http://llvm.org/viewvc/llvm-project?rev=370002=rev Log: [ConnectionFileDescriptor] Add shutdown check in ::Write. The disconnect method sets the shutdown flag to true. This currently only prevents any reads from

[Lldb-commits] [lldb] r370003 - [test] Disable two of the recently (re)enabled tests on Windows.

Author: jdevlieghere Date: Mon Aug 26 18:34:19 2019 New Revision: 370003 URL: http://llvm.org/viewvc/llvm-project?rev=370003=rev Log: [test] Disable two of the recently (re)enabled tests on Windows. This disables two tests on Windows that I re-enabled in r369995. Modified:

[Lldb-commits] [lldb] r369990 - Send error message on failed attach from debugerserver.

Author: jmolenda Date: Mon Aug 26 17:08:27 2019 New Revision: 369990 URL: http://llvm.org/viewvc/llvm-project?rev=369990=rev Log: Send error message on failed attach from debugerserver. Instead of using a magic return error code from debugserver to indicate that an attach failed because of SIP

[Lldb-commits] [PATCH] D59692: [ASTImporter] Fix name conflict handling with different strategies

shafik accepted this revision. shafik added a comment. Other than my two comment this LGTM Comment at: clang/lib/AST/ASTImporter.cpp:3452 << FoundField->getType(); - - return make_error(ImportError::NameConflict); + ConflictingDecls.push_back(FoundField);

[Lldb-commits] [PATCH] D66774: [dotest] Remove long running test "decorator" and re-enable tests.

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added a reviewer: jfb. Herald added a project: LLDB. Today I discovered the `skipLongRunningTest` decorator and to my surprise all the tests were passing without the decorator. They don't seem to be that expensive

[Lldb-commits] [PATCH] D66774: [dotest] Remove long running test "decorator" and re-enable tests.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL369995: [dotest] Remove long running test decorator and re-enable tests. (authored by JDevlieghere, committed by ).

[Lldb-commits] [lldb] r369995 - [dotest] Remove long running test "decorator" and re-enable tests.

Author: jdevlieghere Date: Mon Aug 26 17:18:22 2019 New Revision: 369995 URL: http://llvm.org/viewvc/llvm-project?rev=369995=rev Log: [dotest] Remove long running test "decorator" and re-enable tests. Today I discovered the skipLongRunningTest decorator and to my surprise all the tests were

[Lldb-commits] [lldb] r369930 - TestFunctionStarts.py: add synchronization

Author: friss Date: Mon Aug 26 10:14:05 2019 New Revision: 369930 URL: http://llvm.org/viewvc/llvm-project?rev=369930=rev Log: TestFunctionStarts.py: add synchronization We have started to see the no_binary version of this test fail. The reason is that the binary was being removed before the

[Lldb-commits] [PATCH] D66654: Prevent D66398 `TestDataFormatterStdList`-like regressions in the future

jankratochvil updated this revision to Diff 217079. jankratochvil added a comment. Testcase for the regex sanity check is failing - `ValueObject::m_error` remains set even after `type summary clear`. `ValueObject::UpdateValueIfNeeded` will find `did_change_formats==true` but it does not help

[Lldb-commits] [PATCH] D66634: Postfix: move more code out of the PDB plugin

aleksandr.urakov accepted this revision. aleksandr.urakov added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:58 llvm::BumpPtrAllocator

[Lldb-commits] [PATCH] D66654: Prevent D66398 `TestDataFormatterStdList`-like regressions in the future

labath added a reviewer: jingham. labath added a subscriber: jingham. labath added a comment. + @jingham for value object stuff Though I agree with the general principle of this change, the new api which implements it seems extremely confusing. Unfortunately, it's not really clear to me how to

[Lldb-commits] [PATCH] D66633: Breakpad: Add support for parsing STACK WIN records

This revision was automatically updated to reflect the committed changes. Closed by commit rL369892: Breakpad: Add support for parsing STACK WIN records (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES

[Lldb-commits] [lldb] r369892 - Breakpad: Add support for parsing STACK WIN records

Author: labath Date: Mon Aug 26 04:25:28 2019 New Revision: 369892 URL: http://llvm.org/viewvc/llvm-project?rev=369892=rev Log: Breakpad: Add support for parsing STACK WIN records Summary: The fields that aren't useful for us right now are simply ignored. Reviewers: amccarth, markmentovai

[Lldb-commits] [PATCH] D66249: [JIT][Breakpoint] Add "BreakpointInjectedSite" and FCB Trampoline

labath added a subscriber: xiaobai. labath added a comment. In D66249#1643594 , @mib wrote: > In D66249#1642316 , @labath wrote: > > > A bunch more comments from me. So far, I've only tried to highlight the > >

[Lldb-commits] [PATCH] D66655: [lldb] Fix x86 compilation

leonid.mashinskiy updated this revision to Diff 217101. leonid.mashinskiy added a comment. Updated used guarding macros to cut-off ARM and ARM64 architectures as @tatyana-krasnukha mentioned Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66655/new/

[Lldb-commits] [PATCH] D66634: Postfix: move more code out of the PDB plugin

This revision was automatically updated to reflect the committed changes. labath marked an inline comment as done. Closed by commit rL369894: Postfix: move more code out of the PDB plugin (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[Lldb-commits] [lldb] r369894 - Postfix: move more code out of the PDB plugin

Author: labath Date: Mon Aug 26 04:44:14 2019 New Revision: 369894 URL: http://llvm.org/viewvc/llvm-project?rev=369894=rev Log: Postfix: move more code out of the PDB plugin Summary: Previously we moved the code which parses a single expression out of the PDB plugin, because that was useful for

[Lldb-commits] [lldb] r369880 - [lldb][NFC] Add ProcessInfo::GetNameAsStringRef to simplify some code

Author: teemperor Date: Mon Aug 26 01:22:52 2019 New Revision: 369880 URL: http://llvm.org/viewvc/llvm-project?rev=369880=rev Log: [lldb][NFC] Add ProcessInfo::GetNameAsStringRef to simplify some code Modified: lldb/trunk/include/lldb/Utility/ProcessInfo.h

[Lldb-commits] [lldb] r369885 - [lldb] Construct the dummy target when the first Debugger object is constructed

Author: teemperor Date: Mon Aug 26 02:20:59 2019 New Revision: 369885 URL: http://llvm.org/viewvc/llvm-project?rev=369885=rev Log: [lldb] Construct the dummy target when the first Debugger object is constructed Summary: We should always have a dummy target, so we might as well construct it

[Lldb-commits] [PATCH] D66581: [lldb] Construct the dummy target when the first Dummy object is constructed

This revision was automatically updated to reflect the committed changes. Closed by commit rL369885: [lldb] Construct the dummy target when the first Debugger object is constructed (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[Lldb-commits] [PATCH] D66634: Postfix: move more code out of the PDB plugin

amccarth added a comment. I have a couple inline questions. After that, it looks fine. Comment at: lldb/trunk/source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:61 + for (auto it = parsed.begin(), end = parsed.end(); it != end; ++it) { // Emplace

[Lldb-commits] [PATCH] D66737: [lldb][NFC] Remove dead code that handles situations where LLDB has no dummy target

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This is awesome. Thanks for doing this. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66737/new/ https://reviews.llvm.org/D66737

[Lldb-commits] [lldb] r369908 - [ProcessWindows] Remove equivalent macros

Author: tkrasnukha Date: Mon Aug 26 06:35:59 2019 New Revision: 369908 URL: http://llvm.org/viewvc/llvm-project?rev=369908=rev Log: [ProcessWindows] Remove equivalent macros Modified: lldb/trunk/source/Plugins/Process/Windows/Common/x64/RegisterContextWindows_x64.cpp

[Lldb-commits] [PATCH] D66739: [lldb] Add -w flag for expressions to print compiler warnings even if expression succeeds.

teemperor created this revision. teemperor added a reviewer: LLDB. Herald added subscribers: lldb-commits, abidh. Herald added a project: LLDB. teemperor edited the summary of this revision. Currently if you evaluate for example "expression int" the user just sees nothing and has no way of

[Lldb-commits] [PATCH] D59692: [ASTImporter] Fix name conflict handling

martong updated this revision to Diff 217135. martong added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. - Use resulting Name from HandleNameConflict if set - Add ODRHandling strategies - Refactor tests, to avoid some code repetition Repository: rG LLVM

[Lldb-commits] [PATCH] D66655: [lldb] Fix x86 compilation

leonid.mashinskiy updated this revision to Diff 217140. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66655/new/ https://reviews.llvm.org/D66655 Files: source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_WoW64.cpp

[Lldb-commits] [lldb] r369905 - Fix windows build after r369894

Author: labath Date: Mon Aug 26 05:42:32 2019 New Revision: 369905 URL: http://llvm.org/viewvc/llvm-project?rev=369905=rev Log: Fix windows build after r369894 Constructing a std::vector from a llvm::map_range fails on windows, apparently because std::vector expects the input iterator to have a

[Lldb-commits] [lldb] r369904 - Fix a type mismatch error in GDBRemoteCommunicationServerCommon

Author: labath Date: Mon Aug 26 05:42:28 2019 New Revision: 369904 URL: http://llvm.org/viewvc/llvm-project?rev=369904=rev Log: Fix a type mismatch error in GDBRemoteCommunicationServerCommon GetU64 returns a uint64_t. Don't store it in size_t as that is only 32-bit on 32-bit platforms.

[Lldb-commits] [lldb] r369906 - ProcessInstanceInfo: Fix dumping of invalid user ids

Author: labath Date: Mon Aug 26 06:03:21 2019 New Revision: 369906 URL: http://llvm.org/viewvc/llvm-project?rev=369906=rev Log: ProcessInstanceInfo: Fix dumping of invalid user ids Don't attempt to print invalid user ids. Previously, these would come out as UINT32_MAX, or as an assertion

[Lldb-commits] [lldb] r369907 - Move ProcessInstanceInfoTest to Utility

Author: labath Date: Mon Aug 26 06:07:02 2019 New Revision: 369907 URL: http://llvm.org/viewvc/llvm-project?rev=369907=rev Log: Move ProcessInstanceInfoTest to Utility The class under test was moved in r355342. This moves the test code too. Added:

[Lldb-commits] [PATCH] D65646: [lldb] Print better diagnostics for user expressions.

teemperor added a reviewer: LLDB. teemperor added a comment. ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65646/new/ https://reviews.llvm.org/D65646 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D59692: [ASTImporter] Fix name conflict handling with different strategies

martong added a comment. @shafik I have updated the patch with ODR handling strategies as per our discusson. For the record I copy our discussion here: On Sat, Aug 24, 2019 at 12:50 AM Shafik Yaghmour wrote: > Apologies, I missed this earlier! > > On Wed, Aug 21, 2019 at 2:44 AM Gábor

[Lldb-commits] [lldb] r369910 - Really fix the type mismatch error in GDBRemoteCommunicationServerCommon

Author: labath Date: Mon Aug 26 06:56:33 2019 New Revision: 369910 URL: http://llvm.org/viewvc/llvm-project?rev=369910=rev Log: Really fix the type mismatch error in GDBRemoteCommunicationServerCommon My previous attempt in attempt in r369904 actually broke the 32bit build because File::Read

[Lldb-commits] [PATCH] D66655: [lldb] Fix x86 compilation

tatyana-krasnukha added a comment. Macros `__x86_64__` and `_M_X64` are more common than AMD-branded, though there is no functional difference (unless using old versions of the Intel compiler). Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66655/new/

[Lldb-commits] [PATCH] D66737: [lldb][NFC] Remove dead code that handles situations where LLDB has no dummy target

teemperor created this revision. teemperor added a reviewer: labath. Herald added subscribers: lldb-commits, abidh. Herald added a project: LLDB. We always have a dummy target, so any error handling regarding a missing dummy target is dead code now. Also makes the CommandObject methods that

[Lldb-commits] [PATCH] D66739: [lldb] Add -w flag for expressions to print compiler warnings even if expression succeeds.

labath added a comment. You could avoid the business with adding a flag to `self.expect` (which has enough flags already) by just making this a lit test. :) Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66739/new/ https://reviews.llvm.org/D66739

[Lldb-commits] [PATCH] D66742: Obliterate LLDB_CONFIGURATION_BUILDANDINTEGRATION

labath created this revision. labath added reviewers: jingham, sgraenitz. Herald added a subscriber: emaste. With the XCode project gone, there doesn't seem to be anything setting this macro anymore -- and the macro wasn't doing much anyway. https://reviews.llvm.org/D66742 Files:

[Lldb-commits] [PATCH] D66744: NativeProcessLinux: Remove some register context boilerplate

labath created this revision. labath added reviewers: mgorny, jankratochvil, omjavaid, alexandreyy, uweigand. Herald added subscribers: kbarton, javed.absar, nemanjai. This patch follows the spirit of D63594 , and removes some null checks for things which should

[Lldb-commits] [PATCH] D66739: [lldb] Add -w flag for expressions to print compiler warnings even if expression succeeds.

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Target/Target.h:1106 + std::string *fixed_expression = nullptr, ValueObject *ctx_obj = nullptr, + std::string *warnings = nullptr); Is there anyway we could store this and things like

[Lldb-commits] [PATCH] D66745: DWARFExpression: Simplify class interface

labath created this revision. labath added reviewers: JDevlieghere, clayborg. Herald added a subscriber: aprantl. The DWARFExpression methods have a lot of arguments. This removes two of them by removing the ability to slice the expression via two offset+size parameters. This is a functionality

[Lldb-commits] [PATCH] D66655: [lldb] Fix x86 compilation

tatyana-krasnukha added a comment. A few typos remained after copy-pasting Comment at: source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_i386.cpp:279 // This is likely an internal register for lldb use only and should not be // directly queried.

[Lldb-commits] [lldb] r369922 - [dotest] Print invocation when encountering an error.

Author: jdevlieghere Date: Mon Aug 26 09:08:53 2019 New Revision: 369922 URL: http://llvm.org/viewvc/llvm-project?rev=369922=rev Log: [dotest] Print invocation when encountering an error. With this patch dotest.py will print the full invocation whenever it fails to parse its arguments. The