[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Support encoding working directories in a VFS mapping.

sammccall added a comment. In D65677#1627576 , @JDevlieghere wrote: > After some brainstorming I've identified a few other approaches that should > better reflect the transience of the current working directory: > > - We can modify the VFS to have a

[Lldb-commits] [lldb] r370174 - [lldb][NFC] Update documentation of Handle[Argument]Completion

Author: teemperor Date: Wed Aug 28 02:02:32 2019 New Revision: 370174 URL: http://llvm.org/viewvc/llvm-project?rev=370174=rev Log: [lldb][NFC] Update documentation of Handle[Argument]Completion We no longer have return values or any of the mentioned arguments in these functions since the

[Lldb-commits] [PATCH] D66863: [lldb] Unify target checking in CommandObject

teemperor created this revision. teemperor added a reviewer: labath. Herald added subscribers: lldb-commits, abidh. Herald added a project: LLDB. We currently have several CommandObjects that manually reimplement the checking for a selected target or a target in the execution context (which is

[Lldb-commits] [lldb] r370186 - [lldb][NFC] Test custom C++ operators

Author: teemperor Date: Wed Aug 28 04:18:47 2019 New Revision: 370186 URL: http://llvm.org/viewvc/llvm-project?rev=370186=rev Log: [lldb][NFC] Test custom C++ operators Added: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/operators/

[Lldb-commits] [lldb] r370185 - [lldb] Fix and test completion for ambiguous long options

Author: teemperor Date: Wed Aug 28 03:17:23 2019 New Revision: 370185 URL: http://llvm.org/viewvc/llvm-project?rev=370185=rev Log: [lldb] Fix and test completion for ambiguous long options The refactoring patch for the option completion broke the completion for ambiguous long options. As this

[Lldb-commits] [lldb] r370194 - [lldb][NFC] Extend operator test case with conversion operators

Author: teemperor Date: Wed Aug 28 05:14:39 2019 New Revision: 370194 URL: http://llvm.org/viewvc/llvm-project?rev=370194=rev Log: [lldb][NFC] Extend operator test case with conversion operators Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/operators/main.cpp Modified:

[Lldb-commits] [lldb] r370195 - [lldb][NFC] Actually run all expects in lang/cpp/operators

Author: teemperor Date: Wed Aug 28 05:32:58 2019 New Revision: 370195 URL: http://llvm.org/viewvc/llvm-project?rev=370195=rev Log: [lldb][NFC] Actually run all expects in lang/cpp/operators Apparently inline tests stop running anything after an empty line behind an self.expect, which is a very

[Lldb-commits] [lldb] r370179 - [lldb][NFC] Get rid of C-strings in HandleOptionCompletion

Author: teemperor Date: Wed Aug 28 02:32:30 2019 New Revision: 370179 URL: http://llvm.org/viewvc/llvm-project?rev=370179=rev Log: [lldb][NFC] Get rid of C-strings in HandleOptionCompletion Modified: lldb/trunk/source/Interpreter/Options.cpp Modified:

[Lldb-commits] [lldb] r370199 - [lldb][NFC] Test named operators like new and function names that might confuse LLDB

Author: teemperor Date: Wed Aug 28 06:33:52 2019 New Revision: 370199 URL: http://llvm.org/viewvc/llvm-project?rev=370199=rev Log: [lldb][NFC] Test named operators like new and function names that might confuse LLDB Modified:

[Lldb-commits] [lldb] r370201 - [lldb][NFC] Refactor and document ClangASTContext::IsOperator

Author: teemperor Date: Wed Aug 28 06:46:01 2019 New Revision: 370201 URL: http://llvm.org/viewvc/llvm-project?rev=370201=rev Log: [lldb][NFC] Refactor and document ClangASTContext::IsOperator Should make it clearer what actually is going on in there. Modified:

[Lldb-commits] [lldb] r370226 - [dotest] Remove -q (quiet) flag.

Author: jdevlieghere Date: Wed Aug 28 09:28:58 2019 New Revision: 370226 URL: http://llvm.org/viewvc/llvm-project?rev=370226=rev Log: [dotest] Remove -q (quiet) flag. This patch removes the -q (quiet) flag and changing the default behavior. Currently the flag serves two purposes that are

[Lldb-commits] [lldb] r370227 - [TestCppOperators] Enable TestCppOperators on Windows.

Author: jdevlieghere Date: Wed Aug 28 09:29:00 2019 New Revision: 370227 URL: http://llvm.org/viewvc/llvm-project?rev=370227=rev Log: [TestCppOperators] Enable TestCppOperators on Windows. This test is passing on the Windows bot: Unexpected Passing Tests (1): lldb-Suite ::

[Lldb-commits] [PATCH] D66858: POSIX DYLD: add workaround for android L loader

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM. Thanks. I'm going to clean the diff downstream. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66858/new/ https://reviews.llvm.org/D66858

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Support encoding working directories in a VFS mapping.

JDevlieghere added a comment. In D65677#1648506 , @sammccall wrote: > In D65677#1627576 , @JDevlieghere > wrote: > > > After some brainstorming I've identified a few other approaches that should > > better

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Support encoding working directories in a VFS mapping.

sammccall added a comment. In D65677#1649291 , @JDevlieghere wrote: > In D65677#1648506 , @sammccall wrote: > > > In D65677#1627576 , @JDevlieghere > > wrote: > > > > >

[Lldb-commits] [PATCH] D66837: [dotest] Remove -q (quiet) flag.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL370226: [dotest] Remove -q (quiet) flag. (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald

[Lldb-commits] [PATCH] D66863: [lldb] Unify target checking in CommandObject

amccarth added a comment. I support anything that reduces the code path differences between user-entered commands and their SBAPI counterparts. Thanks for doing this! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66863/new/ https://reviews.llvm.org/D66863

[Lldb-commits] [PATCH] D66863: [lldb] Unify target checking in CommandObject

jingham added a comment. Herald added a subscriber: JDevlieghere. The whole command flags was a late addition, but we were using it for new commands and "when you touch it" kind of changes. That seems to have stalled the conversion, so thanks for completing this! As a minor style thing, prior

[Lldb-commits] [PATCH] D66893: [dotest] Don't try to guess the llvm binary dir.

This revision was automatically updated to reflect the committed changes. Closed by commit rL370232: [dotest] Dont try to guess the llvm binary dir. (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

Re: [Lldb-commits] [lldb] r370199 - [lldb][NFC] Test named operators like new and function names that might confuse LLDB

This test seems to be missing at least the address-of, delete and the comma operator in this test. Probably should cover array delete and new as well. > On Aug 28, 2019, at 6:33 AM, Raphael Isemann via lldb-commits > wrote: > > Author: teemperor > Date: Wed Aug 28 06:33:52 2019 > New

[Lldb-commits] [lldb] r370237 - [test] Temporarily disable two tests on Windows

Author: jdevlieghere Date: Wed Aug 28 11:04:14 2019 New Revision: 370237 URL: http://llvm.org/viewvc/llvm-project?rev=370237=rev Log: [test] Temporarily disable two tests on Windows Disable the two failing tests until Raphael has a chance to investigate: Failing Tests (2): lldb-Suite ::

[Lldb-commits] [PATCH] D66858: POSIX DYLD: add workaround for android L loader

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. It looks like this code would be better placed inside `UpdateBaseAddrIfNecessary`, as that's exactly what it is doing. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D66858: POSIX DYLD: add workaround for android L loader

labath added a comment. My other concerns about this patch are: - the base_addr field is the *difference* between the preferred load address encoded in the object file, and the actual load address. This means that this workaround will fire every time the object is loaded at it's preferred load

[Lldb-commits] [PATCH] D66863: [lldb] Unify target checking in CommandObject

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Awesome. In D66863#1649436 , @jingham wrote: > As a minor style thing, prior to this change CommandObjectThreadStepUntil > required a thread, but

[Lldb-commits] [PATCH] D66896: [dotest] Don't try to guess the lldb binary & python dir.

This revision was automatically updated to reflect the committed changes. Closed by commit rL370234: [dotest] Dont try to guess the lldb binary python dir. (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r370235 - [dotest] Remove outdates TODO

Author: jdevlieghere Date: Wed Aug 28 10:38:50 2019 New Revision: 370235 URL: http://llvm.org/viewvc/llvm-project?rev=370235=rev Log: [dotest] Remove outdates TODO The referenced function `find_test_files_in_dir_tree` no longer exists. Modified:

[Lldb-commits] [lldb] r370234 - [dotest] Don't try to guess the lldb binary & python dir.

Author: jdevlieghere Date: Wed Aug 28 10:38:48 2019 New Revision: 370234 URL: http://llvm.org/viewvc/llvm-project?rev=370234=rev Log: [dotest] Don't try to guess the lldb binary & python dir. Now that all supported build systems create a valid dotest.py invocation, we no longer need to guess the

[Lldb-commits] [PATCH] D66896: [dotest] Don't try to guess the lldb binary & python dir.

labath added a comment. Woohoo Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66896/new/ https://reviews.llvm.org/D66896 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r370232 - [dotest] Don't try to guess the llvm binary dir.

Author: jdevlieghere Date: Wed Aug 28 10:06:28 2019 New Revision: 370232 URL: http://llvm.org/viewvc/llvm-project?rev=370232=rev Log: [dotest] Don't try to guess the llvm binary dir. Now that all supported build systems create a valid dotest.py invocation, we no longer need to guess the

[Lldb-commits] [lldb] r370231 - [dotest] Don't spend time replacing spaces in print output.

Author: jdevlieghere Date: Wed Aug 28 10:06:26 2019 New Revision: 370231 URL: http://llvm.org/viewvc/llvm-project?rev=370231=rev Log: [dotest] Don't spend time replacing spaces in print output. Replacing all spaces with dashes seems like a lot of needless work for a string that's just printed.

[Lldb-commits] [PATCH] D66896: [dotest] Don't try to guess the lldb binary & python dir.

JDevlieghere created this revision. JDevlieghere added reviewers: davide, jasonmolenda. Herald added a subscriber: teemperor. Herald added a project: LLDB. Now that all supported build systems create a valid dotest.py invocation, we no longer need to guess the location of the lldb binary and

[Lldb-commits] [PATCH] D66858: POSIX DYLD: add workaround for android L loader

xiaobai accepted this revision. xiaobai added a comment. Herald added a subscriber: JDevlieghere. LGTM, small typo tho Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp:553 + // reported. Attempt to discover it based on the load address of the object +

[Lldb-commits] [PATCH] D66893: [dotest] Don't try to guess the llvm binary dir.

JDevlieghere created this revision. JDevlieghere added reviewers: davide, jasonmolenda. Herald added a subscriber: teemperor. Herald added a project: LLDB. Now that all supported build systems create a valid `dotest.py` invocation, we no longer need to guess the directory where any of the tools

[Lldb-commits] [PATCH] D66893: [dotest] Don't try to guess the llvm binary dir.

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66893/new/ https://reviews.llvm.org/D66893 ___

[Lldb-commits] [PATCH] D66908: [dotest] Remove the -# option

JDevlieghere abandoned this revision. JDevlieghere added a comment. Alright, let's keep it  Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66908/new/ https://reviews.llvm.org/D66908 ___ lldb-commits mailing list

[Lldb-commits] [lldb] r370278 - [dotest] Make dotest.py invocation repeatable

Author: jdevlieghere Date: Wed Aug 28 16:54:23 2019 New Revision: 370278 URL: http://llvm.org/viewvc/llvm-project?rev=370278=rev Log: [dotest] Make dotest.py invocation repeatable This removes support for reading the LLDB_TEST_ARGUMENTS environment variable and instead requires all arguments to

[Lldb-commits] [PATCH] D66912: [dotest] Make dotest.py invocation repeatable

This revision was automatically updated to reflect the committed changes. Closed by commit rL370278: [dotest] Make dotest.py invocation repeatable (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D66908: [dotest] Remove the -# option

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added a project: LLDB. Rerunning the test suite is not something that dotest.py should be responsible for. This is another step towards making lit the driver and dotest the test framework. Repository: rLLDB LLDB

[Lldb-commits] [PATCH] D66908: [dotest] Remove the -# option

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. I use -# for running single tests multiple times. This is useful particularly if you have a test that only fails sometimes, you can do: $ lldb-dotest -p testname.py -d -#400

[Lldb-commits] [PATCH] D66912: [dotest] Make dotest.py invocation repeatable

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added a project: LLDB. This removes support for reading the `LLDB_TEST_ARGUMENTS` environment variable and instead requires all arguments to be specified as part of the invocation. This ensures that dotest.py

[Lldb-commits] [PATCH] D66915: [TSanRuntime] Upstream thread swift race detector.

davide created this revision. davide added a reviewer: kubamracek. Herald added a project: LLDB. This is self-contained, and doesn't need anything in the compiler to work. Mainly to reduce the diff between upstream and downstream. Patch by Kuba Mracek! Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D66841: Skip test_target_create_invalid_core_file on Windows

amccarth abandoned this revision. amccarth added a comment. Somebody else already did this while I was waiting for review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66841/new/ https://reviews.llvm.org/D66841 ___ lldb-commits mailing

[Lldb-commits] [lldb] r370255 - [Core] Use GetAPInt instead of constructing APInts in place

Author: xiaobai Date: Wed Aug 28 13:15:57 2019 New Revision: 370255 URL: http://llvm.org/viewvc/llvm-project?rev=370255=rev Log: [Core] Use GetAPInt instead of constructing APInts in place GetAPInt should be able to handle all cases. I have plans to generalize the float dumping logic and this

[Lldb-commits] [lldb] r370264 - [dotest] Remove --rerun-max-file-threshold

Author: jdevlieghere Date: Wed Aug 28 14:24:41 2019 New Revision: 370264 URL: http://llvm.org/viewvc/llvm-project?rev=370264=rev Log: [dotest] Remove --rerun-max-file-threshold This variable corresponding to this argument is set but never read. Modified:

[Lldb-commits] [lldb] r370266 - [dotest] Remove --event-add-entries

Author: jdevlieghere Date: Wed Aug 28 14:31:53 2019 New Revision: 370266 URL: http://llvm.org/viewvc/llvm-project?rev=370266=rev Log: [dotest] Remove --event-add-entries This argument was used by dosep.py to pass information around from the workers. With dosep.py gone, I'm fairly sure we don't

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Support encoding working directories in a VFS mapping.

JDevlieghere added a comment. In D65677#1649329 , @sammccall wrote: > In D65677#1649291 , @JDevlieghere > wrote: > > > It's funny you say that, because the code to resolve relative paths is > > almost identical

[Lldb-commits] [lldb] r370259 - [dotest] Centralize and simplify session dir logic (NFC)

Author: jdevlieghere Date: Wed Aug 28 13:54:17 2019 New Revision: 370259 URL: http://llvm.org/viewvc/llvm-project?rev=370259=rev Log: [dotest] Centralize and simplify session dir logic (NFC) I was looking at the session directory logic for unrelated reasons and noticed that the logic spread out

[Lldb-commits] [PATCH] D66920: [dotest] Remove deprecated loggin through env variables.

JDevlieghere created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. JDevlieghere edited the summary of this revision. JDevlieghere added a reviewer: LLDB. JDevlieghere added a reviewer: labath. It used to be possible to enable logging through environment

[Lldb-commits] [lldb] r370286 - [TSanRuntime] Upstream thread swift race detector.

Author: davide Date: Wed Aug 28 18:39:26 2019 New Revision: 370286 URL: http://llvm.org/viewvc/llvm-project?rev=370286=rev Log: [TSanRuntime] Upstream thread swift race detector. Summary: This is self-contained, and doesn't need anything in the compiler to work. Mainly to reduce the diff between

[Lldb-commits] [lldb] r370287 - [python] remove testsuite vestiges.

Author: davide Date: Wed Aug 28 18:45:10 2019 New Revision: 370287 URL: http://llvm.org/viewvc/llvm-project?rev=370287=rev Log: [python] remove testsuite vestiges. Removed: lldb/trunk/packages/Python/lldbsuite/test/attic/ ___ lldb-commits mailing

[Lldb-commits] [PATCH] D66917: [dotest] Remove the curses result formatter.

JDevlieghere created this revision. JDevlieghere added reviewers: LLDB, jingham. Herald added subscribers: lldb-commits, abidh. Herald added a project: LLDB. This removes the curses result formatter which appears to be broken. Passing `--curses` to `dotest.py` screws up my terminal and doesn't

[Lldb-commits] [PATCH] D66915: [TSanRuntime] Upstream thread swift race detector.

This revision was automatically updated to reflect the committed changes. Closed by commit rL370286: [TSanRuntime] Upstream thread swift race detector. (authored by davide, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: