[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

aleksandr.urakov updated this revision to Diff 219853. aleksandr.urakov added a comment. Update diff due to Pavel's requests. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67347/new/ https://reviews.llvm.org/D67347 Files:

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

aleksandr.urakov marked 4 inline comments as done. aleksandr.urakov added a comment. Thanks all for taking a look! In D67347#1666509 , @amccarth wrote: > This patch is pretty large. It might be easier to break it up into a series > of small steps to

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk marked an inline comment as done. kwk added inline comments. Comment at: lldb/lit/Modules/ELF/minidebuginfo-corrupt-xz.yaml:1 +# REQUIRES: system-linux, lzma + labath wrote: > system-linux shouldn't be required here. One of the reasons I wanted to have >

[Lldb-commits] [lldb] r371734 - [lldb] Remove duplicated breakpoint tests

Author: teemperor Date: Thu Sep 12 07:07:16 2019 New Revision: 371734 URL: http://llvm.org/viewvc/llvm-project?rev=371734=rev Log: [lldb] Remove duplicated breakpoint tests After reverting the deletion of the functionalities/breakpoint tests, we now have some tests twice in the test/ folder

[Lldb-commits] [lldb] r371738 - [lldb][NFC] Simplify makefiles also for breakpoint tests

Author: teemperor Date: Thu Sep 12 07:21:59 2019 New Revision: 371738 URL: http://llvm.org/viewvc/llvm-project?rev=371738=rev Log: [lldb][NFC] Simplify makefiles also for breakpoint tests These tests were temporarily missing when the big Makefile simplification patch landed, so this just applies

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

clayborg added a comment. My opinion is we need to be able to ask both the SymbolFile and ObjectFile for unwind plans in the API, but we can always just ask the SymbolFile for the unwind plan and the default SymbolFile virtual function can just defer to the ObjectFile. We also need to say "I

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

clayborg added a comment. Added Jason Molenda who owns the unwind stuff so he might be able to comment and help us with this patch. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67347/new/ https://reviews.llvm.org/D67347

[Lldb-commits] [PATCH] D67474: [Reproducer] Add `reproducer dump` command

JDevlieghere updated this revision to Diff 219949. JDevlieghere added a comment. Inspect the current reproducer when in replay mode and no path is specified. Thanks for the suggestions, Jim! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67474/new/ https://reviews.llvm.org/D67474

[Lldb-commits] [PATCH] D67520: Add pretty printing of Clang "bitfield" enums

friss created this revision. friss added reviewers: jingham, labath. Using enumerators as flags is standard practice. This patch adds support to LLDB to display such enum values symbolically, eg: (E) e1 = A | B If enumerators don't cover the whole value, the remaining bits are displayed as

[Lldb-commits] [PATCH] D67520: Add pretty printing of Clang "bitfield" enums

jingham added a comment. Also, since in C++ you can't do: enum bitfield ac = A | C; it's fairly common practice to pass or'ed elements from the enum as an int of some sort. This feature would be really handy in that case, but the way you would get at it is not through frame var (since you

[Lldb-commits] [PATCH] D67520: Add pretty printing of Clang "bitfield" enums

jingham added a comment. Your description says that if there are bits not belonging to the enum, you will print them after the enum values are listed. But you don't have a test for that. I thought you were going to use the "nonsense" var for that, but then you didn't... CHANGES SINCE LAST

[Lldb-commits] [PATCH] D67523: [Reproducer] Move GDB packet struct into the reproducer. (NFC)

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added a project: LLDB. To support dumping the reproducer's GDB remote packets, we need the (de)serialization logic to live in the reproducer rather than the GDB remote plugin. This patch moves the corresponding code

[Lldb-commits] [PATCH] D67472: [Target] Move InferiorCall to Process

jingham added a comment. In D67472#1668505 , @clayborg wrote: > lgtm. Jim? I already commented above. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67472/new/ https://reviews.llvm.org/D67472

[Lldb-commits] [PATCH] D67520: Add pretty printing of Clang "bitfield" enums

jingham added a comment. The code looks fine to me. Comment at: source/Symbol/ClangASTContext.cpp:9502 +++num_enumerators; +if (val == enum_svalue) { + s->PutCString(enumerator->getNameAsString()); Can you put a comment here like: // TADA - we

[Lldb-commits] [PATCH] D66638: Unwind: Add a stack scanning mechanism to support win32 unwinding

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Sorry for taking so long to look at this one -- it looks like a good solution to this. Greg's idea of an additional heuristic when walking the stack and having a POSSIBLE return

[Lldb-commits] [PATCH] D67472: [Target] Move InferiorCall to Process

clayborg accepted this revision. clayborg added a comment. lgtm. Jim? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67472/new/ https://reviews.llvm.org/D67472 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D66638: Unwind: Add a stack scanning mechanism to support win32 unwinding

amccarth accepted this revision. amccarth added a comment. My concerns are satisfied. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66638/new/ https://reviews.llvm.org/D66638 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D67523: [Reproducer] Move GDB packet struct into the reproducer. (NFC)

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. Easy peasy. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67523/new/ https://reviews.llvm.org/D67523 ___

[Lldb-commits] [PATCH] D67523: [Reproducer] Move GDB packet struct into the reproducer. (NFC)

jingham added a comment. It seems weird to me to have the GDBRemotePacket class live in the repro namespace. There's nothing particularly Reproducer specific about it, and it clearly gets used outside the reproducer as well. Wouldn't it make more sense to have this in Utils? Repository:

[Lldb-commits] [PATCH] D67523: [Reproducer] Move GDB packet struct into the reproducer. (NFC)

jingham added a comment. There's already Utils/StreamGDBRemote.cpp... It might be natural to stick the class in there? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67523/new/ https://reviews.llvm.org/D67523 ___

[Lldb-commits] [PATCH] D67523: [Reproducer] Move GDB Remote Packet into Utility. (NFC)

JDevlieghere updated this revision to Diff 220019. JDevlieghere retitled this revision from "[Reproducer] Move GDB packet struct into the reproducer. (NFC)" to "[Reproducer] Move GDB Remote Packet into Utility. (NFC)". JDevlieghere edited the summary of this revision. JDevlieghere added a

[Lldb-commits] [PATCH] D67472: [Target] Move InferiorCall to Process

This revision was automatically updated to reflect the committed changes. Closed by commit rL371796: [Target] Move InferiorCall to Process (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D67523: [Reproducer] Move GDB packet struct into the reproducer. (NFC)

JDevlieghere added a comment. In D67523#1668608 , @jingham wrote: > It seems weird to me to have the GDBRemotePacket class live in the repro > namespace. There's nothing particularly Reproducer specific about it, and it > clearly gets used outside the

[Lldb-commits] [lldb] r371784 - [NFC] Sort source files in Utility/CMakeLists.txt

Author: jdevlieghere Date: Thu Sep 12 15:34:59 2019 New Revision: 371784 URL: http://llvm.org/viewvc/llvm-project?rev=371784=rev Log: [NFC] Sort source files in Utility/CMakeLists.txt Modified: lldb/trunk/source/Utility/CMakeLists.txt Modified: lldb/trunk/source/Utility/CMakeLists.txt URL:

[Lldb-commits] [PATCH] D67472: [Target] Move InferiorCall to Process

xiaobai updated this revision to Diff 220018. xiaobai added a comment. Rename InferiorCall to CallNoArgNoReturnFunc make CallNoArgReturnFunc public Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67472/new/ https://reviews.llvm.org/D67472 Files:

[Lldb-commits] [PATCH] D67472: [Target] Move InferiorCall to Process

jingham added a comment. I don't think CallNoArgNoReturnFunc is the right name. This routine calls a function that takes no arguments but returns a void *. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67472/new/ https://reviews.llvm.org/D67472

[Lldb-commits] [PATCH] D67472: [Target] Move InferiorCall to Process

xiaobai updated this revision to Diff 220023. xiaobai added a comment. Rename function in question to CallVoidArgVoidPtrReturn Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67472/new/ https://reviews.llvm.org/D67472 Files:

[Lldb-commits] [PATCH] D67472: [Target] Move InferiorCall to Process

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Excellent! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67472/new/ https://reviews.llvm.org/D67472

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

jasonmolenda added a comment. Hi Aleksandr, nice job getting this working. I read over the patch and had a couple of initial questions. I don't understand the creation of the ICallFrameInfo base class. All of the unwind info providers (things which parse their own format and output an

[Lldb-commits] [lldb] r371796 - [Target] Move InferiorCall to Process

Author: xiaobai Date: Thu Sep 12 17:02:05 2019 New Revision: 371796 URL: http://llvm.org/viewvc/llvm-project?rev=371796=rev Log: [Target] Move InferiorCall to Process Summary: InferiorCall is only ever used in Process, and it is not specific to POSIX. By moving it to Process, we can remove all

[Lldb-commits] [lldb] r371795 - The setUp/tearDown methods I added mssed up the test function; reorder.

Author: jmolenda Date: Thu Sep 12 17:01:49 2019 New Revision: 371795 URL: http://llvm.org/viewvc/llvm-project?rev=371795=rev Log: The setUp/tearDown methods I added mssed up the test function; reorder. Thanks to Ted Woodward for catching this one. Modified:

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

amccarth added a comment. I have a couple more questions and some renaming requests. Comment at: lldb/include/lldb/Symbol/DWARFCallFrameInfo.h:74 - void ForEachFDEEntries( - const std::function ); + void ForEachEntries(const std::function ) override;