[Lldb-commits] [PATCH] D64647: [lldb] [Process/NetBSD] Multithread support

mgorny updated this revision to Diff 227295. mgorny added a comment. Another WIP update. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64647/new/ https://reviews.llvm.org/D64647 Files:

[Lldb-commits] [lldb] aafe01f - Upstream diff from swift-lldb.

Author: Adrian Prantl Date: 2019-10-31T09:25:36-07:00 New Revision: aafe01fed4a29090b86432e0356a47a249d5a106 URL: https://github.com/llvm/llvm-project/commit/aafe01fed4a29090b86432e0356a47a249d5a106 DIFF: https://github.com/llvm/llvm-project/commit/aafe01fed4a29090b86432e0356a47a249d5a106.diff

[Lldb-commits] [PATCH] D69667: [lldb] [Process/NetBSD] Add register info for missing register sets

mgorny created this revision. mgorny added reviewers: labath, krytarowski, JDevlieghere. Add info for all register sets supported in NetBSD, particularly for all registers 'expected' by LLDB. This is necessary in order to fix python_api/lldbutil/iter/TestRegistersIterator.py test that currently

[Lldb-commits] [PATCH] D68270: DWARFDebugLoc: Add a function to get the address range of an entry

labath abandoned this revision. labath marked an inline comment as done. labath added a comment. Abandoning. I'll create separate patches with the new implementation. Comment at: lib/DebugInfo/DWARF/DWARFDebugLoc.cpp:291-295 + EntryIterator Absolute = +

[Lldb-commits] [PATCH] D68270: DWARFDebugLoc: Add a function to get the address range of an entry

JDevlieghere added inline comments. Comment at: include/llvm/DebugInfo/DWARF/DWARFDebugLoc.h:138 +llvm::Optional BaseAddr; +std::function(uint32_t)> +AddrOffsetResolver; labath wrote: > Using a callback is consistent with what rnglists code does.

[Lldb-commits] [PATCH] D69641: [Symbol] Change ClangASTContext::GetCXXClassName return type

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb542455dc0f: [Symbol] Change ClangASTContext::GetCXXClassName return type (authored by xiaobai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69641/new/

Re: [Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

I see your concern about source and target paths for Python files, but I also think it is valuable that it is really easy to find examples of using lldb with the Python SB API's - both with toy examples and with fully worked examples. I know people have found and copied from here to good

[Lldb-commits] [lldb] db54245 - [Symbol] Change ClangASTContext::GetCXXClassName return type

Author: Alex Langford Date: 2019-10-31T11:57:37-07:00 New Revision: db542455dc0f5873851e220bf72a8394767c61fb URL: https://github.com/llvm/llvm-project/commit/db542455dc0f5873851e220bf72a8394767c61fb DIFF: https://github.com/llvm/llvm-project/commit/db542455dc0f5873851e220bf72a8394767c61fb.diff

Re: [Lldb-commits] [PATCH] D69555: [zorg] Fix LLDBCmakeBuildFactory

I have removed the extra quotation marks in https://reviews.llvm.org/rZORGe249863ac732. The change applied to staging and will wait the next master restart tonight. Thanks Galina On Thu, Oct 31, 2019 at 3:35 AM Pavel Labath via Phabricator wrote: > > labath added a comment. > > In

[Lldb-commits] [lldb] 54a873b - Fix typeo in CPU_TYPE_ARM64_32 for older SDKs.

Author: Jason Molenda Date: 2019-10-31T14:13:57-07:00 New Revision: 54a873b158bd463db48829407f3939ff9a7be65a URL: https://github.com/llvm/llvm-project/commit/54a873b158bd463db48829407f3939ff9a7be65a DIFF: https://github.com/llvm/llvm-project/commit/54a873b158bd463db48829407f3939ff9a7be65a.diff

[Lldb-commits] [PATCH] D69555: [zorg] Fix LLDBCmakeBuildFactory

labath marked an inline comment as done. labath added a comment. In D69555#1727882 , @stella.stamenova wrote: > Sadly, I think this broke the windows bot now (assuming it got applied to > staging, otherwise I have to figure out what did): > >

[Lldb-commits] [PATCH] D69646: [LLDB] [PECOFF] Fix error handling for executables that object::createBinary error out on

mstorsjo marked an inline comment as done. mstorsjo added inline comments. Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:175-179 +std::string msg = errorToErrorCode(binary.takeError()).message(); +LLDB_LOGF(log, +

[Lldb-commits] [PATCH] D69641: [Symbol] Change ClangASTContext::GetCXXClassName return type

labath accepted this revision. labath added a comment. awesome Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69641/new/ https://reviews.llvm.org/D69641 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D69502: [LLDB] [PECOFF] Don't crash in ReadImageDataByRVA for addresses out of range

labath accepted this revision. labath added inline comments. Comment at: lldb/test/Shell/Minidump/Windows/Inputs/broken-unwind.exe.yaml:29 + ExceptionTable: +RelativeVirtualAddress: 12303 +Size:12 Maybe add a comment that this is the thing

[Lldb-commits] [PATCH] D69646: [LLDB] [PECOFF] Fix error handling for executables that object::createBinary error out on

labath accepted this revision. labath added inline comments. Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:175-179 +std::string msg = errorToErrorCode(binary.takeError()).message(); +LLDB_LOGF(log, +

[Lldb-commits] [PATCH] D69619: [lldb/lit] Introduce %clang_host substitutions

labath added a comment. Thanks guys. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69619/new/ https://reviews.llvm.org/D69619 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D69646: [LLDB] [PECOFF] Fix error handling for executables that object::createBinary error out on

mstorsjo updated this revision to Diff 227236. mstorsjo edited the summary of this revision. mstorsjo added a comment. Using LLDB_LOG_ERROR instead of formatting the error to a string before invoking logging macros. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69646/new/

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This looks great to me. Maybe wait a while to see if anyone else has any thoughts on this? This not your fault, but the thing that bothers me about this build process (and which this patch

[Lldb-commits] [PATCH] D69503: [LLDB] [Windows] Don't crash if the debugged process is unable to start up

mstorsjo updated this revision to Diff 227242. mstorsjo edited the summary of this revision. mstorsjo added a comment. Changed to use Adrian's fix suggestion, and added a testcase for it (which only is executed on x86_64, as it uses a pre-canned exe in yaml form, but a similar testcase for

[Lldb-commits] [PATCH] D69502: [LLDB] [PECOFF] Don't crash in ReadImageDataByRVA for addresses out of range

This revision was automatically updated to reflect the committed changes. Closed by commit rG7e1a3076419d: [LLDB] [PECOFF] Dont crash in ReadImageDataByRVA for addresses out of range (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D69502?vs=227183=227246#toc

[Lldb-commits] [PATCH] D69503: [LLDB] [Windows] Don't crash if the debugged process is unable to start up

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG403cd574b6d9: [LLDB] [Windows] Fix Windows-specific race condition in LLDB for session… (authored by mstorsjo).

[Lldb-commits] [PATCH] D69619: [lldb/lit] Introduce %clang_host substitutions

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c739252261e: [lldb/lit] Introduce %clang_host substitutions (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69619/new/

[Lldb-commits] [PATCH] D69031: [LLDB] [test] Use %clang_cl instead of build.py in a few tests

labath added a comment. Ok, https://reviews.llvm.org/D69619 should resolve the issues you encountered, but I'd recommend waiting a while before building on top of that, because it has the potential to cause problems for some configurations. Also stella's bot is still down due to the github

[Lldb-commits] [PATCH] D69031: [LLDB] [test] Use %clang_cl instead of build.py in a few tests

mstorsjo added a comment. In D69031#1728380 , @labath wrote: > Ok, https://reviews.llvm.org/D69619 should resolve the issues you > encountered, but I'd recommend waiting a while before building on top of > that, because it has the potential to cause

[Lldb-commits] [PATCH] D68874: [lldb] Fix offset intersection bug between MPX and AVX registers

This revision was automatically updated to reflect the committed changes. Closed by commit rGe46c6644db84: [lldb] Fix offset intersection bug between MPX and AVX registers (authored by guiandrade, committed by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D69105: minidump: Create memory regions from the sections of loaded modules

This revision was automatically updated to reflect the committed changes. Closed by commit rG193a7bfb697b: minidump: Create memory regions from the sections of loaded modules (authored by labath). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D69646: [LLDB] [PECOFF] Fix error handling for executables that object::createBinary error out on

This revision was automatically updated to reflect the committed changes. Closed by commit rG3db1d138b117: [LLDB] [PECOFF] Fix error handling for executables that object::createBinary… (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 9c73925 - [lldb/lit] Introduce %clang_host substitutions

Author: Pavel Labath Date: 2019-10-31T10:40:37+01:00 New Revision: 9c739252261ea762d1bbbd8234d93c9038711fcd URL: https://github.com/llvm/llvm-project/commit/9c739252261ea762d1bbbd8234d93c9038711fcd DIFF: https://github.com/llvm/llvm-project/commit/9c739252261ea762d1bbbd8234d93c9038711fcd.diff

[Lldb-commits] [lldb] e46c664 - [lldb] Fix offset intersection bug between MPX and AVX registers

Author: Guilherme Andrade Date: 2019-10-31T10:58:17+01:00 New Revision: e46c6644db8432584e82ef7ddfc9d0f36543f205 URL: https://github.com/llvm/llvm-project/commit/e46c6644db8432584e82ef7ddfc9d0f36543f205 DIFF:

[Lldb-commits] [PATCH] D69612: [lldb-vscod] fix build with NDEBUG on windows

labath added a comment. In D69612#1726968 , @labath wrote: > Yes, I used "arc patch". I did check that it preserved the authorship > information, but I did not go into the details of what's in the author field > TBH. I agree it would be better to have

[Lldb-commits] [lldb] 193a7bf - minidump: Create memory regions from the sections of loaded modules

Author: Pavel Labath Date: 2019-10-31T11:24:55+01:00 New Revision: 193a7bfb697b5d2adb1c3d37a9d624aa8131ec35 URL: https://github.com/llvm/llvm-project/commit/193a7bfb697b5d2adb1c3d37a9d624aa8131ec35 DIFF: https://github.com/llvm/llvm-project/commit/193a7bfb697b5d2adb1c3d37a9d624aa8131ec35.diff

[Lldb-commits] [PATCH] D69555: [zorg] Fix LLDBCmakeBuildFactory

labath added a comment. In D69555#1728291 , @labath wrote: > (which actually surprises me a lot) Actually, nevermind. The linux bot fails now in the same way as the windows one (http://lab.llvm.org:8014/builders/lldb-x86_64-debian/builds/6262). Galina,