[Lldb-commits] [PATCH] D74252: Fix+re-enable Assert StackFrame Recognizer on Linux

jankratochvil updated this revision to Diff 243353. jankratochvil retitled this revision from "Fix+re-enable Assert StackFrame Recognizer" to "Fix+re-enable Assert StackFrame Recognizer on Linux". jankratochvil edited the summary of this revision. Herald added a subscriber: jfb. Repository: rG

[Lldb-commits] [PATCH] D74252: Fix+re-enable Assert StackFrame Recognizer on Linux

jankratochvil added a comment. In D74252#1865493 , @mib wrote: > We'd like to avoid registering recognizers multiple times for the same > purpose ... OK, then it could be changed to a regex. Is it fine afterwards? Repository: rG LLVM Github

[Lldb-commits] [PATCH] D74252: Fix+re-enable Assert StackFrame Recognizer on Linux

mib added a comment. In D74252#1865501 , @jankratochvil wrote: > In D74252#1865500 , @mib wrote: > > > Knowing that this will be called every time a thread stops, it would be > > better if we could avoid

[Lldb-commits] [PATCH] D74187: [lldb] Add method Language::IsMangledName

mib added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/ObjCLanguage.h:96-98 + bool IsMangledName(llvm::StringRef name) const override { +return false; + } friss wrote: > shafik wrote: > > xiaobai wrote: > > > friss wrote: > > > > The

[Lldb-commits] [PATCH] D74252: Fix+re-enable Assert StackFrame Recognizer on Linux

jankratochvil updated this revision to Diff 243358. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74252/new/ https://reviews.llvm.org/D74252 Files: lldb/include/lldb/Target/StackFrameRecognizer.h lldb/source/Commands/CommandObjectFrame.cpp

[Lldb-commits] [PATCH] D74252: Fix+re-enable Assert StackFrame Recognizer on Linux

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! Thanks for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74252/new/ https://reviews.llvm.org/D74252

[Lldb-commits] [PATCH] D74252: Fix+re-enable Assert StackFrame Recognizer on Linux

mib added a comment. We'd like to avoid registering recognizers multiple times for the same purpose ... This could cause some issues down the road, since those recognizers can - indirectly - perform an action (change the current frame or the stop reason). Also, from a usability stand-point,

[Lldb-commits] [PATCH] D74252: Fix+re-enable Assert StackFrame Recognizer on Linux

mib added a comment. In D74252#1865496 , @jankratochvil wrote: > OK, then it could be changed to a regex. Is it fine afterwards? Knowing that this will be called every time a thread stops, it would be better if we could avoid processing a regex every

[Lldb-commits] [PATCH] D74252: Fix+re-enable Assert StackFrame Recognizer on Linux

jankratochvil added a comment. In D74252#1865500 , @mib wrote: > Knowing that this will be called every time a thread stops, it would be > better if we could avoid processing a regex every time we try to recognise a > frame. Or

[Lldb-commits] [PATCH] D74252: Fix+re-enable Assert StackFrame Recognizer on Linux

jankratochvil added a comment. In D74252#1865504 , @mib wrote: > but let's leave symbol as is and add a `ConstString alternate_symbol` FYI this had a purpose. Any code touching `symbol` should be rechecked if it should not handle also

[Lldb-commits] [PATCH] D73665: Stop emitting a breakpoint for each location in a breakpoint when responding to breakpoint commands.

clayborg updated this revision to Diff 243385. clayborg added a comment. Fixed Pavel's issues. I thoroughly tested this and found that we should be only sending "changed" events for breakpoints since breakpoints never go away. Changed in this patch: - add a "vscode" name to each breakpoint so

[Lldb-commits] [PATCH] D74168: [CMake] Make EXCLUDE_FROM_ALL an argument to add_lit_testsuite

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: llvm/test/CMakeLists.txt:171 +if(LLVM_BUILD_TOOLS) + set(exclude_from_check_all "EXCLUDE_FROM_CHECK_ALL") JDevlieghere wrote: > kschwarz wrote: > > Hi

[Lldb-commits] [PATCH] D74245: [lldb/Plugins] Use external functions to (de)initialize plugins

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rGfbb4d1e43d0d: [lldb/Plugins] Use external functions to (de)initialize plugins (authored by JDevlieghere). Herald added subscribers: jsji, atanasyan, MaskRay,

[Lldb-commits] [PATCH] D74168: [CMake] Make EXCLUDE_FROM_ALL an argument to add_lit_testsuite

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: llvm/test/CMakeLists.txt:171 +if(LLVM_BUILD_TOOLS) + set(exclude_from_check_all "EXCLUDE_FROM_CHECK_ALL") kschwarz wrote: > Hi @JDevlieghere, we've noticed that