[Lldb-commits] [PATCH] D74607: [lldb][NFC] Make all CompilerDeclContext parameters references instead of pointers

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Yes, please. Bonus points to anyone who can replace the default-constructed CompilerDeclContext with llvm::None. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D72158: [DebugInfo] Make most debug line prologue errors non-fatal to parsing

jhenderson marked an inline comment as done. jhenderson added inline comments. Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp:323-325 +// Treat this error as unrecoverable - we cannot be sure what any of +// the data represents including the length field, so

[Lldb-commits] [PATCH] D72158: [DebugInfo] Make most debug line prologue errors non-fatal to parsing

labath added inline comments. Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp:323-325 +// Treat this error as unrecoverable - we cannot be sure what any of +// the data represents including the length field, so cannot skip it or make +// any reasonable

[Lldb-commits] [PATCH] D74607: [lldb][NFC] Make all CompilerDeclContext parameters references instead of pointers

teemperor created this revision. teemperor added reviewers: labath, mib. Herald added subscribers: lldb-commits, JDevlieghere, abidh, arphaman. Herald added a project: LLDB. All of our lookup APIs either use `CompilerDeclContext &` or `CompilerDeclContext *` semi-randomly it seems. This leads to

[Lldb-commits] [lldb] a57ad00 - [lldb] Print result when expect_expr unexpectedly succeeds

Author: Raphael Isemann Date: 2020-02-14T12:57:10+01:00 New Revision: a57ad008b449a95249a42582370a5f0fefccbf03 URL: https://github.com/llvm/llvm-project/commit/a57ad008b449a95249a42582370a5f0fefccbf03 DIFF:

[Lldb-commits] [PATCH] D74244: [lldb] Delete register info definitions in the x86_64 ABI classes

labath marked 6 inline comments as done. labath added inline comments. Comment at: lldb/source/Plugins/ABI/X86/ABISysV_x86_64.cpp:938 + .Case("R8", LLDB_REGNUM_GENERIC_ARG5) + .Case("r9", LLDB_REGNUM_GENERIC_ARG6) + .Default(LLDB_INVALID_REGNUM);

[Lldb-commits] [PATCH] D74244: [lldb] Delete register info definitions in the x86_64 ABI classes

labath updated this revision to Diff 244624. labath marked 3 inline comments as done. labath added a comment. - make functions work on lowercase names - handle singular registers in the remapping function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D74557: [lldb] Make BreakpointResolver hold weak_ptr instead of raw pointer to breakpoint

tatyana-krasnukha updated this revision to Diff 244645. tatyana-krasnukha added a comment. Moved assertion into GetBreakpoint(). > Were there any places you found where it was legit to ask for the Breakpoint > for a resolver and not have one? I didn't find any, however, it seems to be possible

[Lldb-commits] [PATCH] D74579: [don't review]Creating environment variable test for lldbd

wallace added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/environmentVariables/TestVSCode_environmentVariables.py:31-35 +found = False +for line in lines: +if line.startswith('PATH='): +found =

[Lldb-commits] [PATCH] D74607: [lldb][NFC] Make all CompilerDeclContext parameters references instead of pointers

shafik accepted this revision. shafik added a comment. This is a great change, it makes the code more consistent. LGTM besides the few comments I made. Comment at: lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:1133 -if (parent_decl_ctx &&

[Lldb-commits] [PATCH] D74579: [don't review]Creating environment variable test for lldbd

diazhector98 updated this revision to Diff 244717. diazhector98 added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74579/new/ https://reviews.llvm.org/D74579 Files:

[Lldb-commits] [lldb] bba9ba8 - [lldb/Plugin] s/LLDB_PLUGIN/LLDB_PLUGIN_DEFINE/ (NFC)

Author: Jonas Devlieghere Date: 2020-02-14T09:58:24-08:00 New Revision: bba9ba8d953816fd7697cdb647b81510bfa85d71 URL: https://github.com/llvm/llvm-project/commit/bba9ba8d953816fd7697cdb647b81510bfa85d71 DIFF:

[Lldb-commits] [PATCH] D73067: [lldb/CMake] Auto-generate the Initialize and Terminate calls for plugin

JDevlieghere updated this revision to Diff 244700. JDevlieghere added a comment. Address code review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73067/new/ https://reviews.llvm.org/D73067 Files: lldb/include/lldb/Core/PluginManager.h

[Lldb-commits] [PATCH] D74579: [don't review]Creating environment variable test for lldbd

diazhector98 updated this revision to Diff 244719. diazhector98 added a comment. - Merge branch 'master' of https://github.com/llvm/llvm-project Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74579/new/ https://reviews.llvm.org/D74579 Files:

[Lldb-commits] [PATCH] D74475: [lldb] Replace assertTrue(a == b, "msg") with assertEquals(a, b, "msg") in the test suite

stella.stamenova added a comment. In D74475#1875674 , @JDevlieghere wrote: > Yup, looks like that was it, the bot is green again: > http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/13740 Thanks for taking care of it! Repository: rG

[Lldb-commits] [PATCH] D74579: [don't review]Creating environment variable test for lldbd

diazhector98 updated this revision to Diff 244701. diazhector98 added a comment. Working on comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74579/new/ https://reviews.llvm.org/D74579 Files:

[Lldb-commits] [PATCH] D74607: [lldb][NFC] Make all CompilerDeclContext parameters references instead of pointers

teemperor marked an inline comment as done. teemperor added inline comments. Comment at: lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:1133 -if (parent_decl_ctx && GetDeclContextContainingUID( - result->getSymIndexId()) !=

[Lldb-commits] [PATCH] D74637: Unify DIERef vs. user_id_t

jankratochvil created this revision. jankratochvil added reviewers: labath, clayborg. jankratochvil added a project: LLDB. Herald added a subscriber: aprantl. As discussed in D73206 there is both `DIERef` and `user_id_t`

[Lldb-commits] [PATCH] D74636: [DO NOT REVIEW] Add inheritEnvironment option

diazhector98 updated this revision to Diff 244749. diazhector98 added a comment. Adding the test files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74636/new/ https://reviews.llvm.org/D74636 Files:

[Lldb-commits] [lldb] 4f2cccc - [lldb/Editline] Fix mistake in HistoryOperation mapping

Author: Jonas Devlieghere Date: 2020-02-14T14:07:29-08:00 New Revision: 4f25ce89855bfc5cc44f9bb45fec745e7de9 URL: https://github.com/llvm/llvm-project/commit/4f25ce89855bfc5cc44f9bb45fec745e7de9 DIFF:

[Lldb-commits] [PATCH] D74636: [DO NOT REVIEW] Add inheritEnvironment option

diazhector98 created this revision. diazhector98 added a reviewer: wallace. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. . Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D74636 Files: lldb/tools/lldb-vscode/package.json Index:

[Lldb-commits] [PATCH] D74636: [DO NOT REVIEW] Add inheritEnvironment option

diazhector98 updated this revision to Diff 244779. diazhector98 added a comment. Adding test for priority Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74636/new/ https://reviews.llvm.org/D74636 Files:

[Lldb-commits] [PATCH] D74636: [DO NOT REVIEW] Add inheritEnvironment option

diazhector98 updated this revision to Diff 244781. diazhector98 added a comment. Add Makefile Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74636/new/ https://reviews.llvm.org/D74636 Files:

[Lldb-commits] [PATCH] D74636: [DO NOT REVIEW] Add inheritEnvironment option

diazhector98 updated this revision to Diff 244782. diazhector98 added a comment. Removing print Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74636/new/ https://reviews.llvm.org/D74636 Files:

[Lldb-commits] [PATCH] D74636: [DO NOT REVIEW] Add inheritEnvironment option

diazhector98 updated this revision to Diff 244767. diazhector98 added a comment. Continue repair Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74636/new/ https://reviews.llvm.org/D74636 Files:

[Lldb-commits] [PATCH] D74636: [DO NOT REVIEW] Add inheritEnvironment option

diazhector98 updated this revision to Diff 244769. diazhector98 added a comment. Continue repair Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74636/new/ https://reviews.llvm.org/D74636 Files:

[Lldb-commits] [PATCH] D74650: [lldb] WIP: idea for keeping filenames in raw form when coming from DWARF

kwk created this revision. kwk added a reviewer: labath. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. PLEASE DO NOT REVIEW YET. This is for brainstorming an idea with @labath Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D74650 Files:

[Lldb-commits] [PATCH] D74585: Don't prefix error message from process launch with "process launch failed:" boilerplate in Target::Launch

clayborg accepted this revision. clayborg added a comment. fine with me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74585/new/ https://reviews.llvm.org/D74585 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D74557: [lldb] Make BreakpointResolver hold weak_ptr instead of raw pointer to breakpoint

tatyana-krasnukha updated this revision to Diff 244727. tatyana-krasnukha added a reviewer: jingham. tatyana-krasnukha added a comment. Just realized that BreakpointResolverScripted::CreateImplementationIfNeeded should work when m_breakpoint == nullptr. GetBreakpoint with assertion is not

[Lldb-commits] [PATCH] D74636: [DO NOT REVIEW] Add inheritEnvironment option

diazhector98 updated this revision to Diff 244770. diazhector98 added a comment. Continue repair Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74636/new/ https://reviews.llvm.org/D74636 Files:

[Lldb-commits] [PATCH] D74579: [don't review]Creating environment variable test for lldbd

diazhector98 updated this revision to Diff 244721. diazhector98 added a comment. - Comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74579/new/ https://reviews.llvm.org/D74579 Files:

[Lldb-commits] [PATCH] D74636: [DO NOT REVIEW] Add inheritEnvironment option

diazhector98 updated this revision to Diff 244748. diazhector98 added a comment. Add change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74636/new/ https://reviews.llvm.org/D74636 Files: lldb/tools/lldb-vscode/package.json Index:

[Lldb-commits] [PATCH] D74579: [don't review]Creating environment variable test for lldbd

diazhector98 updated this revision to Diff 244723. diazhector98 added a comment. Comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74579/new/ https://reviews.llvm.org/D74579 Files:

[Lldb-commits] [PATCH] D74636: [DO NOT REVIEW] Add inheritEnvironment option

diazhector98 updated this revision to Diff 244763. diazhector98 added a comment. Continued repair Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74636/new/ https://reviews.llvm.org/D74636 Files:

[Lldb-commits] [PATCH] D74636: [DO NOT REVIEW] Add inheritEnvironment option

diazhector98 updated this revision to Diff 244771. diazhector98 added a comment. Comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74636/new/ https://reviews.llvm.org/D74636 Files:

[Lldb-commits] [PATCH] D74598: [lldb/gdb-remote] Add support for the qOffsets packet

clayborg added a comment. > This patch does not implement full scope of the qOffsets packet (which > supports having different biases for code, data and bss sections). This is > because the relevant lldb interfaces (e.g., Module::SetLoadAddress) do not > support passing different values for

[Lldb-commits] [PATCH] D74657: [lldb/Target] Add process crash-info command

mib created this revision. mib added reviewers: JDevlieghere, friss, jingham. mib added a project: LLDB. Herald added a subscriber: lldb-commits. Currently, in macOS, when a process crashes, lldb halts inside the implementation disassembly without yielding any useful information. The only way to

[Lldb-commits] [PATCH] D74660: WIP: [lldb/FileSystem] Add & use CreateReadonlyDataBuffer where possible

vsk created this revision. vsk added reviewers: JDevlieghere, jingham. vsk added a project: LLDB. Herald added a subscriber: aprantl. vsk added subscribers: rupprecht, labath. vsk added a comment. + @labath @rupprecht, my tentative plan is to fix this by having ObjectFileELF make a copy into a

[Lldb-commits] [PATCH] D74659: [lldb/FileSystem] Rename CreateDataBuffer -> CreateWritableDataBuffer, NFC

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74659/new/ https://reviews.llvm.org/D74659 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D74660: WIP: [lldb/FileSystem] Add & use CreateReadonlyDataBuffer where possible

vsk added subscribers: rupprecht, labath. vsk added a comment. + @labath @rupprecht, my tentative plan is to fix this by having ObjectFileELF make a copy into a heap-allocated buffer when applying relocations. Please lmk if that's problematic (although, that seems like a slightly lazier version

[Lldb-commits] [PATCH] D74585: Don't prefix error message from process launch with "process launch failed:" boilerplate in Target::Launch

jasonmolenda updated this revision to Diff 244799. jasonmolenda added a comment. Updated the test to match the new output (how did I miss that??), also for consistency removed the other occurrences of "process launch failed: " across lldb, two of which were only in log messages. CHANGES SINCE

[Lldb-commits] [PATCH] D74636: [DO NOT REVIEW] Add inheritEnvironment option

JDevlieghere added a comment. Hey Héctor, this is generating a lot of traffic on the lldb-commits mailing list. Phabricator is not really designed to iterate quickly. It's not really a problem per se, but I figured I'd let you know. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D74659: [lldb/FileSystem] Rename CreateDataBuffer -> CreateWritableDataBuffer, NFC

vsk created this revision. vsk added reviewers: JDevlieghere, jingham. vsk added a project: LLDB. Some clients of lldb::FileSystem look like they are unintentionally heap-allocating file contents. This patch renames the CreateDataBuffer API to allow clients to express intention more clearly. As

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

paolosev added a comment. In D72751#1869268 , @labath wrote: > yeah, go for it. Hi @labath, can I ask you the favor to land this patch for me? I have rebased it because the logic of SystemInitializers have changed with new macros. I asked commit

[Lldb-commits] [PATCH] D74585: Don't prefix error message from process launch with "process launch failed:" boilerplate in Target::Launch

This revision was automatically updated to reflect the committed changes. Closed by commit rG83bea6d99dd1: Remove process launch failed: message prefix in Target::Launch (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D74657: [lldb/Target] Add process crash-info command

mib updated this revision to Diff 244793. mib added a comment. Run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74657/new/ https://reviews.llvm.org/D74657 Files: lldb/bindings/interface/SBProcess.i

[Lldb-commits] [lldb] 83bea6d - Remove 'process launch failed:' message prefix in Target::Launch

Author: Jason Molenda Date: 2020-02-14T18:42:38-08:00 New Revision: 83bea6d99dd17d893b7160e045700aef6173a49d URL: https://github.com/llvm/llvm-project/commit/83bea6d99dd17d893b7160e045700aef6173a49d DIFF: https://github.com/llvm/llvm-project/commit/83bea6d99dd17d893b7160e045700aef6173a49d.diff

[Lldb-commits] [PATCH] D73067: [lldb/CMake] Auto-generate the Initialize and Terminate calls for plugin

labath added a comment. I think this is great. Just a bit of polishing... Comment at: lldb/include/lldb/Core/PluginManager.h:25-29 #define LLDB_PLUGIN(PluginName) \ namespace lldb_private {

[Lldb-commits] [lldb] 07211d9 - [lldb/dotest] Remove the "exclusive test subdir" concept

Author: Pavel Labath Date: 2020-02-14T10:24:12+01:00 New Revision: 07211d951d584b19951ad8dedbaf7c728297f4b5 URL: https://github.com/llvm/llvm-project/commit/07211d951d584b19951ad8dedbaf7c728297f4b5 DIFF: https://github.com/llvm/llvm-project/commit/07211d951d584b19951ad8dedbaf7c728297f4b5.diff

[Lldb-commits] [PATCH] D74551: [lldb/dotest] Remove the "exclusive test subdir" concept

This revision was automatically updated to reflect the committed changes. Closed by commit rG07211d951d58: [lldb/dotest] Remove the exclusive test subdir concept (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74551/new/

[Lldb-commits] [lldb] 9dc84e9 - [lldb/DWARF] Don't hold a unique SymbolFileDWARFDwo in a DWARFUnit

Author: Pavel Labath Date: 2020-02-14T11:09:45+01:00 New Revision: 9dc84e9b02d1e402503906099d42fbae4da7d8d9 URL: https://github.com/llvm/llvm-project/commit/9dc84e9b02d1e402503906099d42fbae4da7d8d9 DIFF: https://github.com/llvm/llvm-project/commit/9dc84e9b02d1e402503906099d42fbae4da7d8d9.diff

[Lldb-commits] [PATCH] D73782: [lldb/DWARF] Don't hold a unique SymbolFileDWARFDwo in a DWARFUnit

This revision was automatically updated to reflect the committed changes. Closed by commit rG9dc84e9b02d1: [lldb/DWARF] Dont hold a unique SymbolFileDWARFDwo in a DWARFUnit (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 189c701 - [lldb] Remove accidentally checked-in debugging code

Author: Pavel Labath Date: 2020-02-14T10:21:35+01:00 New Revision: 189c701332eb2d80c0bf6bf132abeb4e1ec9e6ce URL: https://github.com/llvm/llvm-project/commit/189c701332eb2d80c0bf6bf132abeb4e1ec9e6ce DIFF: https://github.com/llvm/llvm-project/commit/189c701332eb2d80c0bf6bf132abeb4e1ec9e6ce.diff

[Lldb-commits] [PATCH] D50525: [WIP] Move lldb-mi interpreter tests to LIT

apolyakov abandoned this revision. apolyakov added a comment. Herald added a subscriber: JDevlieghere. Abandoned since the patch is outdated too much. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50525/new/ https://reviews.llvm.org/D50525

[Lldb-commits] [PATCH] D60968: WIP, RFC: Add an example of how LLDB python plug-in could look like

apolyakov abandoned this revision. apolyakov added a comment. Abandoned since for now, it will require a lot of changes to the codebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60968/new/ https://reviews.llvm.org/D60968

[Lldb-commits] [PATCH] D74598: [lldb/gdb-remote] Add support for the qOffsets packet

labath created this revision. labath added reviewers: clayborg, jasonmolenda. Herald added a project: LLDB. This packet is necessary to make lldb work with the remote-gdb stub in user mode qemu when running position-independent binaries. It reports the relative position (load bias) of the loaded