[Lldb-commits] [PATCH] D79999: [lldb] [Windows] Provide vasprintf only for MSVC

mati865 created this revision. mati865 added a project: LLDB. Mingw-w64 provides this function and it has been causing issues for MSYS2 when building lldb. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D7 Files: lldb/include/lldb/Host/windows/PosixApi.h

[Lldb-commits] [lldb] 76c5f27 - Re-land [Debug][CodeView] Emit fully qualified names for globals

Author: Alexandre Ganea Date: 2020-05-15T10:37:09-04:00 New Revision: 76c5f277f25e334404aa44ea0aafd674a627ab74 URL: https://github.com/llvm/llvm-project/commit/76c5f277f25e334404aa44ea0aafd674a627ab74 DIFF:

[Lldb-commits] [PATCH] D79999: [lldb] [Windows] Provide vasprintf only for MSVC

mati865 added a comment. Perhaps you are building with Clang? I don't remember the message but GCC emits error about incompatible definition and declaration of `vasprintf`. I can build it without the patch and paste the error if you want. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D79999: [lldb] [Windows] Provide vasprintf only for MSVC

mstorsjo added a comment. In D7#2039069 , @mati865 wrote: > Perhaps you are building with Clang? > I don't remember the message but GCC emits error about incompatible > definition and declaration of `vasprintf`. I can build it without the patch >

[Lldb-commits] [PATCH] D79999: [lldb] [Windows] Provide vasprintf only for MSVC

mstorsjo added reviewers: labath, amccarth, mstorsjo. mstorsjo added a comment. +1 from me on this, I'm ok with this change. I'm a bit curious as I haven't seen any issues regarding this myself though. I wonder if it something very MSYS2-specific, or is the difference in building with gcc vs

[Lldb-commits] [PATCH] D79447: [Debug][CodeView] Emit fully qualified names for globals

This revision was automatically updated to reflect the committed changes. aganea marked 4 inline comments as done. Closed by commit rG76c5f277f25e: Re-land [Debug][CodeView] Emit fully qualified names for globals (authored by aganea). Changed prior to commit:

[Lldb-commits] [PATCH] D79659: [lldb/Commands] Add ability to run shell command on the host.

mib updated this revision to Diff 264270. mib marked 2 inline comments as done. mib added a comment. Merged the `shell` and `platform shell` test as @JDevlieghere suggested it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79659/new/

[Lldb-commits] [PATCH] D79999: [lldb] [Windows] Provide vasprintf only for MSVC

mati865 added a comment. Indeed, I'll see if I can build all LLVM related packages without `_GNU_SOURCE`. Otherwise I'll guard it with `#ifndef _GNU_SOURCE` instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7/new/

[Lldb-commits] [PATCH] D79659: [lldb/Commands] Add ability to run shell command on the host.

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Comment at: lldb/source/Commands/CommandObjectPlatform.cpp:1590 +void OptionParsingStarting(ExecutionContext *execution_context) override { + m_use_host_platform = false; +}

[Lldb-commits] [lldb] 4e9e048 - [lldb/Commands] Add ability to run shell command on the host.

Author: Med Ismail Bennani Date: 2020-05-15T22:14:39+02:00 New Revision: 4e9e0488ab67c54be57e303ce3085466fbc8e886 URL: https://github.com/llvm/llvm-project/commit/4e9e0488ab67c54be57e303ce3085466fbc8e886 DIFF:

[Lldb-commits] [lldb] 0eba9de - [lldb/Dataformatter] Add support to CF{Dictionary, Set}Ref types

Author: Med Ismail Bennani Date: 2020-05-15T22:14:39+02:00 New Revision: 0eba9de71e2add37dce165f3f3c9447772c3f65a URL: https://github.com/llvm/llvm-project/commit/0eba9de71e2add37dce165f3f3c9447772c3f65a DIFF:

[Lldb-commits] [PATCH] D79659: [lldb/Commands] Add ability to run shell command on the host.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. mib marked an inline comment as done. Closed by commit rG4e9e0488ab67: [lldb/Commands] Add ability to run shell command on the host.

[Lldb-commits] [PATCH] D79554: [lldb/Dataformatter] Add support to CF{Dictionary, Set}Ref types

This revision was automatically updated to reflect the committed changes. mib marked 4 inline comments as done. Closed by commit rG0eba9de71e2a: [lldb/Dataformatter] Add support to CF{Dictionary,Set}Ref types (authored by mib). Changed prior to commit:

[Lldb-commits] [PATCH] D79999: [lldb] [Windows] Provide vasprintf only for MSVC

mati865 updated this revision to Diff 264339. mati865 added a comment. With `_GNU_SOURCE` removed I was able to successfully build everything without this diff. I cannot test it today but I believe this updated diff would have fixed the error. It's up to you whether this should be considered

[Lldb-commits] [lldb] 7c89297 - Correct the argument list of command `breakpoint read`

Author: Gongyu Deng Date: 2020-05-15T09:00:05+02:00 New Revision: 7c89297cf7eecd52327915de587df8183793afac URL: https://github.com/llvm/llvm-project/commit/7c89297cf7eecd52327915de587df8183793afac DIFF: https://github.com/llvm/llvm-project/commit/7c89297cf7eecd52327915de587df8183793afac.diff

[Lldb-commits] [PATCH] D79554: [lldb/Dataformatter] Add support to CF{Dictionary, Set}Ref types

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. IMHO this looks good now. Maybe add a comment to the commit that this adds support for incomplete types in ValueObjects. I think @jingham should also take a look at this to make sure

[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

clayborg added inline comments. Comment at: lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py:447 +] +terminateCommands = ['expr 4+2'] +self.launch(program=program, The expression parser can be quite involved even for simple

[Lldb-commits] [PATCH] D79722: Correct the argument list of command `breakpoint read`

This revision was automatically updated to reflect the committed changes. Closed by commit rG7c89297cf7ee: Correct the argument list of command `breakpoint read` (authored by MrHate, committed by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D79947: [lldb] Print full Clang diagnostics when the ClangModulesDeclVendor fails to compile a module

This revision was automatically updated to reflect the committed changes. Closed by commit rGd48ef7cab558: [lldb] Print full Clang diagnostics when the ClangModulesDeclVendor fails to… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior

[Lldb-commits] [PATCH] D79811: WIP: Reenable creation of artificial methods in AddMethodToCXXRecordType(...)

labath added a comment. I just realized a different problem with this approach. Since the constructor DIE is only emitted when it is actually used, we could run into problems/inconsistencies even within a single library. We currently parse only one instance of a class description -- assuming

[Lldb-commits] [lldb] 8b845ac - Recommit "[lldb] Don't dissasemble large functions by default"

Author: Pavel Labath Date: 2020-05-15T11:57:48+02:00 New Revision: 8b845ac5edc19524817911d703dd314aac2ca97d URL: https://github.com/llvm/llvm-project/commit/8b845ac5edc19524817911d703dd314aac2ca97d DIFF: https://github.com/llvm/llvm-project/commit/8b845ac5edc19524817911d703dd314aac2ca97d.diff

[Lldb-commits] [PATCH] D79554: [lldb/Dataformatter] Add support to CF{Dictionary, Set}Ref types

labath added inline comments. Comment at: lldb/source/Core/ValueObject.cpp:2839-2861 +// In case of C opaque pointers, use the pointee type and try to +// recreate a new ValueObjectChild using it. +if (!m_deref_valobj) { + if

[Lldb-commits] [lldb] 36b9b1e - [lldb] Fixup command-disassemble-process.yaml test

Author: Pavel Labath Date: 2020-05-15T12:35:44+02:00 New Revision: 36b9b1e6171d438105839aac6f333a1c98fda74c URL: https://github.com/llvm/llvm-project/commit/36b9b1e6171d438105839aac6f333a1c98fda74c DIFF: https://github.com/llvm/llvm-project/commit/36b9b1e6171d438105839aac6f333a1c98fda74c.diff