[Lldb-commits] [PATCH] D81898: [lldb/Python] Fix the infinitely looping prompt bug

2020-06-16 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, but some documentation would be nice. Comment at: lldb/source/Interpreter/embedded_interpreter.py:77 +line = sys.stdin.readline() +if not line: +

[Lldb-commits] [PATCH] D81810: LLDB step-instruction gets stuck on jump to self

2020-06-16 Thread Sebastian Österlund via Phabricator via lldb-commits
sirmc added a comment. Yes, I wasn't sure what the exact semantics were for step-inst for LLDB. I think the issue is not mainly the mimicking of GDB behavior, but rather that it is inconvenient for some use-cases. To give some context on why I propose this change: the current behavior is

[Lldb-commits] [lldb] 4dd3dfe - [lldb/Python] Fix the infinitely looping Python prompt bug

2020-06-16 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-06-16T11:05:19-07:00 New Revision: 4dd3dfe8e3266459d855008af78d611071ff99e2 URL: https://github.com/llvm/llvm-project/commit/4dd3dfe8e3266459d855008af78d611071ff99e2 DIFF:

[Lldb-commits] [lldb] e4a8459 - [lldb/Test] Create dir if it doesn't yet exist in getReproducerArtifact

2020-06-16 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-06-16T09:46:48-07:00 New Revision: e4a84590e8ab21077bf47c50fdfeaaa99f617bee URL: https://github.com/llvm/llvm-project/commit/e4a84590e8ab21077bf47c50fdfeaaa99f617bee DIFF:

[Lldb-commits] [PATCH] D81810: LLDB step-instruction gets stuck on jump to self

2020-06-16 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. In D81810#2095902 , @sirmc wrote: > Yes, I wasn't sure what the exact semantics were for step-inst for LLDB. I > think the issue is not mainly the mimicking of GDB behavior, but rather that > it is inconvenient for some

[Lldb-commits] [PATCH] D81200: [vscode] set default values for terminateDebuggee for the disconnect request

2020-06-16 Thread walter erquinigo via Phabricator via lldb-commits
wallace added a comment. @labath , does this look better now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81200/new/ https://reviews.llvm.org/D81200 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

2020-06-16 Thread Shu Anzai via Phabricator via lldb-commits
gedatsu217 updated this revision to Diff 271146. gedatsu217 added a comment. Implementation all ascii characters for TypedCharacter. Making m_use_autosuggestion in Editline.cpp. (I did not know a way to pass the bool value of IOHandlerEditline to Editline constructor, so I made a function,

[Lldb-commits] [PATCH] D81898: [lldb/Python] Fix the infinitely looping prompt bug

2020-06-16 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG4dd3dfe8e326: [lldb/Python] Fix the infinitely looping Python prompt bug (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D81978: Redo of Add terminateCommands to lldb-vscode protocol

2020-06-16 Thread António Afonso via Phabricator via lldb-commits
aadsm accepted this revision. aadsm added a comment. This revision is now accepted and ready to land. Thank you for this! <3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81978/new/ https://reviews.llvm.org/D81978

[Lldb-commits] [PATCH] D81978: Redo of Add terminateCommands to lldb-vscode protocol

2020-06-16 Thread walter erquinigo via Phabricator via lldb-commits
wallace created this revision. wallace added reviewers: clayborg, aadsm, kusmour, labath. wallace added a project: LLDB. wallace edited the summary of this revision. wallace added a parent revision: D81200: [vscode] set default values for terminateDebuggee for the disconnect request. This redoes

[Lldb-commits] [PATCH] D81980: Repair support for launching iphone/tv/watch simulator binaries through platform

2020-06-16 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl created this revision. aprantl added reviewers: friss, jasonmolenda, jingham. and delete a bunch (but not all) redundant code. If you compare the remaining implementations of Platform*Simulator.cpp, there is still an obvious leftover cleanup task. Specifically, this patch - removes

[Lldb-commits] [lldb] c0f1dcf - [lldb/Test] Pass the lldb_tool_dir when setting the lldb-repro substitutions

2020-06-16 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-06-16T13:56:16-07:00 New Revision: c0f1dcf31ee853c33e214d54f12658cf852bf288 URL: https://github.com/llvm/llvm-project/commit/c0f1dcf31ee853c33e214d54f12658cf852bf288 DIFF:

[Lldb-commits] [PATCH] D81200: [vscode] set default values for terminateDebuggee for the disconnect request

2020-06-16 Thread walter erquinigo via Phabricator via lldb-commits
wallace updated this revision to Diff 271224. wallace edited the summary of this revision. wallace added a comment. remove unwanted changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81200/new/ https://reviews.llvm.org/D81200 Files:

[Lldb-commits] [lldb] c151230 - [lldb/Test] Cleanup TestJITLoaderGDB and make it compatible with reproducers

2020-06-16 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-06-16T15:46:14-07:00 New Revision: c151230533e07b8fb3dd20b9a83ba0d79677f54c URL: https://github.com/llvm/llvm-project/commit/c151230533e07b8fb3dd20b9a83ba0d79677f54c DIFF: