[Lldb-commits] [PATCH] D82273: [lldb/Lua] Use the debugger's output and error file for Lua's I/O library.

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.cpp:64 + + if (out) { +lua_pushstring(m_lua_state, "stdout"); JDevlieghere wrote: >

[Lldb-commits] [PATCH] D82297: [lldb] Replace StringConvert with llvm::to_integer when parsing integer values in CommandObjects

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. cool Comment at: lldb/test/API/commands/process/signal/TestProcessSignal.py:10 + +def test_invalid_arg(self): +self.build() @no_debug_info_test

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

labath added inline comments. Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:1875-1878 +if (entry.startswith(line)) { + llvm::StringRef res = entry.substr(line.size()); + result = res.str(); + return result; ``` if

[Lldb-commits] [PATCH] D82378: [lldb/Unwind] Use eh_frame plan directly when it doesn't need to be augmented

labath created this revision. labath added reviewers: jasonmolenda, jankratochvil. Herald added a project: LLDB. This fixes a bug in the logic for choosing the unwind plan. Based on the comment in UnwindAssembly-x86, the intention was that a plan which describes the function epilogue correctly

[Lldb-commits] [lldb] 121e585 - [AArch64][SVE] ACLE: Add bfloat16 to struct load/stores.

Author: Sander de Smalen Date: 2020-06-23T12:12:35+01:00 New Revision: 121e585ec8aa5f973ea56807ed0a73f13ab4937e URL: https://github.com/llvm/llvm-project/commit/121e585ec8aa5f973ea56807ed0a73f13ab4937e DIFF:

[Lldb-commits] [PATCH] D82259: Deprecate error prone temporary directory APIs

davezarzycki updated this revision to Diff 272661. davezarzycki added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Moved clang specific changes to: https://reviews.llvm.org/D82362 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 5a4d780 - [lldb] Split ClangASTSource::CompleteType

Author: Pavel Labath Date: 2020-06-23T11:47:52+02:00 New Revision: 5a4d78064e2cf7ea6b4e59c2b33e936588ae38a5 URL: https://github.com/llvm/llvm-project/commit/5a4d78064e2cf7ea6b4e59c2b33e936588ae38a5 DIFF: https://github.com/llvm/llvm-project/commit/5a4d78064e2cf7ea6b4e59c2b33e936588ae38a5.diff

[Lldb-commits] [PATCH] D81561: [lldb] Add basic -flimit-debug-info support to expression evaluator

labath marked 4 inline comments as done. labath added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangASTImporter.cpp:891 + +if (auto *proxy = llvm::dyn_cast( +getToContext().getExternalSource())) { teemperor wrote: >

[Lldb-commits] [PATCH] D81561: [lldb] Add basic -flimit-debug-info support to expression evaluator

labath updated this revision to Diff 272650. labath marked 4 inline comments as done. labath added a comment. - address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81561/new/ https://reviews.llvm.org/D81561 Files:

[Lldb-commits] [PATCH] D82378: [lldb/Unwind] Use eh_frame plan directly when it doesn't need to be augmented

labath added a comment. In D82378#2109137 , @jankratochvil wrote: > I do not like much this approach but it fixes this case. I would prefer > checking `DW_AT_producer` together with `-grecord-gcc-switches`. > I was trying GCC and clang and all the IMO

[Lldb-commits] [PATCH] D82160: [lldb][PDB] Constexpr static member values as AST literals

aleksandr.urakov accepted this revision. aleksandr.urakov added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82160/new/ https://reviews.llvm.org/D82160

[Lldb-commits] [PATCH] D82382: [lldb][NFC] Replace most uses of StringConvert in LLDB with LLVM's to_integer

teemperor created this revision. teemperor added a reviewer: LLDB. Herald added subscribers: JDevlieghere, abidh. teemperor edited the summary of this revision. This replaces most uses of LLDB's own String to int/float conversion implementation with LLVM's to_integer. The only remaining code in

[Lldb-commits] [lldb] fa1b4a9 - [lldb/Lua] Use the debugger's output and error file for Lua's I/O library.

Author: Jonas Devlieghere Date: 2020-06-23T09:05:51-07:00 New Revision: fa1b4a96a0110c87cdd83eb4ea3e9a0d002c3c3d URL: https://github.com/llvm/llvm-project/commit/fa1b4a96a0110c87cdd83eb4ea3e9a0d002c3c3d DIFF:

[Lldb-commits] [PATCH] D82378: [lldb/Unwind] Use eh_frame plan directly when it doesn't need to be augmented

jankratochvil added a comment. I do not like much this approach but it fixes this case. I would prefer checking `DW_AT_producer` together with `-grecord-gcc-switches`. I was trying GCC and clang and all the IMO relevant options and I can get either no `.eh_frame`/`.debug_frame` or an

[Lldb-commits] [PATCH] D82382: [lldb][NFC] Replace most uses of StringConvert in LLDB with LLVM's to_integer

teemperor marked an inline comment as done. teemperor added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:1508 // thread in big endian hex -tid = StringConvert::ToUInt64(value.c_str(), LLDB_INVALID_THREAD_ID, 16); -if (tid

[Lldb-commits] [lldb] 6e670e0 - [lldb/Lua] Require Lua 5.3

Author: Jonas Devlieghere Date: 2020-06-23T09:24:01-07:00 New Revision: 6e670e079641e9ee8c4552e4d15d51c4f3df5e6d URL: https://github.com/llvm/llvm-project/commit/6e670e079641e9ee8c4552e4d15d51c4f3df5e6d DIFF:

[Lldb-commits] [PATCH] D82378: [lldb/Unwind] Use eh_frame plan directly when it doesn't need to be augmented

jankratochvil added a comment. In D82378#2109330 , @labath wrote: > Now this situation is not actually handled by lldb's "augmenter", so the > example somewhat shaky, but it does show that there are gaps in clang/llvm > modelling of unwind info. Good

[Lldb-commits] [lldb] 2276bb4 - [debugserver] Initial support for Apple Silicon.

Author: Davide Italiano Date: 2020-06-23T10:47:16-07:00 New Revision: 2276bb48be0175f96b1494ca67b7921f0d4e87d8 URL: https://github.com/llvm/llvm-project/commit/2276bb48be0175f96b1494ca67b7921f0d4e87d8 DIFF:

[Lldb-commits] [lldb] d13c3e2 - [lldb][NFC] Add some more tests for edge cases LLDB's builtin formatters

Author: Raphael Isemann Date: 2020-06-23T19:59:46+02:00 New Revision: d13c3e2f88c621d43b583e3040b127924bcebb3e URL: https://github.com/llvm/llvm-project/commit/d13c3e2f88c621d43b583e3040b127924bcebb3e DIFF:

[Lldb-commits] [PATCH] D82394: [debugserver] Initial support for Apple Silicon.

davide added a comment. commit 2276bb48be0175f96b1494ca67b7921f0d4e87d8 (HEAD -> master, origin/master, origin/HEAD) Author: Davide Italiano Date: Tue Jun 23 10:18:54 2020 -0700 [debugserver] Initial support for Apple Silicon. Set the correct os type in the arch

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

gedatsu217 added inline comments. Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:1875-1878 +if (entry.startswith(line)) { + llvm::StringRef res = entry.substr(line.size()); + result = res.str(); + return result; labath wrote: > ```

[Lldb-commits] [PATCH] D82382: [lldb][NFC] Replace most uses of StringConvert in LLDB with LLVM's to_integer

shafik added inline comments. Comment at: lldb/source/Interpreter/OptionValueArray.cpp:209 for (i = 0; i < argc; ++i) { -const size_t idx = -StringConvert::ToSInt32(args.GetArgumentAtIndex(i), INT32_MAX); -if (idx >= size) { +size_t

[Lldb-commits] [PATCH] D82396: [lldb/ScriptInterpreter] Extract IO redirection logic and move it out of ScriptInterpreterPython (NFC)

JDevlieghere created this revision. JDevlieghere added reviewers: labath, LLDB. This patch takes the IO redirection logic from ScriptInterpreterPython and moves it into the interpreter library so that it can be used by other script interpreters. I've turned it into a RAII object so that we

[Lldb-commits] [PATCH] D82273: [lldb/Lua] Use the debugger's output and error file for Lua's I/O library.

JDevlieghere closed this revision. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Forgot the `Differential revision` in front of the phab URL. Closed by fa1b4a96a0110c87cdd83eb4ea3e9a0d002c3c3d

[Lldb-commits] [lldb] 0a9e7d0 - [vscode] set default values for terminateDebuggee for the disconnect request

Author: Walter Erquinigo Date: 2020-06-23T11:47:43-07:00 New Revision: 0a9e7d0b6befad866dfd61f05b774247e0867121 URL: https://github.com/llvm/llvm-project/commit/0a9e7d0b6befad866dfd61f05b774247e0867121 DIFF:

[Lldb-commits] [PATCH] D82394: [debugserver] Initial support for Apple Silicon.

davide added a comment. Danke shoen CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82394/new/ https://reviews.llvm.org/D82394 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D82394: [debugserver] Initial support for Apple Silicon.

davide added a comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82394/new/ https://reviews.llvm.org/D82394 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D81200: [vscode] set default values for terminateDebuggee for the disconnect request

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a9e7d0b6bef: [vscode] set default values for terminateDebuggee for the disconnect request (authored by Walter Erquinigo walterme...@fb.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] 63d5970 - [ObjectFileMachO] Check for TARGET_EMBEDDED instead of listing architectures.

Author: Davide Italiano Date: 2020-06-23T12:37:45-07:00 New Revision: 63d597093cccbb8d4962cf490e2d754a73a77e64 URL: https://github.com/llvm/llvm-project/commit/63d597093cccbb8d4962cf490e2d754a73a77e64 DIFF:

[Lldb-commits] [lldb] 33ece57 - Generalize TestFormattersBoolRefPtr to work on Apple Silicon.

Author: Davide Italiano Date: 2020-06-23T12:45:31-07:00 New Revision: 33ece57241d8ad46cb91eca483f05515849a85e5 URL: https://github.com/llvm/llvm-project/commit/33ece57241d8ad46cb91eca483f05515849a85e5 DIFF:

[Lldb-commits] [lldb] 74ab1da - Redo of Add terminateCommands to lldb-vscode protocol

Author: Walter Erquinigo Date: 2020-06-23T12:51:43-07:00 New Revision: 74ab1da0285fb1f37fdb4648e2c677e97a2a5231 URL: https://github.com/llvm/llvm-project/commit/74ab1da0285fb1f37fdb4648e2c677e97a2a5231 DIFF:

[Lldb-commits] [PATCH] D82378: [lldb/Unwind] Use eh_frame plan directly when it doesn't need to be augmented

jankratochvil added a comment. I do not understand why the testcase has **two** epilogues. The `UnwindAssembly_x86::AugmentUnwindPlanFromCallSite()` code tests only beginning and end of CFI, it does not read anything in between. The simplified testcase works the same for me:

[Lldb-commits] [PATCH] D82160: [lldb][PDB] Constexpr static member values as AST literals

jackoalan added a comment. Thank you! I do not have commit access, so I will need some help with that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82160/new/ https://reviews.llvm.org/D82160 ___

[Lldb-commits] [lldb] 3c79212 - [Host] Check for TARGET_OS_EMBEDDED instead of listing architectures.

Author: Davide Italiano Date: 2020-06-23T12:27:21-07:00 New Revision: 3c79212319d878b07ef259d735b52b379f774e25 URL: https://github.com/llvm/llvm-project/commit/3c79212319d878b07ef259d735b52b379f774e25 DIFF:

[Lldb-commits] [PATCH] D81978: Redo of Add terminateCommands to lldb-vscode protocol

This revision was automatically updated to reflect the committed changes. Closed by commit rG74ab1da0285f: Redo of Add terminateCommands to lldb-vscode protocol (authored by Walter Erquinigo walterme...@fb.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D82160: [lldb][PDB] Constexpr static member values as AST literals

jackoalan created this revision. jackoalan added reviewers: aleksandr.urakov, jasonmolenda, zturner. jackoalan added a project: LLDB. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, lldb-commits, sstefan1. Herald added a project: LLVM. When evaluating an expression

[Lldb-commits] [PATCH] D82187: [AArch64][SVE] ACLE: Add bfloat16 to struct load/stores.

This revision was automatically updated to reflect the committed changes. Closed by commit rG121e585ec8aa: [AArch64][SVE] ACLE: Add bfloat16 to struct load/stores. (authored by sdesmalen). Changed prior to commit: https://reviews.llvm.org/D82187?vs=272342=272678#toc Repository: rG LLVM

[Lldb-commits] [lldb] be494ad - [lldb/Lua] Fix typo: s/stdout/stderr/

Author: Jonas Devlieghere Date: 2020-06-23T14:19:03-07:00 New Revision: be494adb30ec76e1b6738b8bfc22040bfc31ce98 URL: https://github.com/llvm/llvm-project/commit/be494adb30ec76e1b6738b8bfc22040bfc31ce98 DIFF:

[Lldb-commits] [PATCH] D82396: [lldb/ScriptInterpreter] Extract IO redirection logic and move it out of ScriptInterpreterPython (NFC)

JDevlieghere updated this revision to Diff 272825. JDevlieghere added a comment. Consume the error when the result pointer is null. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82396/new/ https://reviews.llvm.org/D82396 Files: lldb/include/lldb/Interpreter/ScriptInterpreter.h

[Lldb-commits] [PATCH] D82412: [lldb/Lua] Redirect Lua stdout/stderr to the CommandReturnObject

JDevlieghere created this revision. JDevlieghere added reviewers: labath, LLDB. JDevlieghere added a parent revision: D82396: [lldb/ScriptInterpreter] Extract IO redirection logic and move it out of ScriptInterpreterPython (NFC). Redirect the output of stdout and stderr to the

[Lldb-commits] [PATCH] D82187: [AArch64][SVE] ACLE: Add bfloat16 to struct load/stores.

sdesmalen updated this revision to Diff 272342. sdesmalen added a comment. - Updated RUN line in tests to fix test failures. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82187/new/ https://reviews.llvm.org/D82187 Files: clang/include/clang/Basic/AArch64SVEACLETypes.def

[Lldb-commits] [PATCH] D82187: [AArch64][SVE] ACLE: Add bfloat16 to struct load/stores.

fpetrogalli added inline comments. Comment at: clang/include/clang/Basic/AArch64SVEACLETypes.def:69 -SVE_VECTOR_TYPE("__SVBFloat16_t", "__SVBFloat16_t", SveBFloat16, SveBFloat16Ty, 8, 16, false, false, true) +SVE_VECTOR_TYPE("__SVBFloat16_t", "__SVBFloat16_t", SveBFloat16,

[Lldb-commits] [PATCH] D82187: [AArch64][SVE] ACLE: Add bfloat16 to struct load/stores.

sdesmalen marked 2 inline comments as done. sdesmalen added inline comments. Comment at: clang/include/clang/Basic/AArch64SVEACLETypes.def:69 -SVE_VECTOR_TYPE("__SVBFloat16_t", "__SVBFloat16_t", SveBFloat16, SveBFloat16Ty, 8, 16, false, false, true)

[Lldb-commits] [PATCH] D82187: [AArch64][SVE] ACLE: Add bfloat16 to struct load/stores.

sdesmalen created this revision. sdesmalen added reviewers: stuij, efriedma, c-rhodes, fpetrogalli. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits, danielkiss, psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added projects: clang, LLDB, LLVM. sdesmalen added a